You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/20 09:28:20 UTC
[GitHub] [skywalking] Lighfer opened a new issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Lighfer opened a new issue #7343:
URL: https://github.com/apache/skywalking/issues/7343
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Bug
https://github.com/apache/skywalking/blob/62411964a46aa22d47319ca863feed3a39169548/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/prometheus/PrometheusMetricConverter.java#L87-L100
I think `Line 91` should be:
```java
.filter(t -> t != NIL && t._2.samples.length > 0)
```
because `line 98` will throw an `IllegalArgumentException` if `samples.length == 0`.
---
https://github.com/apache/skywalking/blob/62411964a46aa22d47319ca863feed3a39169548/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java#L75-L79
I think `line 78` should be:
```java
return new SampleFamily(Arrays.stream(samples).filter(sample -> !Double.isNaN(sample.getValue())).toArray(Sample[]::new), Optional.ofNullable(ctx).orElseGet(RunningContext::instance));
```
because sample's value may be 'NaN'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883248034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Lighfer commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
Lighfer commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883824394
> I think we also should add a NaNSampleFamily as a subclass of `SampleFamily`, what do you think? @hanahmily @Lighfer @wankai123
I think NaN value should just be handled in more details, aggregation operators or other methods in `SampleFamily` should take care of it, but I didn't understand the meaning of adding a NaNSampleFamily class, I think NaN value is meaningful when dealing with those samples where it comes from ,but meaningless when just put all NaN value together？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883248034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883263912
I agree to filter the `NaN` value. We didn't take into account that the double values might be `NaN`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 edited a comment on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wankai123 edited a comment on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883259826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Lighfer commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
Lighfer commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883319556
> Which plugin did you use, `prometheus-fetcher-plugin` or `otel-receiver-plugin`?
> AFAIK the `otel-collector` latest version has the `NaN` issue, the version below 0.29.0 words well.
Latest version too.
According to prometheus/client_golang#85, the NaN is reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wankai123 commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883259826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wankai123 commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883259826
Which plugin did you use, `prometheus-fetcher-plugin` or `otel-receiver-plugin`?
AFAIK the otel latest version has the `NaN` issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883831642
My point is about, we need to put it works in all operations. But NaN is not a number or double, we need to be very careful about how to process it.
We could add a pull request to fliter it first. But more importantly, we should adopt this, rather than filtering it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883346964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wankai123 commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883277585
I got the metrics like this by using `otel-collector 0.30.0`, the `NaN` value from otel-collector, and it seems a duplicate and wrong metric. If we don't know why they send this, I agree to filter the NaN value for defensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883263912
I agree to filter the `NaN` value. We didn't take into account that the double values might be `NaN`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Lighfer commented on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
Lighfer commented on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883319556
> Which plugin did you use, `prometheus-fetcher-plugin` or `otel-receiver-plugin`?
> AFAIK the `otel-collector` latest version has the `NaN` issue, the version below 0.29.0 words well.
Latest version too.
According to prometheus/client_golang#85, the NaN is reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 edited a comment on issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wankai123 edited a comment on issue #7343:
URL: https://github.com/apache/skywalking/issues/7343#issuecomment-883259826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7343: prometheus meter analyzer produce IllegalArgumentException and NaN value
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7343:
URL: https://github.com/apache/skywalking/issues/7343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org