[GitHub] [airflow] jedcunningham commented on a diff in pull request #24784: Container specific extra environment variables

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #24784:
URL: https://github.com/apache/airflow/pull/24784#discussion_r918389081


##########
chart/values.schema.json:
##########
@@ -552,6 +552,11 @@
                                 "IfNotPresent"
                             ],
                             "default": "IfNotPresent"
+                        },
+                        "extraEnv": {
+                            "description": "Add additional env vars to flower.",
+                            "type": "array",
+                            "default": []

Review Comment:
   You should add "items" here so we can properly validate what the user supplies here. e.g:
   https://github.com/apache/airflow/blob/2af19f16a4d94e749bbf6c7c4704e02aac35fc11/chart/values.schema.json#L695-L710



##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -130,6 +130,9 @@ spec:
         {{- if .Values.dagProcessor.extraInitContainers }}
         {{- toYaml .Values.dagProcessor.extraInitContainers | nindent 8 }}
         {{- end }}
+{{- if .Values.dagProcessor.waitForMigrations.extraEnv }}
+{{ tpl (toYaml .Values.dagProcessor.waitForMigrations.extraEnv) $ | indent 12 }}

Review Comment:
   Only waitForMigrations? What about the normal container?



##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -219,6 +219,9 @@ spec:
         {{- if and (.Values.dags.gitSync.enabled) (not .Values.dags.persistence.enabled) }}
         {{- include "git_sync_container" . | indent 8 }}
         {{- end }}
+{{- if .Values.workers.extraEnv }}
+{{ tpl (toYaml .Values.workers.extraEnv) $ | indent 12 }}

Review Comment:
   Why no waitForMigrations here? Don't forget the k8s pod_template_file too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org