You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Sander Striker <st...@apache.org> on 2003/07/17 09:38:40 UTC
Newlines in svn:author, WAS: RE: svn commit: rev 6497 - in trunk/subversion: clients/cmdline include libsvn_client
> From: kraai@tigris.org [mailto:kraai@tigris.org]
> Sent: Thursday, July 17, 2003 11:05 AM
> Author: kraai
> Date: Thu Jul 17 04:04:48 2003
> New Revision: 6497
>
> Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/clients/cmdline/propdel-cmd.c
> trunk/subversion/clients/cmdline/propedit-cmd.c
> trunk/subversion/clients/cmdline/propset-cmd.c
> trunk/subversion/include/svn_client.h
> trunk/subversion/include/svn_error_codes.h
> trunk/subversion/libsvn_client/prop_commands.c
> Log:
> Fix issue #1401: Check for newlines in svn:author revision property.
>
> * subversion/include/svn_error_codes.h
> (SVN_ERR_CLIENT_REVISION_AUTHOR_CONTAINS_NEWLINE): New.
>
> * subversion/include/svn_client.h
> (svn_client_revprop_set): Add force parameter.
>
> * subversion/libsvn_client/prop_commands.c
> (svn_client_revprop_set): Check for newlines in svn:author revision
> property.
>
> * subversion/clients/cmdline/main.c
> (svn_cl__cmd_table): Add force option to propset and propedit.
>
> * subversion/clients/cmdline/propdel-cmd.c
> (svn_cl__propdel): Pass force parameter.
>
> * subversion/clients/cmdline/propset-cmd.c
> (svn_cl__propset): Pass force parameter.
>
> * subversion/clients/cmdline/propedit-cmd.c
> (svn_cl__propedit): Pass force parameter.
I may have missed the discussion around this. I'm not so sure I
like the idea of newlines in the svn:author tag (nor an option to
allow it). Can someone reiterate the issue?
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Newlines in svn:author
Posted by Branko Čibej <br...@xbc.nu>.
pmarek@users.sourceforge.net wrote:
>>Ok, I just saw the reference to #1401. Stripping the newline(s) at the
>>end of the propval like pmarek suggests makes sense in a way.
>>
>>AFAICT, this commit will error when svn:author contains a newline
>>(even at the end). And --force will dismiss the check and commit
>>the propval as is.
>>
>>Is this the desired behaviour?
>>
>>
From my point of view - no.
>It still prohibits simple "svn pe svn:author" - I suggested *removing* a final
>newline, at least for a defined set of properties; taking a newline away in
>all properties will lead to messages like "missing newline at end of line",
>"line not terminated", etc. in some programs.
>
>And if I remember to add the "--force" - "svn log" will be garbled.
>So there's no correct way to edit svn:author with a texteditor, which puts a
>newline at the end of lines.
>
>I'd prefer to have the (last) newline stripped off per default, and by using
>--force the message will be taken as-is.
>
>
We have code to to force correct format (strip trailing and leading
spaces from svn:eol-style, for example) for nore props. We should just
reuse the same code for svn:author, svn:date, and other revision props.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Newlines in svn:author
Posted by pm...@users.sourceforge.net.
> Ok, I just saw the reference to #1401. Stripping the newline(s) at the
> end of the propval like pmarek suggests makes sense in a way.
>
> AFAICT, this commit will error when svn:author contains a newline
> (even at the end). And --force will dismiss the check and commit
> the propval as is.
>
> Is this the desired behaviour?
RE: Newlines in svn:author
Posted by Sander Striker <st...@apache.org>.
> From: Sander Striker [mailto:striker@apache.org]
> Sent: Thursday, July 17, 2003 11:39 AM
> I may have missed the discussion around this. I'm not so sure I
> like the idea of newlines in the svn:author tag (nor an option to
> allow it). Can someone reiterate the issue?
Ok, I just saw the reference to #1401. Stripping the newline(s) at the
end of the propval like pmarek suggests makes sense in a way.
AFAICT, this commit will error when svn:author contains a newline
(even at the end). And --force will dismiss the check and commit
the propval as is.
Is this the desired behaviour?
Sander
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org