[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #18622: Use RTC for elementwise and broadcast ops

[GitBox <gi...@apache.org>]

ptrendx commented on a change in pull request #18622:
URL: https://github.com/apache/incubator-mxnet/pull/18622#discussion_r470413125



##########
File path: tests/python/unittest/test_sparse_operator.py
##########
@@ -1853,152 +1853,6 @@ def check_broadcast_div(mx_lhs, mx_rhs, np_lhs, np_rhs, dtype):
             check_broadcast_mul(mx_lhs, mx_rhs, np_lhs, np_rhs, np.float32)
             check_broadcast_div(mx_lhs, mx_rhs, np_lhs, np_rhs, np.float32)
 
-@with_seed()
-def test_scatter_ops():

Review comment:
       Those scatter ops were used long ago - introduced in #7903 to support sparse adagrad I think and then replaced in different implementation of adagrad in #9651. Still, the ops stayed, and since they were always in `_internal` space, I removed them instead of reworking them to RTC.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org