You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2023/05/24 09:59:11 UTC
[GitHub] [incubator-hugegraph-computer] coderzc opened a new pull request, #245: Use etcd in the k8s to test
coderzc opened a new pull request, #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245
## Purpose of the PR
Use etcd in the k8s to test
## Main Changes
Use etcd in the k8s to test
## Verifying these changes
<!-- Please pick either of the following options -->
- This change is a trivial rework / code cleanup without any test coverage.
*(or)*
- This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
- This change added tests and can be verified as follows:
*(for example:)*
- *Add UT.*
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [x] `Doc - NO Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] javeme commented on a diff in pull request #245: Change etcd url only for ci
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245#discussion_r1204252411
##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/integrate/IntegrateTestSuite.java:
##########
@@ -45,10 +46,13 @@ public static void setup() {
OptionSpace.register("computer",
"org.apache.hugegraph.computer.core.config." +
"ComputerOptions");
- OptionSpace.register("computer-rpc",
- "org.apache.hugegraph.config.RpcOptions");
+ OptionSpace.register("computer-rpc", "org.apache.hugegraph.config.RpcOptions");
Review Comment:
also update ComputerOptions
##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/unit/UnitTestBase.java:
##########
@@ -73,15 +75,26 @@ protected static void clearAll() {
client().graphs().clearGraph(GRAPH, "I'm sure to delete all data");
}
+ @AfterClass
+ public static void cleanup() {
Review Comment:
move to line 150 to keep the customary order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #245: Change etcd url only for ci
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245#discussion_r1203969474
##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/unit/UnitTestBase.java:
##########
@@ -73,15 +75,26 @@ protected static void clearAll() {
client().graphs().clearGraph(GRAPH, "I'm sure to delete all data");
}
+ @AfterClass
+ public static synchronized void cleanup() {
+ if (CLIENT != null) {
Review Comment:
And why need `sync` here?
##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/unit/UnitTestBase.java:
##########
@@ -73,15 +75,26 @@ protected static void clearAll() {
client().graphs().clearGraph(GRAPH, "I'm sure to delete all data");
}
+ @AfterClass
+ public static synchronized void cleanup() {
+ if (CLIENT != null) {
Review Comment:
why need `sync` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin merged pull request #245: chore：change etcd url only for ci
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] coderzc commented on a diff in pull request #245: Change etcd url only for ci
Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc commented on code in PR #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245#discussion_r1204004810
##########
computer-test/src/main/java/org/apache/hugegraph/computer/suite/unit/UnitTestBase.java:
##########
@@ -73,15 +75,26 @@ protected static void clearAll() {
client().graphs().clearGraph(GRAPH, "I'm sure to delete all data");
}
+ @AfterClass
+ public static synchronized void cleanup() {
+ if (CLIENT != null) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-computer] codecov[bot] commented on pull request #245: Change etcd url only for ci
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #245:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/245#issuecomment-1560881806
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#245](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/245?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fd03ac5) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/commit/cc5a7e727d42b5139fc8f5c3bea9ce55a05c9263?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cc5a7e7) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #245 +/- ##
============================================
+ Coverage 85.83% 85.86% +0.03%
- Complexity 3232 3233 +1
============================================
Files 344 344
Lines 12072 12072
Branches 1087 1087
============================================
+ Hits 10362 10366 +4
+ Misses 1185 1181 -4
Partials 525 525
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph-computer/pull/245/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org