You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 00:01:55 UTC

[GitHub] [superset] eschutho commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value

eschutho commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557777358



##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
   }
 
   renderQueryLimit() {
-    const menuDropdown = (
+    // Update the limit dropdown with SQL_ROW_MAX value
+    const { maxRow } = this.props;

Review comment:
       to be safe, should we set a default if not defined?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org