[GitHub] [flink] MartijnVisser commented on a diff in pull request #19681: [FLINK-27544][docs]Example code in 'Structure of Table API and SQL Programs' is out of date and cannot run.

[GitBox <gi...@apache.org>]

MartijnVisser commented on code in PR #19681:
URL: https://github.com/apache/flink/pull/19681#discussion_r884871508


##########
docs/content/docs/dev/table/common.md:
##########
@@ -50,11 +50,11 @@ tableEnv.createTemporaryTable("SourceTable", TableDescriptor.forConnector("datag
     .schema(Schema.newBuilder()
       .column("f0", DataTypes.STRING())
       .build())
-    .option(DataGenOptions.ROWS_PER_SECOND, 100)
+    .option(DataGenConnectorOptions.ROWS_PER_SECOND, 100L)
     .build());
 
 // Create a sink table (using SQL DDL)
-tableEnv.executeSql("CREATE TEMPORARY TABLE SinkTable WITH ('connector' = 'blackhole') LIKE SourceTable");
+tableEnv.executeSql("CREATE TEMPORARY TABLE SinkTable WITH ('connector' = 'blackhole') LIKE SourceTable (EXCLUDING OPTIONS) ");
 
 // Create a Table object from a Table API query
 Table table2 = tableEnv.from("SourceTable");

Review Comment:
   Shouldn't this then be `table1` instead of `table2`? And slightly below, shouldn't `table3` be `table2` ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org