You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Peter Verhas (Jira)" <ji...@apache.org> on 2019/09/27 01:38:00 UTC

[jira] [Updated] (LANG-1491) Unit tests visibility is non-conforming with JUnit 5

     [ https://issues.apache.org/jira/browse/LANG-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Verhas updated LANG-1491:
-------------------------------
    Description: 
The used JUnit 5 library does not require that the unit test classes and methods be {{public}}.

All these {{public}} keywords are only noise in the source code and have to be deleted. Otherwise, the code becomes inconsistent as the new and modified tests will be package protected as per required by the test library and the old tests remain public unnecessarily.

  was:
The used JUnit 5 library does not require that the unit test classes and methods be {{public}}.

All these {{public}} keywords are only noise in the source code and have to be deleted.


> Unit tests visibility is non-conforming with JUnit 5
> ----------------------------------------------------
>
>                 Key: LANG-1491
>                 URL: https://issues.apache.org/jira/browse/LANG-1491
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.9
>            Reporter: Peter Verhas
>            Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The used JUnit 5 library does not require that the unit test classes and methods be {{public}}.
> All these {{public}} keywords are only noise in the source code and have to be deleted. Otherwise, the code becomes inconsistent as the new and modified tests will be package protected as per required by the test library and the old tests remain public unnecessarily.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)