You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/14 08:12:42 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1769: feat: add Cancel Previous Runs CI
LiteSun opened a new pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Removing duplicate CI runs to alleviate CI queuing problems
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-819480533
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1769](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a20d8c3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f9e1006da0da966083ca7f049617524b98b7cbe7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9e1006) will **decrease** coverage by `25.58%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a20d8c3 differs from pull request most recent head 1913548. Consider uploading reports for the commit 1913548 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1769 +/- ##
===========================================
- Coverage 72.50% 46.91% -25.59%
===========================================
Files 113 47 -66
Lines 2695 3129 +434
Branches 650 0 -650
===========================================
- Hits 1954 1468 -486
- Misses 741 1399 +658
- Partials 0 262 +262
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `46.91% <ø> (?)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../components/passive-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvcGFzc2l2ZS1jaGVjay9IZWFsdGh5L0h0dHBTdGF0dXNlcy50c3g=) | | |
| [...tream/components/active-check/Healthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSW50ZXJ2YWwudHN4) | | |
| [web/src/pages/Dashboard/Dashboard.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvRGFzaGJvYXJkLnRzeA==) | | |
| [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | | |
| [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | | |
| [web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==) | | |
| [web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==) | | |
| [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | | |
| [web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz) | | |
| [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | | |
| ... and [150 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1769/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f9e1006...1913548](https://codecov.io/gh/apache/apisix-dashboard/pull/1769?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun closed pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
LiteSun closed pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-819324702
Deploy preview for *apisix-dashboard* processing.
Building with commit a20d8c3cd1d60b657fb67edb136fbc1b15cced88
https://app.netlify.com/sites/apisix-dashboard/deploys/6076a3f13822f800074605e4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun edited a comment on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
LiteSun edited a comment on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-924951428
Duplicate with https://github.com/apache/apisix-dashboard/pull/1795 and close this pr.
A-0: When a GitHub action is running with a new commit, the CI of the previous commit is not automatically cancelled. Need to check if the GitHub action has been updated.
A-1: see https://github.com/styfle/cancel-workflow-action#advanced-canceling-other-workflows docs.
A-2: will not affect each other. see: https://github.com/styfle/cancel-workflow-action#how-does-it-work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-924951428
Duplicate with https://github.com/apache/apisix-dashboard/pull/1795 and close this or.
A-0: When a GitHub action is running with a new commit, the CI of the previous commit is not automatically cancelled. Need to check if the GitHub action has been updated.
A-1: see https://github.com/styfle/cancel-workflow-action#advanced-canceling-other-workflows docs.
A-2: will not affect each other. see: https://github.com/styfle/cancel-workflow-action#how-does-it-work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-819324702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-924582939
Hi, @LiteSun.
This PR has been on for a long time. Is there any change here?
If you do not intend to continue this PR, please let me know and I will close it.
----
At the same time, I also have some doubts about the modifications in PR:
0. Why do you want to do this? I remember that after submitting a new commit, the previous workflow will close automatically.
1. Can we only control workflow ID by hard coding?
2. Will canceling workflow in this way affect each other among different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1769: feat: add Cancel Previous Runs CI
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1769:
URL: https://github.com/apache/apisix-dashboard/pull/1769#issuecomment-819324702
Deploy preview for *apisix-dashboard* ready!
Built with commit 191354870e3e2c87b270ee6bbaa44405a3ef918a
https://deploy-preview-1769--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org