[jira] [Commented] (BIGTOP-2458) Add option to disable IP hostname checking for DataNode registration

["Olaf Flebbe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413274#comment-15413274 ] 

Olaf Flebbe commented on BIGTOP-2458:
-------------------------------------

Regarding the if: Congrats, you found a bug!

Your assumption is correct:

The intention of templating the hdfs-site.xml etc was only to override necessary parameters, leaving out settings which are default. 

So the design was to have puppet class parameters have the value undef, if  the setting has not to be propagated to the output file, or set explicitly, where its value has to be set in the file. 

If one is using {{<% if @parameter %>}} the block is inserted in template if the value is not false. In most occasions that was technically identically to not undef, until you found a parameter defaulting to "false".

The correct syntax is 
{code}
<% if @parameter.nil? -%>
<% end -%>
{code}

and the default value in init.pp should be undef.

Would you mind issueing a new patch? We have to check other values as well.

Thank you very much for your contribution!

> Add option to disable IP hostname checking for DataNode registration
> --------------------------------------------------------------------
>
>                 Key: BIGTOP-2458
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2458
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 1.1.0
>            Reporter: Cory Johns
>            Assignee: Cory Johns
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: BIGTOP-2458.patch, BIGTOP-2458.patch, BIGTOP-2458.patch, BIGTOP-2458.patch, BIGTOP-2458.patch, BIGTOP-2458.patch
>
>
> Add a puppet config option to control ip_hostname_check.  If deploying on a cloud that does not provide reverse DNS service, the DataNode registration to the NameNode will fail.  Exposing this option allows deployments to work around this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)