[jira] [Commented] (HBASE-24641) Add linter checks for patches

["Bharath Vissapragada (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146488#comment-17146488 ] 

Bharath Vissapragada commented on HBASE-24641:
----------------------------------------------

[~phrocker] FYI. Also, do you have a preference for a static analysis tool?

> Add linter checks for patches
> -----------------------------
>
>                 Key: HBASE-24641
>                 URL: https://issues.apache.org/jira/browse/HBASE-24641
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, native-client
>            Reporter: Bharath Vissapragada
>            Priority: Major
>
> I've worked with clang-tidy before and I think it works well. There is also a [helper script|https://clang.llvm.org/extra/doxygen/clang-tidy-diff_8py_source.html] that runs clang-tidy on a patch rather than the entire source tree.
> - pull in clang as a dependency
> - Define .clang-format
> - Run clang-tidy-diff on each checkin
> There are also other tools like cpplint from Google. I don't have any preference, so either works for me.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)