Re: [PR] feat: add non-validated version of FromJson for SortOrder and PartitionSpec [iceberg-cpp]

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #518:
URL: https://github.com/apache/iceberg-cpp/pull/518#discussion_r2710926488


##########
src/iceberg/json_internal.h:
##########
@@ -183,6 +191,14 @@ ICEBERG_EXPORT Result<std::unique_ptr<PartitionSpec>> PartitionSpecFromJson(
     const std::shared_ptr<Schema>& schema, const nlohmann::json& json,
     int32_t default_spec_id);
 
+/// \brief Deserializes a JSON object into an unbound `PartitionSpec` object.

Review Comment:
   ```suggestion
   /// \brief Deserializes a JSON object into a `PartitionSpec` object.
   ```



##########
src/iceberg/json_internal.h:
##########
@@ -75,6 +75,14 @@ ICEBERG_EXPORT nlohmann::json ToJson(const SortOrder& sort_order);
 ICEBERG_EXPORT Result<std::unique_ptr<SortOrder>> SortOrderFromJson(
     const nlohmann::json& json, const std::shared_ptr<Schema>& current_schema);
 
+/// \brief Deserializes a JSON object into an unbound `SortOrder` object.

Review Comment:
   ```suggestion
   /// \brief Deserializes a JSON object into a `SortOrder` object.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org