[jira] [Commented] (MESOS-5331) Some cleanup in filesystem_isolator_tests.cpp

["Jie Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272900#comment-15272900 ] 

Jie Yu commented on MESOS-5331:
-------------------------------

commit 466a960d54bbd51378eb153813d504ebbdca39b4
Author: Guangya Liu <gy...@gmail.com>
Date:   Thu May 5 12:19:37 2016 -0700

    Removed "__linux__" marco from docker runtime isolator test.
    
    Review: https://reviews.apache.org/r/42290/

> Some cleanup in filesystem_isolator_tests.cpp
> ---------------------------------------------
>
>                 Key: MESOS-5331
>                 URL: https://issues.apache.org/jira/browse/MESOS-5331
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>            Assignee: Guangya Liu
>
> There are some issues in {{filesystem_isolator_tests.cpp}} and need some clean up to make sure when we want to make a reference to this file, we can get the right coding style.
> The issues are as following:
> 1) The filesystem_isolator_tests.cpp was already wrapped in OS_LINUX in the makefile, there is no need to define the "__linux__" marco anymore for this test.
> 2) Some unused variables, such as {{containerId}} and {{slaveId}}
> 3) We should avoid using 'using namespace' but include them explicitly.
> 4) Update indent for some functions.
> 5) Replace ".get().xxx" with "->xxx".
> The file of {{runtime_isolator_tests.cpp}} should also have the {{__linux__}} removed as this file was also wrapped in OS_LINUX in the makefile.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)