[GitHub] spark pull request #14789: [SPARK-17209][YARN] Add the ability to manually u...

[mridulm <gi...@git.apache.org>]

Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14789#discussion_r87072908
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala ---
    @@ -64,7 +64,7 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
       // must be protected by `CoarseGrainedSchedulerBackend.this`. Besides, `executorDataMap` should
       // only be modified in `DriverEndpoint.receive/receiveAndReply` with protection by
       // `CoarseGrainedSchedulerBackend.this`.
    -  private val executorDataMap = new HashMap[String, ExecutorData]
    +  protected val executorDataMap = new HashMap[String, ExecutorData]
    --- End diff --
    
    @tgravescs @vanzin Any thoughts on keeping this private and executing a closure on values of map for usecases like this ? (instead of exposing it or creating a copy via toMap). This can also ensure that outside uses will maintain the MT-invariance expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org