You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Varun Thacker (JIRA)" <ji...@apache.org> on 2018/07/20 18:26:00 UTC
[jira] [Commented] (SOLR-12477) Return server error(500) for
AlreadyClosedException instead of client Errors(400)
[ https://issues.apache.org/jira/browse/SOLR-12477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551101#comment-16551101 ]
Varun Thacker commented on SOLR-12477:
--------------------------------------
Hi Jeffery,
Patch looks good to me!
Perhaps we could also assert that the exception thrown at [https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/LeaderTragicEventTest.java#L135] is also an AlreadyClosedException . We could use SolrException.getRootCause to check if it's AlreadyClosedException ?
> Return server error(500) for AlreadyClosedException instead of client Errors(400)
> ---------------------------------------------------------------------------------
>
> Key: SOLR-12477
> URL: https://issues.apache.org/jira/browse/SOLR-12477
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: update
> Affects Versions: 7.3.1, master (8.0)
> Reporter: jefferyyuan
> Assignee: Varun Thacker
> Priority: Minor
> Labels: update
> Fix For: 7.3.2, master (8.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In some cases(for example: corrupt index), addDoc0 throws AlreadyClosedException, but solr server returns client error 400 to client
> This will confuse customers and especially monitoring tool.
> Patch: [https://github.com/apache/lucene-solr/pull/402]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org