You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/14 21:44:15 UTC
Re: Review Request 54087: Updated stout's README.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54087/#review159233
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/README.md
<https://reviews.apache.org/r/54087/#comment230175>
Can we keep this comment and just remove the reference to the fact that we use boost?
3rdparty/stout/README.md (line 442)
<https://reviews.apache.org/r/54087/#comment230177>
Not yours, but `bbannier` and I removed `Set` from stout. Could we just keep the comment about `std::set` operators and remove the mention of `Set` please?
3rdparty/stout/README.md (line 444)
<https://reviews.apache.org/r/54087/#comment230176>
Let's point out that `linkedhashmap` is the thing we're talking about here.
- Michael Park
On Nov. 26, 2016, 12:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54087/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2016, 12:29 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated stout's README.
>
>
> Diffs
> -----
>
> 3rdparty/stout/README.md 80beb4430c28b571854c76ac3925e8b68f21f5f5
>
> Diff: https://reviews.apache.org/r/54087/diff/
>
>
> Testing
> -------
>
> No functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54087: Updated stout's README.
Posted by Neil Conway <ne...@gmail.com>.
> On Dec. 14, 2016, 9:44 p.m., Michael Park wrote:
> > 3rdparty/stout/README.md, line 446
> > <https://reviews.apache.org/r/54087/diff/1/?file=1570639#file1570639line446>
> >
> > Let's point out that `linkedhashmap` is the thing we're talking about here.
We're actually talking about the `Cache` class :) I added some text to described `LinkedHashMap` as well.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54087/#review159233
-----------------------------------------------------------
On Nov. 26, 2016, 8:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54087/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2016, 8:29 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated stout's README.
>
>
> Diffs
> -----
>
> 3rdparty/stout/README.md 80beb4430c28b571854c76ac3925e8b68f21f5f5
>
> Diff: https://reviews.apache.org/r/54087/diff/
>
>
> Testing
> -------
>
> No functional change.
>
>
> Thanks,
>
> Neil Conway
>
>