You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by an...@apache.org on 2016/07/09 05:14:54 UTC

[2/8] mesos git commit: Updated v1 operator 'Call::ReadFile' message.

Updated v1 operator 'Call::ReadFile' message.

Updated the type of offset and length of 'Call::ReadFile'
for v1 operator API.

Review: https://reviews.apache.org/r/49679/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f2a8efbc
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f2a8efbc
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f2a8efbc

Branch: refs/heads/master
Commit: f2a8efbc275b287313e76e02468304fa5035b3db
Parents: da674fc
Author: zhou xing <xi...@cn.ibm.com>
Authored: Fri Jul 8 21:37:01 2016 -0700
Committer: Anand Mazumdar <an...@apache.org>
Committed: Fri Jul 8 21:37:01 2016 -0700

----------------------------------------------------------------------
 include/mesos/agent/agent.proto      | 13 ++++++++++---
 include/mesos/master/master.proto    | 13 ++++++++++---
 include/mesos/v1/agent/agent.proto   | 13 ++++++++++---
 include/mesos/v1/master/master.proto | 13 ++++++++++---
 4 files changed, 40 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/f2a8efbc/include/mesos/agent/agent.proto
----------------------------------------------------------------------
diff --git a/include/mesos/agent/agent.proto b/include/mesos/agent/agent.proto
index ef07b1f..1342293 100644
--- a/include/mesos/agent/agent.proto
+++ b/include/mesos/agent/agent.proto
@@ -45,7 +45,7 @@ message Call {
     SET_LOGGING_LEVEL = 6;  // See 'SetLoggingLevel' below.
 
     LIST_FILES = 7;
-    READ_FILE = 8;
+    READ_FILE = 8;          // See 'ReadFile' below.
 
     GET_STATE = 9;
 
@@ -77,10 +77,17 @@ message Call {
     required string path = 1;
   }
 
+  // Reads data from a file.
   message ReadFile {
+    // The path of file.
     required string path = 1;
-    optional string offset = 2;
-    optional string length = 3;
+
+    // Initial offset in file to start reading from.
+    required uint64 offset = 2;
+
+    // The maximum number of bytes to read. The read length is capped at 16
+    // memory pages.
+    optional uint64 length = 3;
   }
 
   optional Type type = 1;

http://git-wip-us.apache.org/repos/asf/mesos/blob/f2a8efbc/include/mesos/master/master.proto
----------------------------------------------------------------------
diff --git a/include/mesos/master/master.proto b/include/mesos/master/master.proto
index d82b245..25edb5a 100644
--- a/include/mesos/master/master.proto
+++ b/include/mesos/master/master.proto
@@ -51,7 +51,7 @@ message Call {
     SET_LOGGING_LEVEL = 6;  // See 'SetLoggingLevel' below.
 
     LIST_FILES = 7;
-    READ_FILE = 8;
+    READ_FILE = 8;          // See 'ReadFile' below.
 
     GET_STATE = 9;
     GET_STATE_SUMMARY = 10;
@@ -113,10 +113,17 @@ message Call {
     required string path = 1;
   }
 
+  // Reads data from a file.
   message ReadFile {
+    // The path of file.
     required string path = 1;
-    optional string offset = 2;
-    optional string length = 3;
+
+    // Initial offset in file to start reading from.
+    required uint64 offset = 2;
+
+    // The maximum number of bytes to read. The read length is capped at 16
+    // memory pages.
+    optional uint64 length = 3;
   }
 
   message UpdateWeights {

http://git-wip-us.apache.org/repos/asf/mesos/blob/f2a8efbc/include/mesos/v1/agent/agent.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/agent/agent.proto b/include/mesos/v1/agent/agent.proto
index 8f84508..f64dbd2 100644
--- a/include/mesos/v1/agent/agent.proto
+++ b/include/mesos/v1/agent/agent.proto
@@ -45,7 +45,7 @@ message Call {
     SET_LOGGING_LEVEL = 6;  // See 'SetLoggingLevel' below.
 
     LIST_FILES = 7;
-    READ_FILE = 8;
+    READ_FILE = 8;          // See 'ReadFile' below.
 
     GET_STATE = 9;
 
@@ -77,10 +77,17 @@ message Call {
     required string path = 1;
   }
 
+  // Reads data from a file.
   message ReadFile {
+    // The path of file.
     required string path = 1;
-    optional string offset = 2;
-    optional string length = 3;
+
+    // Initial offset in file to start reading from.
+    required uint64 offset = 2;
+
+    // The maximum number of bytes to read. The read length is capped at 16
+    // memory pages.
+    optional uint64 length = 3;
   }
 
   optional Type type = 1;

http://git-wip-us.apache.org/repos/asf/mesos/blob/f2a8efbc/include/mesos/v1/master/master.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/master/master.proto b/include/mesos/v1/master/master.proto
index 711a664..aa1e8dd 100644
--- a/include/mesos/v1/master/master.proto
+++ b/include/mesos/v1/master/master.proto
@@ -51,7 +51,7 @@ message Call {
     SET_LOGGING_LEVEL = 6;  // See 'SetLoggingLevel' below.
 
     LIST_FILES = 7;
-    READ_FILE = 8;
+    READ_FILE = 8;          // See 'ReadFile' below.
 
     GET_STATE = 9;
     GET_STATE_SUMMARY = 10;
@@ -113,10 +113,17 @@ message Call {
     required string path = 1;
   }
 
+  // Reads data from a file.
   message ReadFile {
+    // The path of file.
     required string path = 1;
-    optional string offset = 2;
-    optional string length = 3;
+
+    // Initial offset in file to start reading from.
+    required uint64 offset = 2;
+
+    // The maximum number of bytes to read. The read length is capped at 16
+    // memory pages.
+    optional uint64 length = 3;
   }
 
   message UpdateWeights {