You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/04 08:29:16 UTC
[GitHub] [skywalking] Ax1an opened a new pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Ax1an opened a new pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
Oap self-observability aggregation(Per Minute) chart's meter_instance_metrics_second_aggregation metrics no data.
- How to fix?
Add minute dimensionality second aggregation counter.
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `0.96%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 52.33% -0.97%
+ Complexity 2945 2903 -42
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10097 -204
- Misses 8166 8344 +178
+ Partials 860 853 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 164 -602
Lines 19327 4064 -15263
Branches 1913 481 -1432
============================================
- Hits 10301 0 -10301
+ Misses 8166 4064 -4102
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.37% +0.08%
+ Complexity 2945 2943 -2
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10299 -2
+ Misses 8166 8137 -29
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | | | |
| ... and [5 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `22.93%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 30.20% -22.94%
+ Complexity 2972 1715 -1257
=============================================
Files 773 749 -24
Lines 19418 18852 -566
Branches 1916 1861 -55
=============================================
- Hits 10320 5695 -4625
- Misses 8239 12712 +4473
+ Partials 859 445 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [278 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.07% -0.08%
+ Complexity 2972 2964 -8
============================================
Files 773 770 -3
Lines 19418 19401 -17
Branches 1916 1916
============================================
- Hits 10320 10297 -23
- Misses 8239 8247 +8
+ Partials 859 857 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `55.93% <0.00%> (-5.09%)` | `6.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `59.01% <0.00%> (-3.83%)` | `24.00% <0.00%> (-1.00%)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `37.50% <0.00%> (-1.79%)` | `8.00% <0.00%> (ø%)` | |
| ... and [8 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 147 -619
Lines 19327 3725 -15602
Branches 1913 447 -1466
============================================
- Hits 10301 0 -10301
+ Misses 8166 3725 -4441
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `22.95%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 30.19% -22.96%
+ Complexity 2972 1714 -1258
=============================================
Files 773 749 -24
Lines 19418 18850 -568
Branches 1916 1860 -56
=============================================
- Hits 10320 5692 -4628
- Misses 8239 12713 +4474
+ Partials 859 445 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [282 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 149 -624
Lines 19418 3786 -15632
Branches 1916 454 -1462
============================================
- Hits 10320 0 -10320
+ Misses 8239 3786 -4453
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [740 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `23.21%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.29% 30.08% -23.22%
+ Complexity 2945 1689 -1256
=============================================
Files 766 745 -21
Lines 19327 18798 -529
Branches 1913 1861 -52
=============================================
- Hits 10301 5655 -4646
- Misses 8166 12695 +4529
+ Partials 860 448 -412
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [284 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 52.07% -1.08%
+ Complexity 2972 2929 -43
============================================
Files 773 770 -3
Lines 19418 19391 -27
Branches 1916 1915 -1
============================================
- Hits 10320 10097 -223
- Misses 8239 8456 +217
+ Partials 859 838 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653742133
@hanahmily I received the confirmed bug like this, UI doesn't show minute level
These are the metrics after this PR changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 153 -613
Lines 19327 3826 -15501
Branches 1913 452 -1461
============================================
- Hits 10301 0 -10301
+ Misses 8166 3826 -4340
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [731 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `23.53%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.29% 29.76% -23.54%
+ Complexity 2945 1665 -1280
=============================================
Files 766 745 -21
Lines 19327 18806 -521
Branches 1913 1874 -39
=============================================
- Hits 10301 5597 -4704
- Misses 8166 12771 +4605
+ Partials 860 438 -422
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [289 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `15.36%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 37.78% -15.37%
+ Complexity 2972 2136 -836
=============================================
Files 773 768 -5
Lines 19418 19349 -69
Branches 1916 1911 -5
=============================================
- Hits 10320 7311 -3009
- Misses 8239 11499 +3260
+ Partials 859 539 -320
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [182 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.82%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 51.32% -1.83%
+ Complexity 2972 2905 -67
============================================
Files 773 770 -3
Lines 19418 19394 -24
Branches 1916 1912 -4
============================================
- Hits 10320 9954 -366
- Misses 8239 8603 +364
+ Partials 859 837 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `16.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 36.96% -16.19%
+ Complexity 2972 2101 -871
=============================================
Files 773 768 -5
Lines 19418 19346 -72
Branches 1916 1911 -5
=============================================
- Hits 10320 7151 -3169
- Misses 8239 11657 +3418
+ Partials 859 538 -321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [200 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 151 -615
Lines 19327 3809 -15518
Branches 1913 451 -1462
============================================
- Hits 10301 0 -10301
+ Misses 8166 3809 -4357
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [732 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `22.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 31.13% -22.02%
+ Complexity 2972 1757 -1215
=============================================
Files 773 751 -22
Lines 19418 18882 -536
Branches 1916 1864 -52
=============================================
- Hits 10320 5878 -4442
- Misses 8239 12557 +4318
+ Partials 859 447 -412
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [259 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 51.33% -1.82%
+ Complexity 2972 2905 -67
============================================
Files 773 769 -4
Lines 19418 19390 -28
Branches 1916 1912 -4
============================================
- Hits 10320 9954 -366
- Misses 8239 8599 +360
+ Partials 859 837 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.35% +0.06%
- Complexity 2945 2950 +5
============================================
Files 766 766
Lines 19327 19339 +12
Branches 1913 1913
============================================
+ Hits 10301 10319 +18
+ Misses 8166 8160 -6
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.09% -0.05%
+ Complexity 2972 2965 -7
============================================
Files 773 771 -2
Lines 19418 19405 -13
Branches 1916 1916
============================================
- Hits 10320 10304 -16
- Misses 8239 8243 +4
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `55.93% <0.00%> (-5.09%)` | `6.00% <0.00%> (-1.00%)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `37.50% <0.00%> (-1.79%)` | `8.00% <0.00%> (ø%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| ... and [6 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.82%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 51.32% -1.83%
+ Complexity 2972 2905 -67
============================================
Files 773 770 -3
Lines 19418 19394 -24
Branches 1916 1912 -4
============================================
- Hits 10320 9954 -366
- Misses 8239 8603 +364
+ Partials 859 837 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653741571
> Also, I am not sure what your PR title, where is the bug?
Oap self-observability aggregation(Per Minute) chart's meter_instance_metrics_second_aggregation metrics no data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 162 -604
Lines 19327 4052 -15275
Branches 1913 481 -1432
============================================
- Hits 10301 0 -10301
+ Misses 8166 4052 -4114
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.08% -0.06%
+ Complexity 2972 2965 -7
============================================
Files 773 1409 +636
Lines 19418 30589 +11171
Branches 1916 3404 +1488
============================================
+ Hits 10320 16239 +5919
- Misses 8239 13549 +5310
+ Partials 859 801 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [963 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `18.23%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.29% 35.05% -18.24%
+ Complexity 2945 2000 -945
=============================================
Files 766 761 -5
Lines 19327 19230 -97
Branches 1913 1910 -3
=============================================
- Hits 10301 6742 -3559
- Misses 8166 11971 +3805
+ Partials 860 517 -343
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [220 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754075
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
Why Change this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **increase** coverage by `0.28%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.14% 53.43% +0.28%
+ Complexity 2972 2943 -29
============================================
Files 773 1399 +626
Lines 19418 30384 +10966
Branches 1916 3388 +1472
============================================
+ Hits 10320 16236 +5916
- Misses 8239 13342 +5103
+ Partials 859 806 -53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [974 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.35% +0.05%
+ Complexity 2945 2941 -4
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10294 -7
+ Misses 8166 8141 -25
+ Partials 860 859 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `60.65% <0.00%> (-2.19%)` | `24.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...meter/function/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnSGlzdG9ncmFtUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `61.76% <0.00%> (-0.74%)` | `20.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `11.86%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 41.27% -11.87%
+ Complexity 2972 2391 -581
=============================================
Files 773 751 -22
Lines 19418 18882 -536
Branches 1916 1864 -52
=============================================
- Hits 10320 7794 -2526
- Misses 8239 10403 +2164
+ Partials 859 685 -174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [131 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.09% -0.05%
+ Complexity 2972 2965 -7
============================================
Files 773 771 -2
Lines 19418 19405 -13
Branches 1916 1916
============================================
- Hits 10320 10304 -16
- Misses 8239 8243 +4
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `55.93% <0.00%> (-5.09%)` | `6.00% <0.00%> (-1.00%)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `37.50% <0.00%> (-1.79%)` | `8.00% <0.00%> (ø%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| ... and [6 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `3.39%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 49.75% -3.40%
+ Complexity 2972 2852 -120
============================================
Files 773 768 -5
Lines 19418 19385 -33
Branches 1916 1912 -4
============================================
- Hits 10320 9645 -675
- Misses 8239 8935 +696
+ Partials 859 805 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [45 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 53.20% -0.10%
+ Complexity 2945 2938 -7
============================================
Files 766 766
Lines 19327 19339 +12
Branches 1913 1913
============================================
- Hits 10301 10289 -12
- Misses 8166 8192 +26
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `26.08% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | |
| [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `46.15% <0.00%> (-7.70%)` | `4.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `22.89%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 30.25% -22.90%
+ Complexity 2972 1716 -1256
=============================================
Files 773 749 -24
Lines 19418 18858 -560
Branches 1916 1874 -42
=============================================
- Hits 10320 5705 -4615
- Misses 8239 12708 +4469
+ Partials 859 445 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 51.33% -1.82%
+ Complexity 2972 2905 -67
============================================
Files 773 769 -4
Lines 19418 19390 -28
Branches 1916 1912 -4
============================================
- Hits 10320 9954 -366
- Misses 8239 8599 +360
+ Partials 859 837 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `16.73%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 36.41% -16.74%
+ Complexity 2972 2072 -900
=============================================
Files 773 767 -6
Lines 19418 19307 -111
Branches 1916 1910 -6
=============================================
- Hits 10320 7030 -3290
- Misses 8239 11747 +3508
+ Partials 859 530 -329
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `22.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 31.13% -22.01%
+ Complexity 2972 1757 -1215
=============================================
Files 773 750 -23
Lines 19418 18877 -541
Branches 1916 1864 -52
=============================================
- Hits 10320 5878 -4442
- Misses 8239 12552 +4313
+ Partials 859 447 -412
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [260 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.11% -0.04%
+ Complexity 2972 2965 -7
============================================
Files 773 770 -3
Lines 19418 19401 -17
Branches 1916 1916
============================================
- Hits 10320 10304 -16
Misses 8239 8239
+ Partials 859 858 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `55.93% <0.00%> (-5.09%)` | `6.00% <0.00%> (-1.00%)` | |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `37.50% <0.00%> (-1.79%)` | `8.00% <0.00%> (ø%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 147 -626
Lines 19418 3727 -15691
Branches 1916 447 -1469
============================================
- Hits 10320 0 -10320
+ Misses 8239 3727 -4512
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [743 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449972231
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
These are the metrics in grafana after this PR changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `23.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.29% 30.14% -23.15%
+ Complexity 2945 1692 -1253
=============================================
Files 766 745 -21
Lines 19327 18806 -521
Branches 1913 1875 -38
=============================================
- Hits 10301 5670 -4631
- Misses 8166 12689 +4523
+ Partials 860 447 -413
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [277 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 161 -605
Lines 19327 4047 -15280
Branches 1913 481 -1432
============================================
- Hits 10301 0 -10301
+ Misses 8166 4047 -4119
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [726 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `53.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 0.00% -53.30%
============================================
Files 766 164 -602
Lines 19327 4064 -15263
Branches 1913 481 -1432
============================================
- Hits 10301 0 -10301
+ Misses 8166 4064 -4102
+ Partials 860 0 -860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.43% +0.13%
+ Complexity 2945 2943 -2
============================================
Files 766 1399 +633
Lines 19327 30384 +11057
Branches 1913 3388 +1475
============================================
+ Hits 10301 16236 +5935
- Misses 8166 13342 +5176
+ Partials 860 806 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [960 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449762490
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
From my perspective, minute is better than min. Because DownSampling enum is minute.
I prefer to adjust grafana.json.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449763124
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
@wu-sheng Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.34% +0.04%
- Complexity 2945 2950 +5
============================================
Files 766 767 +1
Lines 19327 19343 +16
Branches 1913 1913
============================================
+ Hits 10301 10319 +18
+ Misses 8166 8164 -2
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...r/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL011bHRpU2NvcGVzQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `70.55% <0.00%> (+2.22%)` | `24.00% <0.00%> (ø%)` | |
| ... and [8 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 53.11% -0.19%
+ Complexity 2945 2932 -13
============================================
Files 766 764 -2
Lines 19327 19333 +6
Branches 1913 1913
============================================
- Hits 10301 10269 -32
- Misses 8166 8209 +43
+ Partials 860 855 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `26.08% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | |
| [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `46.15% <0.00%> (-7.70%)` | `4.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| ... and [25 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 52.95% -0.20%
+ Complexity 2972 2957 -15
============================================
Files 773 770 -3
Lines 19418 19401 -17
Branches 1916 1916
============================================
- Hits 10320 10273 -47
- Misses 8239 8274 +35
+ Partials 859 854 -5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `55.93% <0.00%> (-5.09%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.37% +0.08%
+ Complexity 2945 2943 -2
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10299 -2
+ Misses 8166 8137 -29
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | | | |
| ... and [5 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.37% +0.08%
+ Complexity 2945 2943 -2
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10299 -2
+ Misses 8166 8137 -29
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [5 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 53.04% -0.26%
+ Complexity 2945 2925 -20
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10234 -67
- Misses 8166 8206 +40
+ Partials 860 854 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `4.05% <0.00%> (-31.09%)` | `1.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `4.00% <0.00%> (-1.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `56.60% <0.00%> (-16.99%)` | `8.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `80.00% <0.00%> (-11.43%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.73% <0.00%> (-7.11%)` | `21.00% <0.00%> (-4.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.35% +0.06%
- Complexity 2945 2950 +5
============================================
Files 766 766
Lines 19327 19339 +12
Branches 1913 1913
============================================
+ Hits 10301 10319 +18
+ Misses 8166 8160 -6
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.40% +0.10%
- Complexity 2945 2950 +5
============================================
Files 766 1400 +634
Lines 19327 30423 +11096
Branches 1913 3389 +1476
============================================
+ Hits 10301 16248 +5947
- Misses 8166 13371 +5205
+ Partials 860 804 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [962 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 162 -611
Lines 19418 4045 -15373
Branches 1916 477 -1439
============================================
- Hits 10320 0 -10320
+ Misses 8239 4045 -4194
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [731 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.08% -0.06%
+ Complexity 2972 2965 -7
============================================
Files 773 1409 +636
Lines 19418 30589 +11171
Branches 1916 3404 +1488
============================================
+ Hits 10320 16239 +5919
- Misses 8239 13549 +5310
+ Partials 859 801 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [963 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449812378
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
After a talk with sheng, I agree with renaming it. Pls, to search and update other possible references more than `grafana.json`. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 53.21% -0.09%
+ Complexity 2945 2940 -5
============================================
Files 766 766
Lines 19327 19339 +12
Branches 1913 1913
============================================
- Hits 10301 10291 -10
- Misses 8166 8190 +24
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...alking/apm/agent/core/commands/CommandService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZFNlcnZpY2UuamF2YQ==) | `26.08% <0.00%> (-8.70%)` | `7.00% <0.00%> (-1.00%)` | |
| [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `46.15% <0.00%> (-7.70%)` | `4.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `63.15% <0.00%> (-5.27%)` | `6.00% <0.00%> (-1.00%)` | |
| [...gent/core/profile/ProfileTaskExecutionService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0V4ZWN1dGlvblNlcnZpY2UuamF2YQ==) | `19.48% <0.00%> (-5.20%)` | `8.00% <0.00%> (-1.00%)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 161 -612
Lines 19418 4019 -15399
Branches 1916 477 -1439
============================================
- Hits 10320 0 -10320
+ Misses 8239 4019 -4220
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [732 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.79%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 51.34% -1.80%
+ Complexity 2972 2905 -67
============================================
Files 773 768 -5
Lines 19418 19385 -33
Branches 1916 1912 -4
============================================
- Hits 10320 9954 -366
- Misses 8239 8594 +355
+ Partials 859 837 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [22 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.34% +0.04%
- Complexity 2945 2950 +5
============================================
Files 766 767 +1
Lines 19327 19343 +16
Branches 1913 1913
============================================
+ Hits 10301 10319 +18
+ Misses 8166 8164 -2
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...r/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvcGFyc2VyL2xpc3RlbmVyL011bHRpU2NvcGVzQW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `70.55% <0.00%> (+2.22%)` | `24.00% <0.00%> (ø%)` | |
| ... and [8 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `15.47%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.29% 37.82% -15.48%
+ Complexity 2945 2015 -930
=============================================
Files 766 745 -21
Lines 19327 18863 -464
Branches 1913 1877 -36
=============================================
- Hits 10301 7135 -3166
- Misses 8166 11177 +3011
+ Partials 860 551 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [208 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 163 -610
Lines 19418 4061 -15357
Branches 1916 481 -1435
============================================
- Hits 10320 0 -10320
+ Misses 8239 4061 -4178
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [730 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.93%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 52.20% -0.94%
+ Complexity 2972 2936 -36
============================================
Files 773 770 -3
Lines 19418 19391 -27
Branches 1916 1915 -1
============================================
- Hits 10320 10124 -196
- Misses 8239 8427 +188
+ Partials 859 840 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653742133
@hanahmily I received the confirmed bug like this, UI doesn't show minute level
These are the metrics after this PR changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 153 -620
Lines 19418 3868 -15550
Branches 1916 461 -1455
============================================
- Hits 10320 0 -10320
+ Misses 8239 3868 -4371
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `1.20%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 51.94% -1.21%
+ Complexity 2972 2905 -67
============================================
Files 773 1409 +636
Lines 19418 30591 +11173
Branches 1916 3405 +1489
============================================
+ Hits 10320 15889 +5569
- Misses 8239 13899 +5660
+ Partials 859 803 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.36% <0.00%> (-79.09%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.04% <0.00%> (-77.87%)` | `1.00% <0.00%> (-3.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [967 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `7.36%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 45.77% -7.37%
+ Complexity 2972 2601 -371
============================================
Files 773 752 -21
Lines 19418 18957 -461
Branches 1916 1866 -50
============================================
- Hits 10320 8678 -1642
- Misses 8239 9515 +1276
+ Partials 859 764 -95
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [92 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `11.95%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 41.19% -11.96%
+ Complexity 2972 2391 -581
=============================================
Files 773 752 -21
Lines 19418 18921 -497
Branches 1916 1865 -51
=============================================
- Hits 10320 7794 -2526
- Misses 8239 10442 +2203
+ Partials 859 685 -174
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [130 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 152 -621
Lines 19418 3828 -15590
Branches 1916 454 -1462
============================================
- Hits 10320 0 -10320
+ Misses 8239 3828 -4411
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [740 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `3.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 49.96% -3.19%
+ Complexity 2972 2866 -106
============================================
Files 773 768 -5
Lines 19418 19385 -33
Branches 1916 1912 -4
============================================
- Hits 10320 9686 -634
- Misses 8239 8892 +653
+ Partials 859 807 -52
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [31 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.29% 53.13% -0.17%
+ Complexity 2945 2931 -14
============================================
Files 766 763 -3
Lines 19327 19294 -33
Branches 1913 1912 -1
============================================
- Hits 10301 10251 -50
- Misses 8166 8191 +25
+ Partials 860 852 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `4.05% <0.00%> (-31.09%)` | `1.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `4.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `55.73% <0.00%> (-7.11%)` | `21.00% <0.00%> (-4.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `17.99%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 35.15% -18.00%
+ Complexity 2972 2029 -943
=============================================
Files 773 765 -8
Lines 19418 19282 -136
Branches 1916 1909 -7
=============================================
- Hits 10320 6778 -3542
- Misses 8239 11987 +3748
+ Partials 859 517 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [218 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `2.96%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 50.17% -2.97%
+ Complexity 2972 2860 -112
============================================
Files 773 768 -5
Lines 19418 19377 -41
Branches 1916 1901 -15
============================================
- Hits 10320 9723 -597
- Misses 8239 8836 +597
+ Partials 859 818 -41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754169
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsTransWorker.java
##########
@@ -36,28 +32,12 @@
private final MetricsPersistentWorker hourPersistenceWorker;
private final MetricsPersistentWorker dayPersistenceWorker;
- private final CounterMetrics aggregationHourCounter;
- private final CounterMetrics aggregationDayCounter;
-
public MetricsTransWorker(ModuleDefineHolder moduleDefineHolder,
- String modelName,
MetricsPersistentWorker hourPersistenceWorker,
MetricsPersistentWorker dayPersistenceWorker) {
super(moduleDefineHolder);
this.hourPersistenceWorker = hourPersistenceWorker;
this.dayPersistenceWorker = dayPersistenceWorker;
-
- MetricsCreator metricsCreator = moduleDefineHolder.find(TelemetryModule.NAME)
- .provider()
- .getService(MetricsCreator.class);
- aggregationHourCounter = metricsCreator.createCounter(
- "metrics_aggregation", "The number of rows in aggregation", new MetricsTag.Keys("metricName", "level",
- "dimensionality"
- ), new MetricsTag.Values(modelName, "2", "hour"));
- aggregationDayCounter = metricsCreator.createCounter(
Review comment:
Why remove all these? The downsampling is important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754663
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsTransWorker.java
##########
@@ -36,28 +32,12 @@
private final MetricsPersistentWorker hourPersistenceWorker;
private final MetricsPersistentWorker dayPersistenceWorker;
- private final CounterMetrics aggregationHourCounter;
- private final CounterMetrics aggregationDayCounter;
-
public MetricsTransWorker(ModuleDefineHolder moduleDefineHolder,
- String modelName,
MetricsPersistentWorker hourPersistenceWorker,
MetricsPersistentWorker dayPersistenceWorker) {
super(moduleDefineHolder);
this.hourPersistenceWorker = hourPersistenceWorker;
this.dayPersistenceWorker = dayPersistenceWorker;
-
- MetricsCreator metricsCreator = moduleDefineHolder.find(TelemetryModule.NAME)
- .provider()
- .getService(MetricsCreator.class);
- aggregationHourCounter = metricsCreator.createCounter(
- "metrics_aggregation", "The number of rows in aggregation", new MetricsTag.Keys("metricName", "level",
- "dimensionality"
- ), new MetricsTag.Values(modelName, "2", "hour"));
- aggregationDayCounter = metricsCreator.createCounter(
Review comment:
I didn't remove it. I used model.getDownsampling().getName() in MetricsPersistentWorker class.
The metrics of minutes,hours and days can be exposed.
```
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(model.getName(), "2", model.getDownsampling().getName())
);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 154 -619
Lines 19418 3884 -15534
Branches 1916 458 -1458
============================================
- Hits 10320 0 -10320
+ Misses 8239 3884 -4355
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [738 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.40% +0.10%
- Complexity 2945 2950 +5
============================================
Files 766 1400 +634
Lines 19327 30423 +11096
Branches 1913 3389 +1476
============================================
+ Hits 10301 16248 +5947
- Misses 8166 13371 +5205
+ Partials 860 804 -56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [962 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754476
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
@hanahmily You made the decision. I am not sure whether this is a suitable change. Basically, we don't have code style guidance about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449761810
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
@Ax1an Pleasw update the Grafana config to adopt this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `5.65%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 47.49% -5.66%
+ Complexity 2972 2757 -215
============================================
Files 773 768 -5
Lines 19418 19349 -69
Branches 1916 1911 -5
============================================
- Hits 10320 9190 -1130
- Misses 8239 9384 +1145
+ Partials 859 775 -84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [67 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653741157
Also, I am not sure what your PR title, where is the bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449761255
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
From my perspective, some other references should be updated accordingly. One I can find is `grafana.json` at docs folder. But it's a bit overkill. I prefer to leave it alone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `22.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.14% 30.16% -22.99%
+ Complexity 2972 1713 -1259
=============================================
Files 773 750 -23
Lines 19418 18866 -552
Branches 1916 1864 -52
=============================================
- Hits 10320 5691 -4629
- Misses 8239 12729 +4490
+ Partials 859 446 -413
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.49% <100.00%> (-1.05%)` | `23.00 <1.00> (-1.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [283 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **decrease** coverage by `18.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
=============================================
- Coverage 53.29% 35.21% -18.09%
+ Complexity 2945 1919 -1026
=============================================
Files 766 745 -21
Lines 19327 18860 -467
Branches 1913 1877 -36
=============================================
- Hits 10301 6641 -3660
- Misses 8166 11700 +3534
+ Partials 860 519 -341
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [232 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.05% -0.10%
+ Complexity 2972 2963 -9
============================================
Files 773 770 -3
Lines 19418 19401 -17
Branches 1916 1916
============================================
- Hits 10320 10293 -27
- Misses 8239 8251 +12
+ Partials 859 857 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/server/grpc/GRPCServer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvR1JQQ1NlcnZlci5qYXZh) | `55.93% <0.00%> (-5.09%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `56.62% <0.00%> (-4.82%)` | `12.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `59.01% <0.00%> (-3.83%)` | `24.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 53.08% -0.06%
+ Complexity 2972 2965 -7
============================================
Files 773 1409 +636
Lines 19418 30589 +11171
Branches 1916 3404 +1488
============================================
+ Hits 10320 16239 +5919
- Misses 8239 13549 +5310
+ Partials 859 801 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [963 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.36% +0.06%
+ Complexity 2945 2943 -2
============================================
Files 766 765 -1
Lines 19327 19300 -27
Branches 1913 1912 -1
============================================
- Hits 10301 10299 -2
+ Misses 8166 8143 -23
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.36% +0.06%
+ Complexity 2945 2943 -2
============================================
Files 766 765 -1
Lines 19327 19300 -27
Branches 1913 1912 -1
============================================
- Hits 10301 10299 -2
+ Misses 8166 8143 -23
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.43% +0.13%
+ Complexity 2945 2943 -2
============================================
Files 766 1399 +633
Lines 19327 30384 +11057
Branches 1913 3388 +1475
============================================
+ Hits 10301 16236 +5935
- Misses 8166 13342 +5176
+ Partials 860 806 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [960 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 149 -624
Lines 19418 3773 -15645
Branches 1916 447 -1469
============================================
- Hits 10320 0 -10320
+ Misses 8239 3773 -4466
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [741 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...895340b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/80a534b1bbaef6d92d3ceb1f2a6b0382a6964b40&el=desc) will **decrease** coverage by `53.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
- Coverage 53.14% 0.00% -53.15%
============================================
Files 773 156 -617
Lines 19418 3897 -15521
Branches 1916 459 -1457
============================================
- Hits 10320 0 -10320
+ Misses 8239 3897 -4342
+ Partials 859 0 -859
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [737 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [80a534b...a6c8ddb](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449972104
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
@hanahmily I updated oap.yaml. Other references were not found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.35% +0.05%
+ Complexity 2945 2943 -2
============================================
Files 766 766
Lines 19327 19304 -23
Branches 1913 1912 -1
============================================
- Hits 10301 10299 -2
+ Misses 8166 8147 -19
+ Partials 860 858 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754155
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")
Review comment:
Keep code style uniform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.43% +0.13%
+ Complexity 2945 2943 -2
============================================
Files 766 1399 +633
Lines 19327 30384 +11057
Branches 1913 3388 +1475
============================================
+ Hits 10301 16236 +5935
- Misses 8166 13342 +5176
+ Partials 860 806 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `76.31% <ø> (-2.07%)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `70.00% <ø> (-17.50%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `83.80% <100.00%> (-0.73%)` | `24.00 <1.00> (ø)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [960 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...fb5a65b](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#issuecomment-653739211
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=h1) Report
> Merging [#5028](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/310b8857b2266768ccd9e1338da13c86c313ed3f&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5028 +/- ##
============================================
+ Coverage 53.29% 53.32% +0.02%
- Complexity 2945 2946 +1
============================================
Files 766 766
Lines 19327 19339 +12
Branches 1913 1913
============================================
+ Hits 10301 10312 +11
- Misses 8166 8167 +1
Partials 860 860
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/core/analysis/worker/MetricsAggregateWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NBZ2dyZWdhdGVXb3JrZXIuamF2YQ==) | `78.37% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.70% <ø> (-0.18%)` | `10.00 <0.00> (ø)` | |
| [...erver/core/analysis/worker/MetricsTransWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NUcmFuc1dvcmtlci5qYXZh) | `77.77% <ø> (-9.73%)` | `2.00 <0.00> (ø)` | |
| [.../core/analysis/worker/MetricsPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NQZXJzaXN0ZW50V29ya2VyLmphdmE=) | `85.43% <100.00%> (+0.90%)` | `24.00 <1.00> (ø)` | |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `80.64% <0.00%> (-6.46%)` | `5.00% <0.00%> (-1.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-6.02%)` | `23.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | `56.94% <0.00%> (-1.39%)` | `17.00% <0.00%> (-1.00%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `59.23% <0.00%> (-0.77%)` | `11.00% <0.00%> (-1.00%)` | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5028/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=footer). Last update [310b885...1e6fe73](https://codecov.io/gh/apache/skywalking/pull/5028?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org