You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Kaxil Naik <ka...@gmail.com> on 2019/01/19 16:35:49 UTC

[VOTE] Airflow 1.10.2rc3

Hey all,

I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
which will last for 72 hours. Consider this my (binding) +1.

Airflow 1.10.2 RC3 is available at:
https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/

*apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
with INSTALL instructions.
*apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.

Public keys are available at:
https://dist.apache.org/repos/dist/release/airflow/KEYS

Only votes from PMC members are binding, but members of the community are
encouraged to test the release and vote with "(non-binding)".

Please note that the version number excludes the `rcX` string, so it's now
simply 1.10.2. This will allow us to rename the artifact without modifying
the artifact checksums when we actually release.

Changes since 1.10.2rc2:
*Bugs*:
[AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
[AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
[AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
[AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
UI (#4118)
[AIRFLOW-3141] Handle duration View for missing dag (#3984)
[AIRFLOW-2766] Respect shared datetime across tabs
[AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
(#2450)
[AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
(#4218)
[AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
[AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
does not crash (#3650)
[AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)

*Improvements*:
[AIRFLOW-3302] Small CSS fixes (#4140)
[Airflow-2766] Respect shared datetime across tabs
[AIRFLOW-2776] Compress tree view JSON
[AIRFLOW-2407] Use feature detection for reload() (#3298)
[AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
[AIRFLOW-3348] Update run statistics on dag refresh (#4197)
[AIRFLOW-3125] Monitor Task Instances creation rates (#3966)


*New features*:
[AIRFLOW-2874] Enables FAB's theme support (#3719)
[AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)

*Doc-only Change*:
[AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
[AIRFLOW-3018] Fix Minor issues in Documentation
[AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
[AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
[AIRFLOW-XXX] Fix copy&paste mistake (#4212)
[AIRFLOW-3260] Correct misleading BigQuery error (#4098)
[AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
[AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
[AIRFLOW-XXX] Fix undocumented params in S3_hook
[AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
[AIRFLOW-3070] Refine web UI authentication-related docs (#3863)

Regards,
*Kaxil Naik*

Re: [VOTE] Airflow 1.10.2rc3

Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
I was able to reproduce, to fix I modified the "Viewer" role via the UI
and added permission "can dag read on all_dags" manually.


On 1/21/19 6:49 AM, Deng Xiaodong wrote:
> Hi Kaxil,
> 
> A potential bug found in 1.10.2rc3.
> 
> 
> # Potential Bug:
> 
> Viewer Role can't access pages to which it has permissions
> 
> # How to Reproduce:
> 
> - Under RBAC UI, create a user with "Viewer" role. Then use this
> account to log in.
> - You will be able to access the main page. However, you will not be
> able to access any page of a specific DAG, including Tree, Graph View,
> Gantt, Code View, Landing Time, etc. Literally all the pages of a
> specific DAG. However, in the Role specs, View role has permissions to
> all these pages.
> 
> - After clicking, users are redirected to the main page directly,
> without any explicit warning/error message like "Access Denied".
> 
> # Remarks:
> 
> - I have compared the default permissions which are granted to Viewer
> role between 1.10.0 and 1.10.2rc3. They are all the same.
> - In 1.10.0, Viewer role can access all these pages without any issue.
> - Seems this issue only exists for Viewer role.
> 
> 
> Please let me know if you can reproduce this issue.
> 
> Please consider this as my -1 (non-binding) as well.
> 
> Thanks!
> 
> 
> XD

Re: [VOTE] Airflow 1.10.2rc3

Posted by Kaxil Naik <ka...@gmail.com>.
Hi XD,

Even if this issue exist, it should!'t block the release. As mentioned by
Seelman, you can apply that fix. Remember RBAC is still not a default UI
for this release.

We should aim to have regular releases to fix this kinds of issues. As this
is not blocking and the fix exists, can you change your vote to +1, please?

Regards,
Kaxil

On Mon, Jan 21, 2019, 07:12 Deng Xiaodong <xd.deng.r@gmail.com wrote:

> Hi Feng Tao,
>
> I tried again by deleting the DB and initdb again, the issue is still
> there.
>
> Please note the issue is not “see all the roles”. The issue is after
> logging in as a Viewer role, I can’t access the pages including Tree View,
> Graph View, Task Duration, Gantt, Code View, etc.
>
>
> XD
>
> On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
>
> > Hi Xiaodong,
> >
> > I just tried with a viewer role which can't reproduce your issue. I could
> > see all the roles without any issues. Have you reset your db with this
> rc?
> >
> > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
> wrote:
> >
> > > Hi Kaxil,
> > >
> > > A potential bug found in 1.10.2rc3.
> > >
> > >
> > > # Potential Bug:
> > >
> > > Viewer Role can't access pages to which it has permissions
> > >
> > > # How to Reproduce:
> > >
> > > - Under RBAC UI, create a user with "Viewer" role. Then use this
> > > account to log in.
> > > - You will be able to access the main page. However, you will not be
> > > able to access any page of a specific DAG, including Tree, Graph View,
> > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
> > > specific DAG. However, in the Role specs, View role has permissions to
> > > all these pages.
> > >
> > > - After clicking, users are redirected to the main page directly,
> > > without any explicit warning/error message like "Access Denied".
> > >
> > > # Remarks:
> > >
> > > - I have compared the default permissions which are granted to Viewer
> > > role between 1.10.0 and 1.10.2rc3. They are all the same.
> > > - In 1.10.0, Viewer role can access all these pages without any issue.
> > > - Seems this issue only exists for Viewer role.
> > >
> > >
> > > Please let me know if you can reproduce this issue.
> > >
> > > Please consider this as my -1 (non-binding) as well.
> > >
> > > Thanks!
> > >
> > >
> > > XD
> > >
> > >
> > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com> wrote:
> > >
> > > > Hey all,
> > > >
> > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> > > release,
> > > > which will last for 72 hours. Consider this my (binding) +1.
> > > >
> > > > Airflow 1.10.2 RC3 is available at:
> > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> > > >
> > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
> comes
> > > > with INSTALL instructions.
> > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> > > release.
> > > >
> > > > Public keys are available at:
> > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
> > > >
> > > > Only votes from PMC members are binding, but members of the community
> > are
> > > > encouraged to test the release and vote with "(non-binding)".
> > > >
> > > > Please note that the version number excludes the `rcX` string, so
> it's
> > > now
> > > > simply 1.10.2. This will allow us to rename the artifact without
> > > modifying
> > > > the artifact checksums when we actually release.
> > > >
> > > > Changes since 1.10.2rc2:
> > > > *Bugs*:
> > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> > > > [AIRFLOW-3259] Fix internal server error when displaying charts
> (#4114)
> > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
> modified
> > > via
> > > > UI (#4118)
> > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> > > > [AIRFLOW-2766] Respect shared datetime across tabs
> > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> > > > (#2450)
> > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
> failure
> > > > (#4218)
> > > > [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
> heartbeat
> > > it
> > > > does not crash (#3650)
> > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> > > >
> > > > *Improvements*:
> > > > [AIRFLOW-3302] Small CSS fixes (#4140)
> > > > [Airflow-2766] Respect shared datetime across tabs
> > > > [AIRFLOW-2776] Compress tree view JSON
> > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
> > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> > > >
> > > >
> > > > *New features*:
> > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
> > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> > > >
> > > > *Doc-only Change*:
> > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> > > > [AIRFLOW-3018] Fix Minor issues in Documentation
> > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
> > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> > > >
> > > > Regards,
> > > > *Kaxil Naik*
> > > >
> > >
> >
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by pa...@gmail.com, pa...@gmail.com.
+1 (non-binding)

but it should be noted you have to run airflow initdb to get the super role added; i keep forgetting to do that.

Cheers,
Josh
PXYData

On 2019/01/21 09:53:15, Naik Kaxil <k....@reply.com> wrote: 
> Hi XD,
> 
> I could not replicate that in non-rbac UI but could replicate it on RBAC one.
> 
> Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC (Flask-Admin UI)
> 
> All the below issues don't seem to be a blocker for this release, however I am open to views from all.
> 
> (1) Errors not shown on RBAC UI
> (2) Viewer role issue on RBAC UI
> (3) K8s executor one is also just a matter of having short names for dag_id & task_id.
> 
> Regards,
> Kaxil
> 
> On 21/01/2019, 09:19, "Naik Kaxil" <k....@reply.com> wrote:
> 
>     Hi XD,
>     
>     I will test this and let you know.
>     
>     One more bug cropped up https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone with more K8s experience can have a look at it, please?
>     
>     Regards,
>     Kaxil
>     
>     On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:
>     
>         Hi Kaxil,
>         
>         I found another potential bug which is applicable for both RBAC and
>         non-RBAC UI:
>         
>         Let’s say we’re trying to import a module which doesn’t exist at all, or
>         have any syntax error in the DAG, the DAG will not be parsed. In addition,
>         In earlier version, there will be a warning message appearing at the header
>         part of the UI, describing what exact error there is.
>         
>         But this seems not working in 1.10.2rc3. I have tested with both UI.
>         
>         Please help confirm if you can reproduce this issue.
>         
>         Thanks.
>         
>         XD
>         
>         On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com> wrote:
>         
>         > Hi Feng Tao,
>         >
>         > As mentioned in my previous email to XD, as this is not a BLOCKER and the
>         > fix exist as mentioned by Seelman, can you change your *vote back to +1 *.
>         > And we can fix that in the upcoming release with other fixes which should
>         > be quick and aim to release that in a month as well?
>         >
>         > RBAC is still not the default UI in this release, we have got all the
>         > features in, and using the fix @seelman mentioned, people can already start
>         > using it without any BIG issues.
>         >
>         > Regards,
>         > Kaxil
>         >
>         > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com wrote:
>         >
>         >> Thanks XD and Stefan. I see the issue now. I agree that this should be a
>         >> bug which should be fixed.  Please remove my +1 vote for release if
>         >> possible.
>         >>
>         >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <xd...@gmail.com>
>         >> wrote:
>         >>
>         >> > Hi Feng Tao,
>         >> >
>         >> > I tried again by deleting the DB and initdb again, the issue is still
>         >> > there.
>         >> >
>         >> > Please note the issue is not “see all the roles”. The issue is after
>         >> > logging in as a Viewer role, I can’t access the pages including Tree
>         >> View,
>         >> > Graph View, Task Duration, Gantt, Code View, etc.
>         >> >
>         >> >
>         >> > XD
>         >> >
>         >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
>         >> >
>         >> > > Hi Xiaodong,
>         >> > >
>         >> > > I just tried with a viewer role which can't reproduce your issue. I
>         >> could
>         >> > > see all the roles without any issues. Have you reset your db with this
>         >> > rc?
>         >> > >
>         >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
>         >> > wrote:
>         >> > >
>         >> > > > Hi Kaxil,
>         >> > > >
>         >> > > > A potential bug found in 1.10.2rc3.
>         >> > > >
>         >> > > >
>         >> > > > # Potential Bug:
>         >> > > >
>         >> > > > Viewer Role can't access pages to which it has permissions
>         >> > > >
>         >> > > > # How to Reproduce:
>         >> > > >
>         >> > > > - Under RBAC UI, create a user with "Viewer" role. Then use this
>         >> > > > account to log in.
>         >> > > > - You will be able to access the main page. However, you will not be
>         >> > > > able to access any page of a specific DAG, including Tree, Graph
>         >> View,
>         >> > > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
>         >> > > > specific DAG. However, in the Role specs, View role has permissions
>         >> to
>         >> > > > all these pages.
>         >> > > >
>         >> > > > - After clicking, users are redirected to the main page directly,
>         >> > > > without any explicit warning/error message like "Access Denied".
>         >> > > >
>         >> > > > # Remarks:
>         >> > > >
>         >> > > > - I have compared the default permissions which are granted to
>         >> Viewer
>         >> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
>         >> > > > - In 1.10.0, Viewer role can access all these pages without any
>         >> issue.
>         >> > > > - Seems this issue only exists for Viewer role.
>         >> > > >
>         >> > > >
>         >> > > > Please let me know if you can reproduce this issue.
>         >> > > >
>         >> > > > Please consider this as my -1 (non-binding) as well.
>         >> > > >
>         >> > > > Thanks!
>         >> > > >
>         >> > > >
>         >> > > > XD
>         >> > > >
>         >> > > >
>         >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com>
>         >> wrote:
>         >> > > >
>         >> > > > > Hey all,
>         >> > > > >
>         >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
>         >> > > > release,
>         >> > > > > which will last for 72 hours. Consider this my (binding) +1.
>         >> > > > >
>         >> > > > > Airflow 1.10.2 RC3 is available at:
>         >> > > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>         >> > > > >
>         >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
>         >> > comes
>         >> > > > > with INSTALL instructions.
>         >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
>         >> > > > release.
>         >> > > > >
>         >> > > > > Public keys are available at:
>         >> > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
>         >> > > > >
>         >> > > > > Only votes from PMC members are binding, but members of the
>         >> community
>         >> > > are
>         >> > > > > encouraged to test the release and vote with "(non-binding)".
>         >> > > > >
>         >> > > > > Please note that the version number excludes the `rcX` string, so
>         >> > it's
>         >> > > > now
>         >> > > > > simply 1.10.2. This will allow us to rename the artifact without
>         >> > > > modifying
>         >> > > > > the artifact checksums when we actually release.
>         >> > > > >
>         >> > > > > Changes since 1.10.2rc2:
>         >> > > > > *Bugs*:
>         >> > > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
>         >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI
>         >> (#3804)
>         >> > > > > [AIRFLOW-3259] Fix internal server error when displaying charts
>         >> > (#4114)
>         >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
>         >> > modified
>         >> > > > via
>         >> > > > > UI (#4118)
>         >> > > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
>         >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
>         >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with
>         >> unexpected
>         >> > > > > (#2450)
>         >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
>         >> > failure
>         >> > > > > (#4218)
>         >> > > > > [AIRFLOW-3245] Fix list processing in resolve_template_files
>         >> (#4086)
>         >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
>         >> > heartbeat
>         >> > > > it
>         >> > > > > does not crash (#3650)
>         >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>         >> > > > >
>         >> > > > > *Improvements*:
>         >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
>         >> > > > > [Airflow-2766] Respect shared datetime across tabs
>         >> > > > > [AIRFLOW-2776] Compress tree view JSON
>         >> > > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
>         >> > > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
>         >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
>         >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>         >> > > > >
>         >> > > > >
>         >> > > > > *New features*:
>         >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>         >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>         >> > > > >
>         >> > > > > *Doc-only Change*:
>         >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>         >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
>         >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
>         >> > > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
>         >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>         >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
>         >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
>         >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>         >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>         >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment
>         >> (#3963)
>         >> > > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>         >> > > > >
>         >> > > > > Regards,
>         >> > > > > *Kaxil Naik*
>         >> > > > >
>         >> > > >
>         >> > >
>         >> >
>         >>
>         >
>         
>     
>     
>     
>     Kaxil Naik 
>     
>     Data Reply
>     Nova South
>     160 Victoria Street, Westminster
>     London SW1E 5LB - UK 
>     phone: +44 (0)20 7730 6000
>     k.naik@reply.com
>     www.reply.com
>     
> 
> 
> 
> Kaxil Naik 
> 
> Data Reply
> Nova South
> 160 Victoria Street, Westminster
> London SW1E 5LB - UK 
> phone: +44 (0)20 7730 6000
> k.naik@reply.com
> www.reply.com
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Tao Feng <fe...@gmail.com>.
My vote is changed to 0 for this RC. I have prepared a pr to fix the viewer
issue(https://github.com/apache/airflow/pull/4569). @Deng Xiaodong
<xd...@gmail.com>  could you test the pr and see if the issue
still exists?


On Mon, Jan 21, 2019 at 11:05 AM Kaxil Naik <ka...@gmail.com> wrote:

> @FengTao
>
> Do you have a "-1" vote or "+1" vote?
>
> On Mon, Jan 21, 2019, 18:21 Tao Feng <fengtao04@gmail.com wrote:
>
>> Create a jira for the viewer bug(
>> https://issues.apache.org/jira/browse/AIRFLOW-3745).
>>
>> On Mon, Jan 21, 2019 at 9:12 AM Deng Xiaodong <xd...@gmail.com>
>> wrote:
>>
>>> Hi Kaxil,
>>>
>>>
>>> After double-checking, I believe the Viewer access/permission issue is
>>> not a bug actually. Seems it's because the DAG-level access control
>>> feature is cherry-picked into 1.10.2rc3.
>>>
>>>
>>> But my understanding is this feature is still under development?
>>> @feng-tao kindly advise.
>>>
>>>
>>> On the other hand, if we really plan to include DAG-level access control
>>> feature in 1.10.2, we should make sure the doc is consistent (for example,
>>> PR https://github.com/apache/airflow/pull/4426 should be included).
>>>
>>>
>>>
>>> XD
>>>
>>> On Mon, Jan 21, 2019 at 15:23 Naik Kaxil <k....@reply.com> wrote:
>>>
>>>> Hi XD,
>>>>
>>>> I could not replicate that in non-rbac UI but could replicate it on
>>>> RBAC one.
>>>>
>>>> Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC
>>>> (Flask-Admin UI)
>>>>
>>>> All the below issues don't seem to be a blocker for this release,
>>>> however I am open to views from all.
>>>>
>>>> (1) Errors not shown on RBAC UI
>>>> (2) Viewer role issue on RBAC UI
>>>> (3) K8s executor one is also just a matter of having short names for
>>>> dag_id & task_id.
>>>>
>>>> Regards,
>>>> Kaxil
>>>>
>>>> On 21/01/2019, 09:19, "Naik Kaxil" <k....@reply.com> wrote:
>>>>
>>>>     Hi XD,
>>>>
>>>>     I will test this and let you know.
>>>>
>>>>     One more bug cropped up
>>>> https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone
>>>> with more K8s experience can have a look at it, please?
>>>>
>>>>     Regards,
>>>>     Kaxil
>>>>
>>>>     On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:
>>>>
>>>>         Hi Kaxil,
>>>>
>>>>         I found another potential bug which is applicable for both RBAC
>>>> and
>>>>         non-RBAC UI:
>>>>
>>>>         Let’s say we’re trying to import a module which doesn’t exist
>>>> at all, or
>>>>         have any syntax error in the DAG, the DAG will not be parsed.
>>>> In addition,
>>>>         In earlier version, there will be a warning message appearing
>>>> at the header
>>>>         part of the UI, describing what exact error there is.
>>>>
>>>>         But this seems not working in 1.10.2rc3. I have tested with
>>>> both UI.
>>>>
>>>>         Please help confirm if you can reproduce this issue.
>>>>
>>>>         Thanks.
>>>>
>>>>         XD
>>>>
>>>>         On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com>
>>>> wrote:
>>>>
>>>>         > Hi Feng Tao,
>>>>         >
>>>>         > As mentioned in my previous email to XD, as this is not a
>>>> BLOCKER and the
>>>>         > fix exist as mentioned by Seelman, can you change your *vote
>>>> back to +1 *.
>>>>         > And we can fix that in the upcoming release with other fixes
>>>> which should
>>>>         > be quick and aim to release that in a month as well?
>>>>         >
>>>>         > RBAC is still not the default UI in this release, we have got
>>>> all the
>>>>         > features in, and using the fix @seelman mentioned, people can
>>>> already start
>>>>         > using it without any BIG issues.
>>>>         >
>>>>         > Regards,
>>>>         > Kaxil
>>>>         >
>>>>         > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com
>>>> wrote:
>>>>         >
>>>>         >> Thanks XD and Stefan. I see the issue now. I agree that this
>>>> should be a
>>>>         >> bug which should be fixed.  Please remove my +1 vote for
>>>> release if
>>>>         >> possible.
>>>>         >>
>>>>         >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <
>>>> xd.deng.r@gmail.com>
>>>>         >> wrote:
>>>>         >>
>>>>         >> > Hi Feng Tao,
>>>>         >> >
>>>>         >> > I tried again by deleting the DB and initdb again, the
>>>> issue is still
>>>>         >> > there.
>>>>         >> >
>>>>         >> > Please note the issue is not “see all the roles”. The
>>>> issue is after
>>>>         >> > logging in as a Viewer role, I can’t access the pages
>>>> including Tree
>>>>         >> View,
>>>>         >> > Graph View, Task Duration, Gantt, Code View, etc.
>>>>         >> >
>>>>         >> >
>>>>         >> > XD
>>>>         >> >
>>>>         >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <
>>>> fengtao04@gmail.com> wrote:
>>>>         >> >
>>>>         >> > > Hi Xiaodong,
>>>>         >> > >
>>>>         >> > > I just tried with a viewer role which can't reproduce
>>>> your issue. I
>>>>         >> could
>>>>         >> > > see all the roles without any issues. Have you reset
>>>> your db with this
>>>>         >> > rc?
>>>>         >> > >
>>>>         >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <
>>>> xd.deng.r@gmail.com>
>>>>         >> > wrote:
>>>>         >> > >
>>>>         >> > > > Hi Kaxil,
>>>>         >> > > >
>>>>         >> > > > A potential bug found in 1.10.2rc3.
>>>>         >> > > >
>>>>         >> > > >
>>>>         >> > > > # Potential Bug:
>>>>         >> > > >
>>>>         >> > > > Viewer Role can't access pages to which it has
>>>> permissions
>>>>         >> > > >
>>>>         >> > > > # How to Reproduce:
>>>>         >> > > >
>>>>         >> > > > - Under RBAC UI, create a user with "Viewer" role.
>>>> Then use this
>>>>         >> > > > account to log in.
>>>>         >> > > > - You will be able to access the main page. However,
>>>> you will not be
>>>>         >> > > > able to access any page of a specific DAG, including
>>>> Tree, Graph
>>>>         >> View,
>>>>         >> > > > Gantt, Code View, Landing Time, etc. Literally all the
>>>> pages of a
>>>>         >> > > > specific DAG. However, in the Role specs, View role
>>>> has permissions
>>>>         >> to
>>>>         >> > > > all these pages.
>>>>         >> > > >
>>>>         >> > > > - After clicking, users are redirected to the main
>>>> page directly,
>>>>         >> > > > without any explicit warning/error message like
>>>> "Access Denied".
>>>>         >> > > >
>>>>         >> > > > # Remarks:
>>>>         >> > > >
>>>>         >> > > > - I have compared the default permissions which are
>>>> granted to
>>>>         >> Viewer
>>>>         >> > > > role between 1.10.0 and 1.10.2rc3. They are all the
>>>> same.
>>>>         >> > > > - In 1.10.0, Viewer role can access all these pages
>>>> without any
>>>>         >> issue.
>>>>         >> > > > - Seems this issue only exists for Viewer role.
>>>>         >> > > >
>>>>         >> > > >
>>>>         >> > > > Please let me know if you can reproduce this issue.
>>>>         >> > > >
>>>>         >> > > > Please consider this as my -1 (non-binding) as well.
>>>>         >> > > >
>>>>         >> > > > Thanks!
>>>>         >> > > >
>>>>         >> > > >
>>>>         >> > > > XD
>>>>         >> > > >
>>>>         >> > > >
>>>>         >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <
>>>> kaxilnaik@gmail.com>
>>>>         >> wrote:
>>>>         >> > > >
>>>>         >> > > > > Hey all,
>>>>         >> > > > >
>>>>         >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling
>>>> a vote on the
>>>>         >> > > > release,
>>>>         >> > > > > which will last for 72 hours. Consider this my
>>>> (binding) +1.
>>>>         >> > > > >
>>>>         >> > > > > Airflow 1.10.2 RC3 is available at:
>>>>         >> > > > >
>>>> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>>>>         >> > > > >
>>>>         >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source
>>>> release that
>>>>         >> > comes
>>>>         >> > > > > with INSTALL instructions.
>>>>         >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary
>>>> Python "sdist"
>>>>         >> > > > release.
>>>>         >> > > > >
>>>>         >> > > > > Public keys are available at:
>>>>         >> > > > >
>>>> https://dist.apache.org/repos/dist/release/airflow/KEYS
>>>>         >> > > > >
>>>>         >> > > > > Only votes from PMC members are binding, but members
>>>> of the
>>>>         >> community
>>>>         >> > > are
>>>>         >> > > > > encouraged to test the release and vote with
>>>> "(non-binding)".
>>>>         >> > > > >
>>>>         >> > > > > Please note that the version number excludes the
>>>> `rcX` string, so
>>>>         >> > it's
>>>>         >> > > > now
>>>>         >> > > > > simply 1.10.2. This will allow us to rename the
>>>> artifact without
>>>>         >> > > > modifying
>>>>         >> > > > > the artifact checksums when we actually release.
>>>>         >> > > > >
>>>>         >> > > > > Changes since 1.10.2rc2:
>>>>         >> > > > > *Bugs*:
>>>>         >> > > > > [AIRFLOW-3732] Fix issue when trying to edit
>>>> connection in RBAC UI
>>>>         >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when
>>>> using RBAC UI
>>>>         >> (#3804)
>>>>         >> > > > > [AIRFLOW-3259] Fix internal server error when
>>>> displaying charts
>>>>         >> > (#4114)
>>>>         >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC
>>>> Permissions
>>>>         >> > modified
>>>>         >> > > > via
>>>>         >> > > > > UI (#4118)
>>>>         >> > > > > [AIRFLOW-3141] Handle duration View for missing dag
>>>> (#3984)
>>>>         >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
>>>>         >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error
>>>> message with
>>>>         >> unexpected
>>>>         >> > > > > (#2450)
>>>>         >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete
>>>> on timeout
>>>>         >> > failure
>>>>         >> > > > > (#4218)
>>>>         >> > > > > [AIRFLOW-3245] Fix list processing in
>>>> resolve_template_files
>>>>         >> (#4086)
>>>>         >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from
>>>> scheduler's
>>>>         >> > heartbeat
>>>>         >> > > > it
>>>>         >> > > > > does not crash (#3650)
>>>>         >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean
>>>> cli (#3886)
>>>>         >> > > > >
>>>>         >> > > > > *Improvements*:
>>>>         >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
>>>>         >> > > > > [Airflow-2766] Respect shared datetime across tabs
>>>>         >> > > > > [AIRFLOW-2776] Compress tree view JSON
>>>>         >> > > > > [AIRFLOW-2407] Use feature detection for reload()
>>>> (#3298)
>>>>         >> > > > > [AIRFLOW-3452] Removed an unused/dangerous
>>>> display-none (#4295)
>>>>         >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh
>>>> (#4197)
>>>>         >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates
>>>> (#3966)
>>>>         >> > > > >
>>>>         >> > > > >
>>>>         >> > > > > *New features*:
>>>>         >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>>>>         >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream
>>>> failures (#4182)
>>>>         >> > > > >
>>>>         >> > > > > *Doc-only Change*:
>>>>         >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>>>>         >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
>>>>         >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos
>>>> Operator (#4289)
>>>>         >> > > > > [AIRFLOW-3382] Fix incorrect docstring in
>>>> DatastoreHook (#4222)
>>>>         >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>>>>         >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error
>>>> (#4098)
>>>>         >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring
>>>> (#4016)
>>>>         >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation
>>>> (#3998)
>>>>         >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>>>>         >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute
>>>> method comment
>>>>         >> (#3963)
>>>>         >> > > > > [AIRFLOW-3070] Refine web UI authentication-related
>>>> docs (#3863)
>>>>         >> > > > >
>>>>         >> > > > > Regards,
>>>>         >> > > > > *Kaxil Naik*
>>>>         >> > > > >
>>>>         >> > > >
>>>>         >> > >
>>>>         >> >
>>>>         >>
>>>>         >
>>>>
>>>>
>>>>
>>>>
>>>>     Kaxil Naik
>>>>
>>>>     Data Reply
>>>>     Nova South
>>>>     160 Victoria Street, Westminster
>>>>     London SW1E 5LB - UK
>>>>     phone: +44 (0)20 7730 6000
>>>>     k.naik@reply.com
>>>>     www.reply.com
>>>>
>>>>
>>>>
>>>>
>>>> Kaxil Naik
>>>>
>>>> Data Reply
>>>> Nova South
>>>> 160 Victoria Street, Westminster
>>>> London SW1E 5LB - UK
>>>> phone: +44 (0)20 7730 6000
>>>> k.naik@reply.com
>>>> www.reply.com
>>>>
>>>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Kaxil Naik <ka...@gmail.com>.
@FengTao

Do you have a "-1" vote or "+1" vote?

On Mon, Jan 21, 2019, 18:21 Tao Feng <fengtao04@gmail.com wrote:

> Create a jira for the viewer bug(
> https://issues.apache.org/jira/browse/AIRFLOW-3745).
>
> On Mon, Jan 21, 2019 at 9:12 AM Deng Xiaodong <xd...@gmail.com> wrote:
>
>> Hi Kaxil,
>>
>>
>> After double-checking, I believe the Viewer access/permission issue is
>> not a bug actually. Seems it's because the DAG-level access control
>> feature is cherry-picked into 1.10.2rc3.
>>
>>
>> But my understanding is this feature is still under development?
>> @feng-tao kindly advise.
>>
>>
>> On the other hand, if we really plan to include DAG-level access control
>> feature in 1.10.2, we should make sure the doc is consistent (for example,
>> PR https://github.com/apache/airflow/pull/4426 should be included).
>>
>>
>>
>> XD
>>
>> On Mon, Jan 21, 2019 at 15:23 Naik Kaxil <k....@reply.com> wrote:
>>
>>> Hi XD,
>>>
>>> I could not replicate that in non-rbac UI but could replicate it on RBAC
>>> one.
>>>
>>> Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC
>>> (Flask-Admin UI)
>>>
>>> All the below issues don't seem to be a blocker for this release,
>>> however I am open to views from all.
>>>
>>> (1) Errors not shown on RBAC UI
>>> (2) Viewer role issue on RBAC UI
>>> (3) K8s executor one is also just a matter of having short names for
>>> dag_id & task_id.
>>>
>>> Regards,
>>> Kaxil
>>>
>>> On 21/01/2019, 09:19, "Naik Kaxil" <k....@reply.com> wrote:
>>>
>>>     Hi XD,
>>>
>>>     I will test this and let you know.
>>>
>>>     One more bug cropped up
>>> https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone
>>> with more K8s experience can have a look at it, please?
>>>
>>>     Regards,
>>>     Kaxil
>>>
>>>     On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:
>>>
>>>         Hi Kaxil,
>>>
>>>         I found another potential bug which is applicable for both RBAC
>>> and
>>>         non-RBAC UI:
>>>
>>>         Let’s say we’re trying to import a module which doesn’t exist at
>>> all, or
>>>         have any syntax error in the DAG, the DAG will not be parsed. In
>>> addition,
>>>         In earlier version, there will be a warning message appearing at
>>> the header
>>>         part of the UI, describing what exact error there is.
>>>
>>>         But this seems not working in 1.10.2rc3. I have tested with both
>>> UI.
>>>
>>>         Please help confirm if you can reproduce this issue.
>>>
>>>         Thanks.
>>>
>>>         XD
>>>
>>>         On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com>
>>> wrote:
>>>
>>>         > Hi Feng Tao,
>>>         >
>>>         > As mentioned in my previous email to XD, as this is not a
>>> BLOCKER and the
>>>         > fix exist as mentioned by Seelman, can you change your *vote
>>> back to +1 *.
>>>         > And we can fix that in the upcoming release with other fixes
>>> which should
>>>         > be quick and aim to release that in a month as well?
>>>         >
>>>         > RBAC is still not the default UI in this release, we have got
>>> all the
>>>         > features in, and using the fix @seelman mentioned, people can
>>> already start
>>>         > using it without any BIG issues.
>>>         >
>>>         > Regards,
>>>         > Kaxil
>>>         >
>>>         > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com
>>> wrote:
>>>         >
>>>         >> Thanks XD and Stefan. I see the issue now. I agree that this
>>> should be a
>>>         >> bug which should be fixed.  Please remove my +1 vote for
>>> release if
>>>         >> possible.
>>>         >>
>>>         >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <
>>> xd.deng.r@gmail.com>
>>>         >> wrote:
>>>         >>
>>>         >> > Hi Feng Tao,
>>>         >> >
>>>         >> > I tried again by deleting the DB and initdb again, the
>>> issue is still
>>>         >> > there.
>>>         >> >
>>>         >> > Please note the issue is not “see all the roles”. The issue
>>> is after
>>>         >> > logging in as a Viewer role, I can’t access the pages
>>> including Tree
>>>         >> View,
>>>         >> > Graph View, Task Duration, Gantt, Code View, etc.
>>>         >> >
>>>         >> >
>>>         >> > XD
>>>         >> >
>>>         >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com>
>>> wrote:
>>>         >> >
>>>         >> > > Hi Xiaodong,
>>>         >> > >
>>>         >> > > I just tried with a viewer role which can't reproduce
>>> your issue. I
>>>         >> could
>>>         >> > > see all the roles without any issues. Have you reset your
>>> db with this
>>>         >> > rc?
>>>         >> > >
>>>         >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <
>>> xd.deng.r@gmail.com>
>>>         >> > wrote:
>>>         >> > >
>>>         >> > > > Hi Kaxil,
>>>         >> > > >
>>>         >> > > > A potential bug found in 1.10.2rc3.
>>>         >> > > >
>>>         >> > > >
>>>         >> > > > # Potential Bug:
>>>         >> > > >
>>>         >> > > > Viewer Role can't access pages to which it has
>>> permissions
>>>         >> > > >
>>>         >> > > > # How to Reproduce:
>>>         >> > > >
>>>         >> > > > - Under RBAC UI, create a user with "Viewer" role. Then
>>> use this
>>>         >> > > > account to log in.
>>>         >> > > > - You will be able to access the main page. However,
>>> you will not be
>>>         >> > > > able to access any page of a specific DAG, including
>>> Tree, Graph
>>>         >> View,
>>>         >> > > > Gantt, Code View, Landing Time, etc. Literally all the
>>> pages of a
>>>         >> > > > specific DAG. However, in the Role specs, View role has
>>> permissions
>>>         >> to
>>>         >> > > > all these pages.
>>>         >> > > >
>>>         >> > > > - After clicking, users are redirected to the main page
>>> directly,
>>>         >> > > > without any explicit warning/error message like "Access
>>> Denied".
>>>         >> > > >
>>>         >> > > > # Remarks:
>>>         >> > > >
>>>         >> > > > - I have compared the default permissions which are
>>> granted to
>>>         >> Viewer
>>>         >> > > > role between 1.10.0 and 1.10.2rc3. They are all the
>>> same.
>>>         >> > > > - In 1.10.0, Viewer role can access all these pages
>>> without any
>>>         >> issue.
>>>         >> > > > - Seems this issue only exists for Viewer role.
>>>         >> > > >
>>>         >> > > >
>>>         >> > > > Please let me know if you can reproduce this issue.
>>>         >> > > >
>>>         >> > > > Please consider this as my -1 (non-binding) as well.
>>>         >> > > >
>>>         >> > > > Thanks!
>>>         >> > > >
>>>         >> > > >
>>>         >> > > > XD
>>>         >> > > >
>>>         >> > > >
>>>         >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <
>>> kaxilnaik@gmail.com>
>>>         >> wrote:
>>>         >> > > >
>>>         >> > > > > Hey all,
>>>         >> > > > >
>>>         >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling
>>> a vote on the
>>>         >> > > > release,
>>>         >> > > > > which will last for 72 hours. Consider this my
>>> (binding) +1.
>>>         >> > > > >
>>>         >> > > > > Airflow 1.10.2 RC3 is available at:
>>>         >> > > > >
>>> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>>>         >> > > > >
>>>         >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source
>>> release that
>>>         >> > comes
>>>         >> > > > > with INSTALL instructions.
>>>         >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary
>>> Python "sdist"
>>>         >> > > > release.
>>>         >> > > > >
>>>         >> > > > > Public keys are available at:
>>>         >> > > > >
>>> https://dist.apache.org/repos/dist/release/airflow/KEYS
>>>         >> > > > >
>>>         >> > > > > Only votes from PMC members are binding, but members
>>> of the
>>>         >> community
>>>         >> > > are
>>>         >> > > > > encouraged to test the release and vote with
>>> "(non-binding)".
>>>         >> > > > >
>>>         >> > > > > Please note that the version number excludes the
>>> `rcX` string, so
>>>         >> > it's
>>>         >> > > > now
>>>         >> > > > > simply 1.10.2. This will allow us to rename the
>>> artifact without
>>>         >> > > > modifying
>>>         >> > > > > the artifact checksums when we actually release.
>>>         >> > > > >
>>>         >> > > > > Changes since 1.10.2rc2:
>>>         >> > > > > *Bugs*:
>>>         >> > > > > [AIRFLOW-3732] Fix issue when trying to edit
>>> connection in RBAC UI
>>>         >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using
>>> RBAC UI
>>>         >> (#3804)
>>>         >> > > > > [AIRFLOW-3259] Fix internal server error when
>>> displaying charts
>>>         >> > (#4114)
>>>         >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC
>>> Permissions
>>>         >> > modified
>>>         >> > > > via
>>>         >> > > > > UI (#4118)
>>>         >> > > > > [AIRFLOW-3141] Handle duration View for missing dag
>>> (#3984)
>>>         >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
>>>         >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message
>>> with
>>>         >> unexpected
>>>         >> > > > > (#2450)
>>>         >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete
>>> on timeout
>>>         >> > failure
>>>         >> > > > > (#4218)
>>>         >> > > > > [AIRFLOW-3245] Fix list processing in
>>> resolve_template_files
>>>         >> (#4086)
>>>         >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from
>>> scheduler's
>>>         >> > heartbeat
>>>         >> > > > it
>>>         >> > > > > does not crash (#3650)
>>>         >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean
>>> cli (#3886)
>>>         >> > > > >
>>>         >> > > > > *Improvements*:
>>>         >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
>>>         >> > > > > [Airflow-2766] Respect shared datetime across tabs
>>>         >> > > > > [AIRFLOW-2776] Compress tree view JSON
>>>         >> > > > > [AIRFLOW-2407] Use feature detection for reload()
>>> (#3298)
>>>         >> > > > > [AIRFLOW-3452] Removed an unused/dangerous
>>> display-none (#4295)
>>>         >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh
>>> (#4197)
>>>         >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates
>>> (#3966)
>>>         >> > > > >
>>>         >> > > > >
>>>         >> > > > > *New features*:
>>>         >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>>>         >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream
>>> failures (#4182)
>>>         >> > > > >
>>>         >> > > > > *Doc-only Change*:
>>>         >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>>>         >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
>>>         >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos
>>> Operator (#4289)
>>>         >> > > > > [AIRFLOW-3382] Fix incorrect docstring in
>>> DatastoreHook (#4222)
>>>         >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>>>         >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error
>>> (#4098)
>>>         >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring
>>> (#4016)
>>>         >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation
>>> (#3998)
>>>         >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>>>         >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method
>>> comment
>>>         >> (#3963)
>>>         >> > > > > [AIRFLOW-3070] Refine web UI authentication-related
>>> docs (#3863)
>>>         >> > > > >
>>>         >> > > > > Regards,
>>>         >> > > > > *Kaxil Naik*
>>>         >> > > > >
>>>         >> > > >
>>>         >> > >
>>>         >> >
>>>         >>
>>>         >
>>>
>>>
>>>
>>>
>>>     Kaxil Naik
>>>
>>>     Data Reply
>>>     Nova South
>>>     160 Victoria Street, Westminster
>>>     London SW1E 5LB - UK
>>>     phone: +44 (0)20 7730 6000
>>>     k.naik@reply.com
>>>     www.reply.com
>>>
>>>
>>>
>>>
>>> Kaxil Naik
>>>
>>> Data Reply
>>> Nova South
>>> 160 Victoria Street, Westminster
>>> London SW1E 5LB - UK
>>> phone: +44 (0)20 7730 6000
>>> k.naik@reply.com
>>> www.reply.com
>>>
>>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Tao Feng <fe...@gmail.com>.
Create a jira for the viewer bug(
https://issues.apache.org/jira/browse/AIRFLOW-3745).

On Mon, Jan 21, 2019 at 9:12 AM Deng Xiaodong <xd...@gmail.com> wrote:

> Hi Kaxil,
>
>
> After double-checking, I believe the Viewer access/permission issue is not
> a bug actually. Seems it's because the DAG-level access control feature
> is cherry-picked into 1.10.2rc3.
>
>
> But my understanding is this feature is still under development? @feng-tao
> kindly advise.
>
>
> On the other hand, if we really plan to include DAG-level access control
> feature in 1.10.2, we should make sure the doc is consistent (for example,
> PR https://github.com/apache/airflow/pull/4426 should be included).
>
>
>
> XD
>
> On Mon, Jan 21, 2019 at 15:23 Naik Kaxil <k....@reply.com> wrote:
>
>> Hi XD,
>>
>> I could not replicate that in non-rbac UI but could replicate it on RBAC
>> one.
>>
>> Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC
>> (Flask-Admin UI)
>>
>> All the below issues don't seem to be a blocker for this release, however
>> I am open to views from all.
>>
>> (1) Errors not shown on RBAC UI
>> (2) Viewer role issue on RBAC UI
>> (3) K8s executor one is also just a matter of having short names for
>> dag_id & task_id.
>>
>> Regards,
>> Kaxil
>>
>> On 21/01/2019, 09:19, "Naik Kaxil" <k....@reply.com> wrote:
>>
>>     Hi XD,
>>
>>     I will test this and let you know.
>>
>>     One more bug cropped up
>> https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone
>> with more K8s experience can have a look at it, please?
>>
>>     Regards,
>>     Kaxil
>>
>>     On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:
>>
>>         Hi Kaxil,
>>
>>         I found another potential bug which is applicable for both RBAC
>> and
>>         non-RBAC UI:
>>
>>         Let’s say we’re trying to import a module which doesn’t exist at
>> all, or
>>         have any syntax error in the DAG, the DAG will not be parsed. In
>> addition,
>>         In earlier version, there will be a warning message appearing at
>> the header
>>         part of the UI, describing what exact error there is.
>>
>>         But this seems not working in 1.10.2rc3. I have tested with both
>> UI.
>>
>>         Please help confirm if you can reproduce this issue.
>>
>>         Thanks.
>>
>>         XD
>>
>>         On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com>
>> wrote:
>>
>>         > Hi Feng Tao,
>>         >
>>         > As mentioned in my previous email to XD, as this is not a
>> BLOCKER and the
>>         > fix exist as mentioned by Seelman, can you change your *vote
>> back to +1 *.
>>         > And we can fix that in the upcoming release with other fixes
>> which should
>>         > be quick and aim to release that in a month as well?
>>         >
>>         > RBAC is still not the default UI in this release, we have got
>> all the
>>         > features in, and using the fix @seelman mentioned, people can
>> already start
>>         > using it without any BIG issues.
>>         >
>>         > Regards,
>>         > Kaxil
>>         >
>>         > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com
>> wrote:
>>         >
>>         >> Thanks XD and Stefan. I see the issue now. I agree that this
>> should be a
>>         >> bug which should be fixed.  Please remove my +1 vote for
>> release if
>>         >> possible.
>>         >>
>>         >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <
>> xd.deng.r@gmail.com>
>>         >> wrote:
>>         >>
>>         >> > Hi Feng Tao,
>>         >> >
>>         >> > I tried again by deleting the DB and initdb again, the issue
>> is still
>>         >> > there.
>>         >> >
>>         >> > Please note the issue is not “see all the roles”. The issue
>> is after
>>         >> > logging in as a Viewer role, I can’t access the pages
>> including Tree
>>         >> View,
>>         >> > Graph View, Task Duration, Gantt, Code View, etc.
>>         >> >
>>         >> >
>>         >> > XD
>>         >> >
>>         >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com>
>> wrote:
>>         >> >
>>         >> > > Hi Xiaodong,
>>         >> > >
>>         >> > > I just tried with a viewer role which can't reproduce your
>> issue. I
>>         >> could
>>         >> > > see all the roles without any issues. Have you reset your
>> db with this
>>         >> > rc?
>>         >> > >
>>         >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <
>> xd.deng.r@gmail.com>
>>         >> > wrote:
>>         >> > >
>>         >> > > > Hi Kaxil,
>>         >> > > >
>>         >> > > > A potential bug found in 1.10.2rc3.
>>         >> > > >
>>         >> > > >
>>         >> > > > # Potential Bug:
>>         >> > > >
>>         >> > > > Viewer Role can't access pages to which it has
>> permissions
>>         >> > > >
>>         >> > > > # How to Reproduce:
>>         >> > > >
>>         >> > > > - Under RBAC UI, create a user with "Viewer" role. Then
>> use this
>>         >> > > > account to log in.
>>         >> > > > - You will be able to access the main page. However, you
>> will not be
>>         >> > > > able to access any page of a specific DAG, including
>> Tree, Graph
>>         >> View,
>>         >> > > > Gantt, Code View, Landing Time, etc. Literally all the
>> pages of a
>>         >> > > > specific DAG. However, in the Role specs, View role has
>> permissions
>>         >> to
>>         >> > > > all these pages.
>>         >> > > >
>>         >> > > > - After clicking, users are redirected to the main page
>> directly,
>>         >> > > > without any explicit warning/error message like "Access
>> Denied".
>>         >> > > >
>>         >> > > > # Remarks:
>>         >> > > >
>>         >> > > > - I have compared the default permissions which are
>> granted to
>>         >> Viewer
>>         >> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
>>         >> > > > - In 1.10.0, Viewer role can access all these pages
>> without any
>>         >> issue.
>>         >> > > > - Seems this issue only exists for Viewer role.
>>         >> > > >
>>         >> > > >
>>         >> > > > Please let me know if you can reproduce this issue.
>>         >> > > >
>>         >> > > > Please consider this as my -1 (non-binding) as well.
>>         >> > > >
>>         >> > > > Thanks!
>>         >> > > >
>>         >> > > >
>>         >> > > > XD
>>         >> > > >
>>         >> > > >
>>         >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <
>> kaxilnaik@gmail.com>
>>         >> wrote:
>>         >> > > >
>>         >> > > > > Hey all,
>>         >> > > > >
>>         >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a
>> vote on the
>>         >> > > > release,
>>         >> > > > > which will last for 72 hours. Consider this my
>> (binding) +1.
>>         >> > > > >
>>         >> > > > > Airflow 1.10.2 RC3 is available at:
>>         >> > > > >
>> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>>         >> > > > >
>>         >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source
>> release that
>>         >> > comes
>>         >> > > > > with INSTALL instructions.
>>         >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary
>> Python "sdist"
>>         >> > > > release.
>>         >> > > > >
>>         >> > > > > Public keys are available at:
>>         >> > > > >
>> https://dist.apache.org/repos/dist/release/airflow/KEYS
>>         >> > > > >
>>         >> > > > > Only votes from PMC members are binding, but members
>> of the
>>         >> community
>>         >> > > are
>>         >> > > > > encouraged to test the release and vote with
>> "(non-binding)".
>>         >> > > > >
>>         >> > > > > Please note that the version number excludes the `rcX`
>> string, so
>>         >> > it's
>>         >> > > > now
>>         >> > > > > simply 1.10.2. This will allow us to rename the
>> artifact without
>>         >> > > > modifying
>>         >> > > > > the artifact checksums when we actually release.
>>         >> > > > >
>>         >> > > > > Changes since 1.10.2rc2:
>>         >> > > > > *Bugs*:
>>         >> > > > > [AIRFLOW-3732] Fix issue when trying to edit
>> connection in RBAC UI
>>         >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using
>> RBAC UI
>>         >> (#3804)
>>         >> > > > > [AIRFLOW-3259] Fix internal server error when
>> displaying charts
>>         >> > (#4114)
>>         >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC
>> Permissions
>>         >> > modified
>>         >> > > > via
>>         >> > > > > UI (#4118)
>>         >> > > > > [AIRFLOW-3141] Handle duration View for missing dag
>> (#3984)
>>         >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
>>         >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message
>> with
>>         >> unexpected
>>         >> > > > > (#2450)
>>         >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete
>> on timeout
>>         >> > failure
>>         >> > > > > (#4218)
>>         >> > > > > [AIRFLOW-3245] Fix list processing in
>> resolve_template_files
>>         >> (#4086)
>>         >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from
>> scheduler's
>>         >> > heartbeat
>>         >> > > > it
>>         >> > > > > does not crash (#3650)
>>         >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean
>> cli (#3886)
>>         >> > > > >
>>         >> > > > > *Improvements*:
>>         >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
>>         >> > > > > [Airflow-2766] Respect shared datetime across tabs
>>         >> > > > > [AIRFLOW-2776] Compress tree view JSON
>>         >> > > > > [AIRFLOW-2407] Use feature detection for reload()
>> (#3298)
>>         >> > > > > [AIRFLOW-3452] Removed an unused/dangerous
>> display-none (#4295)
>>         >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh
>> (#4197)
>>         >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates
>> (#3966)
>>         >> > > > >
>>         >> > > > >
>>         >> > > > > *New features*:
>>         >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>>         >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream
>> failures (#4182)
>>         >> > > > >
>>         >> > > > > *Doc-only Change*:
>>         >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>>         >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
>>         >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos
>> Operator (#4289)
>>         >> > > > > [AIRFLOW-3382] Fix incorrect docstring in
>> DatastoreHook (#4222)
>>         >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>>         >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error
>> (#4098)
>>         >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring
>> (#4016)
>>         >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>>         >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>>         >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method
>> comment
>>         >> (#3963)
>>         >> > > > > [AIRFLOW-3070] Refine web UI authentication-related
>> docs (#3863)
>>         >> > > > >
>>         >> > > > > Regards,
>>         >> > > > > *Kaxil Naik*
>>         >> > > > >
>>         >> > > >
>>         >> > >
>>         >> >
>>         >>
>>         >
>>
>>
>>
>>
>>     Kaxil Naik
>>
>>     Data Reply
>>     Nova South
>>     160 Victoria Street, Westminster
>>     London SW1E 5LB - UK
>>     phone: +44 (0)20 7730 6000
>>     k.naik@reply.com
>>     www.reply.com
>>
>>
>>
>>
>> Kaxil Naik
>>
>> Data Reply
>> Nova South
>> 160 Victoria Street, Westminster
>> London SW1E 5LB - UK
>> phone: +44 (0)20 7730 6000
>> k.naik@reply.com
>> www.reply.com
>>
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Deng Xiaodong <xd...@gmail.com>.
Hi Kaxil,


After double-checking, I believe the Viewer access/permission issue is not
a bug actually. Seems it's because the DAG-level access control feature is
cherry-picked into 1.10.2rc3.


But my understanding is this feature is still under development? @feng-tao
kindly advise.


On the other hand, if we really plan to include DAG-level access control
feature in 1.10.2, we should make sure the doc is consistent (for example,
PR https://github.com/apache/airflow/pull/4426 should be included).



XD

On Mon, Jan 21, 2019 at 15:23 Naik Kaxil <k....@reply.com> wrote:

> Hi XD,
>
> I could not replicate that in non-rbac UI but could replicate it on RBAC
> one.
>
> Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC
> (Flask-Admin UI)
>
> All the below issues don't seem to be a blocker for this release, however
> I am open to views from all.
>
> (1) Errors not shown on RBAC UI
> (2) Viewer role issue on RBAC UI
> (3) K8s executor one is also just a matter of having short names for
> dag_id & task_id.
>
> Regards,
> Kaxil
>
> On 21/01/2019, 09:19, "Naik Kaxil" <k....@reply.com> wrote:
>
>     Hi XD,
>
>     I will test this and let you know.
>
>     One more bug cropped up
> https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone
> with more K8s experience can have a look at it, please?
>
>     Regards,
>     Kaxil
>
>     On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:
>
>         Hi Kaxil,
>
>         I found another potential bug which is applicable for both RBAC and
>         non-RBAC UI:
>
>         Let’s say we’re trying to import a module which doesn’t exist at
> all, or
>         have any syntax error in the DAG, the DAG will not be parsed. In
> addition,
>         In earlier version, there will be a warning message appearing at
> the header
>         part of the UI, describing what exact error there is.
>
>         But this seems not working in 1.10.2rc3. I have tested with both
> UI.
>
>         Please help confirm if you can reproduce this issue.
>
>         Thanks.
>
>         XD
>
>         On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com>
> wrote:
>
>         > Hi Feng Tao,
>         >
>         > As mentioned in my previous email to XD, as this is not a
> BLOCKER and the
>         > fix exist as mentioned by Seelman, can you change your *vote
> back to +1 *.
>         > And we can fix that in the upcoming release with other fixes
> which should
>         > be quick and aim to release that in a month as well?
>         >
>         > RBAC is still not the default UI in this release, we have got
> all the
>         > features in, and using the fix @seelman mentioned, people can
> already start
>         > using it without any BIG issues.
>         >
>         > Regards,
>         > Kaxil
>         >
>         > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com wrote:
>         >
>         >> Thanks XD and Stefan. I see the issue now. I agree that this
> should be a
>         >> bug which should be fixed.  Please remove my +1 vote for
> release if
>         >> possible.
>         >>
>         >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <
> xd.deng.r@gmail.com>
>         >> wrote:
>         >>
>         >> > Hi Feng Tao,
>         >> >
>         >> > I tried again by deleting the DB and initdb again, the issue
> is still
>         >> > there.
>         >> >
>         >> > Please note the issue is not “see all the roles”. The issue
> is after
>         >> > logging in as a Viewer role, I can’t access the pages
> including Tree
>         >> View,
>         >> > Graph View, Task Duration, Gantt, Code View, etc.
>         >> >
>         >> >
>         >> > XD
>         >> >
>         >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com>
> wrote:
>         >> >
>         >> > > Hi Xiaodong,
>         >> > >
>         >> > > I just tried with a viewer role which can't reproduce your
> issue. I
>         >> could
>         >> > > see all the roles without any issues. Have you reset your
> db with this
>         >> > rc?
>         >> > >
>         >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <
> xd.deng.r@gmail.com>
>         >> > wrote:
>         >> > >
>         >> > > > Hi Kaxil,
>         >> > > >
>         >> > > > A potential bug found in 1.10.2rc3.
>         >> > > >
>         >> > > >
>         >> > > > # Potential Bug:
>         >> > > >
>         >> > > > Viewer Role can't access pages to which it has permissions
>         >> > > >
>         >> > > > # How to Reproduce:
>         >> > > >
>         >> > > > - Under RBAC UI, create a user with "Viewer" role. Then
> use this
>         >> > > > account to log in.
>         >> > > > - You will be able to access the main page. However, you
> will not be
>         >> > > > able to access any page of a specific DAG, including
> Tree, Graph
>         >> View,
>         >> > > > Gantt, Code View, Landing Time, etc. Literally all the
> pages of a
>         >> > > > specific DAG. However, in the Role specs, View role has
> permissions
>         >> to
>         >> > > > all these pages.
>         >> > > >
>         >> > > > - After clicking, users are redirected to the main page
> directly,
>         >> > > > without any explicit warning/error message like "Access
> Denied".
>         >> > > >
>         >> > > > # Remarks:
>         >> > > >
>         >> > > > - I have compared the default permissions which are
> granted to
>         >> Viewer
>         >> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
>         >> > > > - In 1.10.0, Viewer role can access all these pages
> without any
>         >> issue.
>         >> > > > - Seems this issue only exists for Viewer role.
>         >> > > >
>         >> > > >
>         >> > > > Please let me know if you can reproduce this issue.
>         >> > > >
>         >> > > > Please consider this as my -1 (non-binding) as well.
>         >> > > >
>         >> > > > Thanks!
>         >> > > >
>         >> > > >
>         >> > > > XD
>         >> > > >
>         >> > > >
>         >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <
> kaxilnaik@gmail.com>
>         >> wrote:
>         >> > > >
>         >> > > > > Hey all,
>         >> > > > >
>         >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a
> vote on the
>         >> > > > release,
>         >> > > > > which will last for 72 hours. Consider this my
> (binding) +1.
>         >> > > > >
>         >> > > > > Airflow 1.10.2 RC3 is available at:
>         >> > > > >
> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>         >> > > > >
>         >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source
> release that
>         >> > comes
>         >> > > > > with INSTALL instructions.
>         >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary
> Python "sdist"
>         >> > > > release.
>         >> > > > >
>         >> > > > > Public keys are available at:
>         >> > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
>         >> > > > >
>         >> > > > > Only votes from PMC members are binding, but members of
> the
>         >> community
>         >> > > are
>         >> > > > > encouraged to test the release and vote with
> "(non-binding)".
>         >> > > > >
>         >> > > > > Please note that the version number excludes the `rcX`
> string, so
>         >> > it's
>         >> > > > now
>         >> > > > > simply 1.10.2. This will allow us to rename the
> artifact without
>         >> > > > modifying
>         >> > > > > the artifact checksums when we actually release.
>         >> > > > >
>         >> > > > > Changes since 1.10.2rc2:
>         >> > > > > *Bugs*:
>         >> > > > > [AIRFLOW-3732] Fix issue when trying to edit connection
> in RBAC UI
>         >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using
> RBAC UI
>         >> (#3804)
>         >> > > > > [AIRFLOW-3259] Fix internal server error when
> displaying charts
>         >> > (#4114)
>         >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC
> Permissions
>         >> > modified
>         >> > > > via
>         >> > > > > UI (#4118)
>         >> > > > > [AIRFLOW-3141] Handle duration View for missing dag
> (#3984)
>         >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
>         >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message
> with
>         >> unexpected
>         >> > > > > (#2450)
>         >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on
> timeout
>         >> > failure
>         >> > > > > (#4218)
>         >> > > > > [AIRFLOW-3245] Fix list processing in
> resolve_template_files
>         >> (#4086)
>         >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from
> scheduler's
>         >> > heartbeat
>         >> > > > it
>         >> > > > > does not crash (#3650)
>         >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean
> cli (#3886)
>         >> > > > >
>         >> > > > > *Improvements*:
>         >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
>         >> > > > > [Airflow-2766] Respect shared datetime across tabs
>         >> > > > > [AIRFLOW-2776] Compress tree view JSON
>         >> > > > > [AIRFLOW-2407] Use feature detection for reload()
> (#3298)
>         >> > > > > [AIRFLOW-3452] Removed an unused/dangerous display-none
> (#4295)
>         >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh
> (#4197)
>         >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates
> (#3966)
>         >> > > > >
>         >> > > > >
>         >> > > > > *New features*:
>         >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>         >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream
> failures (#4182)
>         >> > > > >
>         >> > > > > *Doc-only Change*:
>         >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>         >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
>         >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos
> Operator (#4289)
>         >> > > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook
> (#4222)
>         >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>         >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
>         >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
>         >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>         >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>         >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method
> comment
>         >> (#3963)
>         >> > > > > [AIRFLOW-3070] Refine web UI authentication-related
> docs (#3863)
>         >> > > > >
>         >> > > > > Regards,
>         >> > > > > *Kaxil Naik*
>         >> > > > >
>         >> > > >
>         >> > >
>         >> >
>         >>
>         >
>
>
>
>
>     Kaxil Naik
>
>     Data Reply
>     Nova South
>     160 Victoria Street, Westminster
>     London SW1E 5LB - UK
>     phone: +44 (0)20 7730 6000
>     k.naik@reply.com
>     www.reply.com
>
>
>
>
> Kaxil Naik
>
> Data Reply
> Nova South
> 160 Victoria Street, Westminster
> London SW1E 5LB - UK
> phone: +44 (0)20 7730 6000
> k.naik@reply.com
> www.reply.com
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Naik Kaxil <k....@reply.com>.
Hi XD,

I could not replicate that in non-rbac UI but could replicate it on RBAC one.

Please check this screenshot https://imgur.com/a/TgiQItO for non-RBAC (Flask-Admin UI)

All the below issues don't seem to be a blocker for this release, however I am open to views from all.

(1) Errors not shown on RBAC UI
(2) Viewer role issue on RBAC UI
(3) K8s executor one is also just a matter of having short names for dag_id & task_id.

Regards,
Kaxil

On 21/01/2019, 09:19, "Naik Kaxil" <k....@reply.com> wrote:

    Hi XD,
    
    I will test this and let you know.
    
    One more bug cropped up https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone with more K8s experience can have a look at it, please?
    
    Regards,
    Kaxil
    
    On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:
    
        Hi Kaxil,
        
        I found another potential bug which is applicable for both RBAC and
        non-RBAC UI:
        
        Let’s say we’re trying to import a module which doesn’t exist at all, or
        have any syntax error in the DAG, the DAG will not be parsed. In addition,
        In earlier version, there will be a warning message appearing at the header
        part of the UI, describing what exact error there is.
        
        But this seems not working in 1.10.2rc3. I have tested with both UI.
        
        Please help confirm if you can reproduce this issue.
        
        Thanks.
        
        XD
        
        On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com> wrote:
        
        > Hi Feng Tao,
        >
        > As mentioned in my previous email to XD, as this is not a BLOCKER and the
        > fix exist as mentioned by Seelman, can you change your *vote back to +1 *.
        > And we can fix that in the upcoming release with other fixes which should
        > be quick and aim to release that in a month as well?
        >
        > RBAC is still not the default UI in this release, we have got all the
        > features in, and using the fix @seelman mentioned, people can already start
        > using it without any BIG issues.
        >
        > Regards,
        > Kaxil
        >
        > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com wrote:
        >
        >> Thanks XD and Stefan. I see the issue now. I agree that this should be a
        >> bug which should be fixed.  Please remove my +1 vote for release if
        >> possible.
        >>
        >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <xd...@gmail.com>
        >> wrote:
        >>
        >> > Hi Feng Tao,
        >> >
        >> > I tried again by deleting the DB and initdb again, the issue is still
        >> > there.
        >> >
        >> > Please note the issue is not “see all the roles”. The issue is after
        >> > logging in as a Viewer role, I can’t access the pages including Tree
        >> View,
        >> > Graph View, Task Duration, Gantt, Code View, etc.
        >> >
        >> >
        >> > XD
        >> >
        >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
        >> >
        >> > > Hi Xiaodong,
        >> > >
        >> > > I just tried with a viewer role which can't reproduce your issue. I
        >> could
        >> > > see all the roles without any issues. Have you reset your db with this
        >> > rc?
        >> > >
        >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
        >> > wrote:
        >> > >
        >> > > > Hi Kaxil,
        >> > > >
        >> > > > A potential bug found in 1.10.2rc3.
        >> > > >
        >> > > >
        >> > > > # Potential Bug:
        >> > > >
        >> > > > Viewer Role can't access pages to which it has permissions
        >> > > >
        >> > > > # How to Reproduce:
        >> > > >
        >> > > > - Under RBAC UI, create a user with "Viewer" role. Then use this
        >> > > > account to log in.
        >> > > > - You will be able to access the main page. However, you will not be
        >> > > > able to access any page of a specific DAG, including Tree, Graph
        >> View,
        >> > > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
        >> > > > specific DAG. However, in the Role specs, View role has permissions
        >> to
        >> > > > all these pages.
        >> > > >
        >> > > > - After clicking, users are redirected to the main page directly,
        >> > > > without any explicit warning/error message like "Access Denied".
        >> > > >
        >> > > > # Remarks:
        >> > > >
        >> > > > - I have compared the default permissions which are granted to
        >> Viewer
        >> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
        >> > > > - In 1.10.0, Viewer role can access all these pages without any
        >> issue.
        >> > > > - Seems this issue only exists for Viewer role.
        >> > > >
        >> > > >
        >> > > > Please let me know if you can reproduce this issue.
        >> > > >
        >> > > > Please consider this as my -1 (non-binding) as well.
        >> > > >
        >> > > > Thanks!
        >> > > >
        >> > > >
        >> > > > XD
        >> > > >
        >> > > >
        >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com>
        >> wrote:
        >> > > >
        >> > > > > Hey all,
        >> > > > >
        >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
        >> > > > release,
        >> > > > > which will last for 72 hours. Consider this my (binding) +1.
        >> > > > >
        >> > > > > Airflow 1.10.2 RC3 is available at:
        >> > > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
        >> > > > >
        >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
        >> > comes
        >> > > > > with INSTALL instructions.
        >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
        >> > > > release.
        >> > > > >
        >> > > > > Public keys are available at:
        >> > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
        >> > > > >
        >> > > > > Only votes from PMC members are binding, but members of the
        >> community
        >> > > are
        >> > > > > encouraged to test the release and vote with "(non-binding)".
        >> > > > >
        >> > > > > Please note that the version number excludes the `rcX` string, so
        >> > it's
        >> > > > now
        >> > > > > simply 1.10.2. This will allow us to rename the artifact without
        >> > > > modifying
        >> > > > > the artifact checksums when we actually release.
        >> > > > >
        >> > > > > Changes since 1.10.2rc2:
        >> > > > > *Bugs*:
        >> > > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
        >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI
        >> (#3804)
        >> > > > > [AIRFLOW-3259] Fix internal server error when displaying charts
        >> > (#4114)
        >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
        >> > modified
        >> > > > via
        >> > > > > UI (#4118)
        >> > > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
        >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
        >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with
        >> unexpected
        >> > > > > (#2450)
        >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
        >> > failure
        >> > > > > (#4218)
        >> > > > > [AIRFLOW-3245] Fix list processing in resolve_template_files
        >> (#4086)
        >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
        >> > heartbeat
        >> > > > it
        >> > > > > does not crash (#3650)
        >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
        >> > > > >
        >> > > > > *Improvements*:
        >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
        >> > > > > [Airflow-2766] Respect shared datetime across tabs
        >> > > > > [AIRFLOW-2776] Compress tree view JSON
        >> > > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
        >> > > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
        >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
        >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
        >> > > > >
        >> > > > >
        >> > > > > *New features*:
        >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
        >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
        >> > > > >
        >> > > > > *Doc-only Change*:
        >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
        >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
        >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
        >> > > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
        >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
        >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
        >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
        >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
        >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
        >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment
        >> (#3963)
        >> > > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
        >> > > > >
        >> > > > > Regards,
        >> > > > > *Kaxil Naik*
        >> > > > >
        >> > > >
        >> > >
        >> >
        >>
        >
        
    
    
    
    Kaxil Naik 
    
    Data Reply
    Nova South
    160 Victoria Street, Westminster
    London SW1E 5LB - UK 
    phone: +44 (0)20 7730 6000
    k.naik@reply.com
    www.reply.com
    



Kaxil Naik 

Data Reply
Nova South
160 Victoria Street, Westminster
London SW1E 5LB - UK 
phone: +44 (0)20 7730 6000
k.naik@reply.com
www.reply.com

Re: [VOTE] Airflow 1.10.2rc3

Posted by Naik Kaxil <k....@reply.com>.
Hi XD,

I will test this and let you know.

One more bug cropped up https://issues.apache.org/jira/browse/AIRFLOW-3737 . @fokko or someone with more K8s experience can have a look at it, please?

Regards,
Kaxil

On 21/01/2019, 09:05, "Deng Xiaodong" <xd...@gmail.com> wrote:

    Hi Kaxil,
    
    I found another potential bug which is applicable for both RBAC and
    non-RBAC UI:
    
    Let’s say we’re trying to import a module which doesn’t exist at all, or
    have any syntax error in the DAG, the DAG will not be parsed. In addition,
    In earlier version, there will be a warning message appearing at the header
    part of the UI, describing what exact error there is.
    
    But this seems not working in 1.10.2rc3. I have tested with both UI.
    
    Please help confirm if you can reproduce this issue.
    
    Thanks.
    
    XD
    
    On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com> wrote:
    
    > Hi Feng Tao,
    >
    > As mentioned in my previous email to XD, as this is not a BLOCKER and the
    > fix exist as mentioned by Seelman, can you change your *vote back to +1 *.
    > And we can fix that in the upcoming release with other fixes which should
    > be quick and aim to release that in a month as well?
    >
    > RBAC is still not the default UI in this release, we have got all the
    > features in, and using the fix @seelman mentioned, people can already start
    > using it without any BIG issues.
    >
    > Regards,
    > Kaxil
    >
    > On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com wrote:
    >
    >> Thanks XD and Stefan. I see the issue now. I agree that this should be a
    >> bug which should be fixed.  Please remove my +1 vote for release if
    >> possible.
    >>
    >> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <xd...@gmail.com>
    >> wrote:
    >>
    >> > Hi Feng Tao,
    >> >
    >> > I tried again by deleting the DB and initdb again, the issue is still
    >> > there.
    >> >
    >> > Please note the issue is not “see all the roles”. The issue is after
    >> > logging in as a Viewer role, I can’t access the pages including Tree
    >> View,
    >> > Graph View, Task Duration, Gantt, Code View, etc.
    >> >
    >> >
    >> > XD
    >> >
    >> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
    >> >
    >> > > Hi Xiaodong,
    >> > >
    >> > > I just tried with a viewer role which can't reproduce your issue. I
    >> could
    >> > > see all the roles without any issues. Have you reset your db with this
    >> > rc?
    >> > >
    >> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
    >> > wrote:
    >> > >
    >> > > > Hi Kaxil,
    >> > > >
    >> > > > A potential bug found in 1.10.2rc3.
    >> > > >
    >> > > >
    >> > > > # Potential Bug:
    >> > > >
    >> > > > Viewer Role can't access pages to which it has permissions
    >> > > >
    >> > > > # How to Reproduce:
    >> > > >
    >> > > > - Under RBAC UI, create a user with "Viewer" role. Then use this
    >> > > > account to log in.
    >> > > > - You will be able to access the main page. However, you will not be
    >> > > > able to access any page of a specific DAG, including Tree, Graph
    >> View,
    >> > > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
    >> > > > specific DAG. However, in the Role specs, View role has permissions
    >> to
    >> > > > all these pages.
    >> > > >
    >> > > > - After clicking, users are redirected to the main page directly,
    >> > > > without any explicit warning/error message like "Access Denied".
    >> > > >
    >> > > > # Remarks:
    >> > > >
    >> > > > - I have compared the default permissions which are granted to
    >> Viewer
    >> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
    >> > > > - In 1.10.0, Viewer role can access all these pages without any
    >> issue.
    >> > > > - Seems this issue only exists for Viewer role.
    >> > > >
    >> > > >
    >> > > > Please let me know if you can reproduce this issue.
    >> > > >
    >> > > > Please consider this as my -1 (non-binding) as well.
    >> > > >
    >> > > > Thanks!
    >> > > >
    >> > > >
    >> > > > XD
    >> > > >
    >> > > >
    >> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com>
    >> wrote:
    >> > > >
    >> > > > > Hey all,
    >> > > > >
    >> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
    >> > > > release,
    >> > > > > which will last for 72 hours. Consider this my (binding) +1.
    >> > > > >
    >> > > > > Airflow 1.10.2 RC3 is available at:
    >> > > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
    >> > > > >
    >> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
    >> > comes
    >> > > > > with INSTALL instructions.
    >> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
    >> > > > release.
    >> > > > >
    >> > > > > Public keys are available at:
    >> > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
    >> > > > >
    >> > > > > Only votes from PMC members are binding, but members of the
    >> community
    >> > > are
    >> > > > > encouraged to test the release and vote with "(non-binding)".
    >> > > > >
    >> > > > > Please note that the version number excludes the `rcX` string, so
    >> > it's
    >> > > > now
    >> > > > > simply 1.10.2. This will allow us to rename the artifact without
    >> > > > modifying
    >> > > > > the artifact checksums when we actually release.
    >> > > > >
    >> > > > > Changes since 1.10.2rc2:
    >> > > > > *Bugs*:
    >> > > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
    >> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI
    >> (#3804)
    >> > > > > [AIRFLOW-3259] Fix internal server error when displaying charts
    >> > (#4114)
    >> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
    >> > modified
    >> > > > via
    >> > > > > UI (#4118)
    >> > > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
    >> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
    >> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with
    >> unexpected
    >> > > > > (#2450)
    >> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
    >> > failure
    >> > > > > (#4218)
    >> > > > > [AIRFLOW-3245] Fix list processing in resolve_template_files
    >> (#4086)
    >> > > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
    >> > heartbeat
    >> > > > it
    >> > > > > does not crash (#3650)
    >> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
    >> > > > >
    >> > > > > *Improvements*:
    >> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
    >> > > > > [Airflow-2766] Respect shared datetime across tabs
    >> > > > > [AIRFLOW-2776] Compress tree view JSON
    >> > > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
    >> > > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
    >> > > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
    >> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
    >> > > > >
    >> > > > >
    >> > > > > *New features*:
    >> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
    >> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
    >> > > > >
    >> > > > > *Doc-only Change*:
    >> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
    >> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
    >> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
    >> > > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
    >> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
    >> > > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
    >> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
    >> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
    >> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
    >> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment
    >> (#3963)
    >> > > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
    >> > > > >
    >> > > > > Regards,
    >> > > > > *Kaxil Naik*
    >> > > > >
    >> > > >
    >> > >
    >> >
    >>
    >
    



Kaxil Naik 

Data Reply
Nova South
160 Victoria Street, Westminster
London SW1E 5LB - UK 
phone: +44 (0)20 7730 6000
k.naik@reply.com
www.reply.com

Re: [VOTE] Airflow 1.10.2rc3

Posted by Deng Xiaodong <xd...@gmail.com>.
Hi Kaxil,

I found another potential bug which is applicable for both RBAC and
non-RBAC UI:

Let’s say we’re trying to import a module which doesn’t exist at all, or
have any syntax error in the DAG, the DAG will not be parsed. In addition,
In earlier version, there will be a warning message appearing at the header
part of the UI, describing what exact error there is.

But this seems not working in 1.10.2rc3. I have tested with both UI.

Please help confirm if you can reproduce this issue.

Thanks.

XD

On Mon, Jan 21, 2019 at 13:29 Kaxil Naik <ka...@gmail.com> wrote:

> Hi Feng Tao,
>
> As mentioned in my previous email to XD, as this is not a BLOCKER and the
> fix exist as mentioned by Seelman, can you change your *vote back to +1 *.
> And we can fix that in the upcoming release with other fixes which should
> be quick and aim to release that in a month as well?
>
> RBAC is still not the default UI in this release, we have got all the
> features in, and using the fix @seelman mentioned, people can already start
> using it without any BIG issues.
>
> Regards,
> Kaxil
>
> On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com wrote:
>
>> Thanks XD and Stefan. I see the issue now. I agree that this should be a
>> bug which should be fixed.  Please remove my +1 vote for release if
>> possible.
>>
>> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <xd...@gmail.com>
>> wrote:
>>
>> > Hi Feng Tao,
>> >
>> > I tried again by deleting the DB and initdb again, the issue is still
>> > there.
>> >
>> > Please note the issue is not “see all the roles”. The issue is after
>> > logging in as a Viewer role, I can’t access the pages including Tree
>> View,
>> > Graph View, Task Duration, Gantt, Code View, etc.
>> >
>> >
>> > XD
>> >
>> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
>> >
>> > > Hi Xiaodong,
>> > >
>> > > I just tried with a viewer role which can't reproduce your issue. I
>> could
>> > > see all the roles without any issues. Have you reset your db with this
>> > rc?
>> > >
>> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
>> > wrote:
>> > >
>> > > > Hi Kaxil,
>> > > >
>> > > > A potential bug found in 1.10.2rc3.
>> > > >
>> > > >
>> > > > # Potential Bug:
>> > > >
>> > > > Viewer Role can't access pages to which it has permissions
>> > > >
>> > > > # How to Reproduce:
>> > > >
>> > > > - Under RBAC UI, create a user with "Viewer" role. Then use this
>> > > > account to log in.
>> > > > - You will be able to access the main page. However, you will not be
>> > > > able to access any page of a specific DAG, including Tree, Graph
>> View,
>> > > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
>> > > > specific DAG. However, in the Role specs, View role has permissions
>> to
>> > > > all these pages.
>> > > >
>> > > > - After clicking, users are redirected to the main page directly,
>> > > > without any explicit warning/error message like "Access Denied".
>> > > >
>> > > > # Remarks:
>> > > >
>> > > > - I have compared the default permissions which are granted to
>> Viewer
>> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
>> > > > - In 1.10.0, Viewer role can access all these pages without any
>> issue.
>> > > > - Seems this issue only exists for Viewer role.
>> > > >
>> > > >
>> > > > Please let me know if you can reproduce this issue.
>> > > >
>> > > > Please consider this as my -1 (non-binding) as well.
>> > > >
>> > > > Thanks!
>> > > >
>> > > >
>> > > > XD
>> > > >
>> > > >
>> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com>
>> wrote:
>> > > >
>> > > > > Hey all,
>> > > > >
>> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
>> > > > release,
>> > > > > which will last for 72 hours. Consider this my (binding) +1.
>> > > > >
>> > > > > Airflow 1.10.2 RC3 is available at:
>> > > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>> > > > >
>> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
>> > comes
>> > > > > with INSTALL instructions.
>> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
>> > > > release.
>> > > > >
>> > > > > Public keys are available at:
>> > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
>> > > > >
>> > > > > Only votes from PMC members are binding, but members of the
>> community
>> > > are
>> > > > > encouraged to test the release and vote with "(non-binding)".
>> > > > >
>> > > > > Please note that the version number excludes the `rcX` string, so
>> > it's
>> > > > now
>> > > > > simply 1.10.2. This will allow us to rename the artifact without
>> > > > modifying
>> > > > > the artifact checksums when we actually release.
>> > > > >
>> > > > > Changes since 1.10.2rc2:
>> > > > > *Bugs*:
>> > > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
>> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI
>> (#3804)
>> > > > > [AIRFLOW-3259] Fix internal server error when displaying charts
>> > (#4114)
>> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
>> > modified
>> > > > via
>> > > > > UI (#4118)
>> > > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
>> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
>> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with
>> unexpected
>> > > > > (#2450)
>> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
>> > failure
>> > > > > (#4218)
>> > > > > [AIRFLOW-3245] Fix list processing in resolve_template_files
>> (#4086)
>> > > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
>> > heartbeat
>> > > > it
>> > > > > does not crash (#3650)
>> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>> > > > >
>> > > > > *Improvements*:
>> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
>> > > > > [Airflow-2766] Respect shared datetime across tabs
>> > > > > [AIRFLOW-2776] Compress tree view JSON
>> > > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
>> > > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
>> > > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
>> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>> > > > >
>> > > > >
>> > > > > *New features*:
>> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>> > > > >
>> > > > > *Doc-only Change*:
>> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
>> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
>> > > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
>> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>> > > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
>> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
>> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment
>> (#3963)
>> > > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>> > > > >
>> > > > > Regards,
>> > > > > *Kaxil Naik*
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Kaxil Naik <ka...@gmail.com>.
Hi Feng Tao,

As mentioned in my previous email to XD, as this is not a BLOCKER and the
fix exist as mentioned by Seelman, can you change your *vote back to +1 *.
And we can fix that in the upcoming release with other fixes which should
be quick and aim to release that in a month as well?

RBAC is still not the default UI in this release, we have got all the
features in, and using the fix @seelman mentioned, people can already start
using it without any BIG issues.

Regards,
Kaxil

On Mon, Jan 21, 2019, 07:55 Tao Feng <fengtao04@gmail.com wrote:

> Thanks XD and Stefan. I see the issue now. I agree that this should be a
> bug which should be fixed.  Please remove my +1 vote for release if
> possible.
>
> On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <xd...@gmail.com>
> wrote:
>
> > Hi Feng Tao,
> >
> > I tried again by deleting the DB and initdb again, the issue is still
> > there.
> >
> > Please note the issue is not “see all the roles”. The issue is after
> > logging in as a Viewer role, I can’t access the pages including Tree
> View,
> > Graph View, Task Duration, Gantt, Code View, etc.
> >
> >
> > XD
> >
> > On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
> >
> > > Hi Xiaodong,
> > >
> > > I just tried with a viewer role which can't reproduce your issue. I
> could
> > > see all the roles without any issues. Have you reset your db with this
> > rc?
> > >
> > > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
> > wrote:
> > >
> > > > Hi Kaxil,
> > > >
> > > > A potential bug found in 1.10.2rc3.
> > > >
> > > >
> > > > # Potential Bug:
> > > >
> > > > Viewer Role can't access pages to which it has permissions
> > > >
> > > > # How to Reproduce:
> > > >
> > > > - Under RBAC UI, create a user with "Viewer" role. Then use this
> > > > account to log in.
> > > > - You will be able to access the main page. However, you will not be
> > > > able to access any page of a specific DAG, including Tree, Graph
> View,
> > > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
> > > > specific DAG. However, in the Role specs, View role has permissions
> to
> > > > all these pages.
> > > >
> > > > - After clicking, users are redirected to the main page directly,
> > > > without any explicit warning/error message like "Access Denied".
> > > >
> > > > # Remarks:
> > > >
> > > > - I have compared the default permissions which are granted to Viewer
> > > > role between 1.10.0 and 1.10.2rc3. They are all the same.
> > > > - In 1.10.0, Viewer role can access all these pages without any
> issue.
> > > > - Seems this issue only exists for Viewer role.
> > > >
> > > >
> > > > Please let me know if you can reproduce this issue.
> > > >
> > > > Please consider this as my -1 (non-binding) as well.
> > > >
> > > > Thanks!
> > > >
> > > >
> > > > XD
> > > >
> > > >
> > > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com>
> wrote:
> > > >
> > > > > Hey all,
> > > > >
> > > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> > > > release,
> > > > > which will last for 72 hours. Consider this my (binding) +1.
> > > > >
> > > > > Airflow 1.10.2 RC3 is available at:
> > > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> > > > >
> > > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
> > comes
> > > > > with INSTALL instructions.
> > > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> > > > release.
> > > > >
> > > > > Public keys are available at:
> > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
> > > > >
> > > > > Only votes from PMC members are binding, but members of the
> community
> > > are
> > > > > encouraged to test the release and vote with "(non-binding)".
> > > > >
> > > > > Please note that the version number excludes the `rcX` string, so
> > it's
> > > > now
> > > > > simply 1.10.2. This will allow us to rename the artifact without
> > > > modifying
> > > > > the artifact checksums when we actually release.
> > > > >
> > > > > Changes since 1.10.2rc2:
> > > > > *Bugs*:
> > > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> > > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI
> (#3804)
> > > > > [AIRFLOW-3259] Fix internal server error when displaying charts
> > (#4114)
> > > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
> > modified
> > > > via
> > > > > UI (#4118)
> > > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> > > > > [AIRFLOW-2766] Respect shared datetime across tabs
> > > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with
> unexpected
> > > > > (#2450)
> > > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
> > failure
> > > > > (#4218)
> > > > > [AIRFLOW-3245] Fix list processing in resolve_template_files
> (#4086)
> > > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
> > heartbeat
> > > > it
> > > > > does not crash (#3650)
> > > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> > > > >
> > > > > *Improvements*:
> > > > > [AIRFLOW-3302] Small CSS fixes (#4140)
> > > > > [Airflow-2766] Respect shared datetime across tabs
> > > > > [AIRFLOW-2776] Compress tree view JSON
> > > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
> > > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> > > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> > > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> > > > >
> > > > >
> > > > > *New features*:
> > > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
> > > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> > > > >
> > > > > *Doc-only Change*:
> > > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> > > > > [AIRFLOW-3018] Fix Minor issues in Documentation
> > > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> > > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> > > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> > > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> > > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> > > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> > > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
> > > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment
> (#3963)
> > > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> > > > >
> > > > > Regards,
> > > > > *Kaxil Naik*
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Tao Feng <fe...@gmail.com>.
Thanks XD and Stefan. I see the issue now. I agree that this should be a
bug which should be fixed.  Please remove my +1 vote for release if
possible.

On Sun, Jan 20, 2019 at 11:12 PM Deng Xiaodong <xd...@gmail.com> wrote:

> Hi Feng Tao,
>
> I tried again by deleting the DB and initdb again, the issue is still
> there.
>
> Please note the issue is not “see all the roles”. The issue is after
> logging in as a Viewer role, I can’t access the pages including Tree View,
> Graph View, Task Duration, Gantt, Code View, etc.
>
>
> XD
>
> On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:
>
> > Hi Xiaodong,
> >
> > I just tried with a viewer role which can't reproduce your issue. I could
> > see all the roles without any issues. Have you reset your db with this
> rc?
> >
> > On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com>
> wrote:
> >
> > > Hi Kaxil,
> > >
> > > A potential bug found in 1.10.2rc3.
> > >
> > >
> > > # Potential Bug:
> > >
> > > Viewer Role can't access pages to which it has permissions
> > >
> > > # How to Reproduce:
> > >
> > > - Under RBAC UI, create a user with "Viewer" role. Then use this
> > > account to log in.
> > > - You will be able to access the main page. However, you will not be
> > > able to access any page of a specific DAG, including Tree, Graph View,
> > > Gantt, Code View, Landing Time, etc. Literally all the pages of a
> > > specific DAG. However, in the Role specs, View role has permissions to
> > > all these pages.
> > >
> > > - After clicking, users are redirected to the main page directly,
> > > without any explicit warning/error message like "Access Denied".
> > >
> > > # Remarks:
> > >
> > > - I have compared the default permissions which are granted to Viewer
> > > role between 1.10.0 and 1.10.2rc3. They are all the same.
> > > - In 1.10.0, Viewer role can access all these pages without any issue.
> > > - Seems this issue only exists for Viewer role.
> > >
> > >
> > > Please let me know if you can reproduce this issue.
> > >
> > > Please consider this as my -1 (non-binding) as well.
> > >
> > > Thanks!
> > >
> > >
> > > XD
> > >
> > >
> > > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com> wrote:
> > >
> > > > Hey all,
> > > >
> > > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> > > release,
> > > > which will last for 72 hours. Consider this my (binding) +1.
> > > >
> > > > Airflow 1.10.2 RC3 is available at:
> > > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> > > >
> > > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that
> comes
> > > > with INSTALL instructions.
> > > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> > > release.
> > > >
> > > > Public keys are available at:
> > > > https://dist.apache.org/repos/dist/release/airflow/KEYS
> > > >
> > > > Only votes from PMC members are binding, but members of the community
> > are
> > > > encouraged to test the release and vote with "(non-binding)".
> > > >
> > > > Please note that the version number excludes the `rcX` string, so
> it's
> > > now
> > > > simply 1.10.2. This will allow us to rename the artifact without
> > > modifying
> > > > the artifact checksums when we actually release.
> > > >
> > > > Changes since 1.10.2rc2:
> > > > *Bugs*:
> > > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> > > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> > > > [AIRFLOW-3259] Fix internal server error when displaying charts
> (#4114)
> > > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions
> modified
> > > via
> > > > UI (#4118)
> > > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> > > > [AIRFLOW-2766] Respect shared datetime across tabs
> > > > [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> > > > (#2450)
> > > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout
> failure
> > > > (#4218)
> > > > [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> > > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
> heartbeat
> > > it
> > > > does not crash (#3650)
> > > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> > > >
> > > > *Improvements*:
> > > > [AIRFLOW-3302] Small CSS fixes (#4140)
> > > > [Airflow-2766] Respect shared datetime across tabs
> > > > [AIRFLOW-2776] Compress tree view JSON
> > > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
> > > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> > > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> > > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> > > >
> > > >
> > > > *New features*:
> > > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
> > > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> > > >
> > > > *Doc-only Change*:
> > > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> > > > [AIRFLOW-3018] Fix Minor issues in Documentation
> > > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> > > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> > > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> > > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> > > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> > > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> > > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
> > > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> > > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> > > >
> > > > Regards,
> > > > *Kaxil Naik*
> > > >
> > >
> >
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Deng Xiaodong <xd...@gmail.com>.
Hi Feng Tao,

I tried again by deleting the DB and initdb again, the issue is still there.

Please note the issue is not “see all the roles”. The issue is after
logging in as a Viewer role, I can’t access the pages including Tree View,
Graph View, Task Duration, Gantt, Code View, etc.


XD

On Mon, Jan 21, 2019 at 12:03 Tao Feng <fe...@gmail.com> wrote:

> Hi Xiaodong,
>
> I just tried with a viewer role which can't reproduce your issue. I could
> see all the roles without any issues. Have you reset your db with this rc?
>
> On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com> wrote:
>
> > Hi Kaxil,
> >
> > A potential bug found in 1.10.2rc3.
> >
> >
> > # Potential Bug:
> >
> > Viewer Role can't access pages to which it has permissions
> >
> > # How to Reproduce:
> >
> > - Under RBAC UI, create a user with "Viewer" role. Then use this
> > account to log in.
> > - You will be able to access the main page. However, you will not be
> > able to access any page of a specific DAG, including Tree, Graph View,
> > Gantt, Code View, Landing Time, etc. Literally all the pages of a
> > specific DAG. However, in the Role specs, View role has permissions to
> > all these pages.
> >
> > - After clicking, users are redirected to the main page directly,
> > without any explicit warning/error message like "Access Denied".
> >
> > # Remarks:
> >
> > - I have compared the default permissions which are granted to Viewer
> > role between 1.10.0 and 1.10.2rc3. They are all the same.
> > - In 1.10.0, Viewer role can access all these pages without any issue.
> > - Seems this issue only exists for Viewer role.
> >
> >
> > Please let me know if you can reproduce this issue.
> >
> > Please consider this as my -1 (non-binding) as well.
> >
> > Thanks!
> >
> >
> > XD
> >
> >
> > On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com> wrote:
> >
> > > Hey all,
> > >
> > > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> > release,
> > > which will last for 72 hours. Consider this my (binding) +1.
> > >
> > > Airflow 1.10.2 RC3 is available at:
> > > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> > >
> > > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> > > with INSTALL instructions.
> > > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> > release.
> > >
> > > Public keys are available at:
> > > https://dist.apache.org/repos/dist/release/airflow/KEYS
> > >
> > > Only votes from PMC members are binding, but members of the community
> are
> > > encouraged to test the release and vote with "(non-binding)".
> > >
> > > Please note that the version number excludes the `rcX` string, so it's
> > now
> > > simply 1.10.2. This will allow us to rename the artifact without
> > modifying
> > > the artifact checksums when we actually release.
> > >
> > > Changes since 1.10.2rc2:
> > > *Bugs*:
> > > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> > > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> > > [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> > > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified
> > via
> > > UI (#4118)
> > > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> > > [AIRFLOW-2766] Respect shared datetime across tabs
> > > [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> > > (#2450)
> > > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> > > (#4218)
> > > [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> > > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat
> > it
> > > does not crash (#3650)
> > > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> > >
> > > *Improvements*:
> > > [AIRFLOW-3302] Small CSS fixes (#4140)
> > > [Airflow-2766] Respect shared datetime across tabs
> > > [AIRFLOW-2776] Compress tree view JSON
> > > [AIRFLOW-2407] Use feature detection for reload() (#3298)
> > > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> > > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> > > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> > >
> > >
> > > *New features*:
> > > [AIRFLOW-2874] Enables FAB's theme support (#3719)
> > > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> > >
> > > *Doc-only Change*:
> > > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> > > [AIRFLOW-3018] Fix Minor issues in Documentation
> > > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> > > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> > > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> > > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> > > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> > > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> > > [AIRFLOW-XXX] Fix undocumented params in S3_hook
> > > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> > > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> > >
> > > Regards,
> > > *Kaxil Naik*
> > >
> >
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Tao Feng <fe...@gmail.com>.
Hi Xiaodong,

I just tried with a viewer role which can't reproduce your issue. I could
see all the roles without any issues. Have you reset your db with this rc?

On Sun, Jan 20, 2019 at 9:50 PM Deng Xiaodong <xd...@gmail.com> wrote:

> Hi Kaxil,
>
> A potential bug found in 1.10.2rc3.
>
>
> # Potential Bug:
>
> Viewer Role can't access pages to which it has permissions
>
> # How to Reproduce:
>
> - Under RBAC UI, create a user with "Viewer" role. Then use this
> account to log in.
> - You will be able to access the main page. However, you will not be
> able to access any page of a specific DAG, including Tree, Graph View,
> Gantt, Code View, Landing Time, etc. Literally all the pages of a
> specific DAG. However, in the Role specs, View role has permissions to
> all these pages.
>
> - After clicking, users are redirected to the main page directly,
> without any explicit warning/error message like "Access Denied".
>
> # Remarks:
>
> - I have compared the default permissions which are granted to Viewer
> role between 1.10.0 and 1.10.2rc3. They are all the same.
> - In 1.10.0, Viewer role can access all these pages without any issue.
> - Seems this issue only exists for Viewer role.
>
>
> Please let me know if you can reproduce this issue.
>
> Please consider this as my -1 (non-binding) as well.
>
> Thanks!
>
>
> XD
>
>
> On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com> wrote:
>
> > Hey all,
> >
> > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> release,
> > which will last for 72 hours. Consider this my (binding) +1.
> >
> > Airflow 1.10.2 RC3 is available at:
> > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> >
> > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> > with INSTALL instructions.
> > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> release.
> >
> > Public keys are available at:
> > https://dist.apache.org/repos/dist/release/airflow/KEYS
> >
> > Only votes from PMC members are binding, but members of the community are
> > encouraged to test the release and vote with "(non-binding)".
> >
> > Please note that the version number excludes the `rcX` string, so it's
> now
> > simply 1.10.2. This will allow us to rename the artifact without
> modifying
> > the artifact checksums when we actually release.
> >
> > Changes since 1.10.2rc2:
> > *Bugs*:
> > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> > [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified
> via
> > UI (#4118)
> > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> > [AIRFLOW-2766] Respect shared datetime across tabs
> > [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> > (#2450)
> > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> > (#4218)
> > [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat
> it
> > does not crash (#3650)
> > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> >
> > *Improvements*:
> > [AIRFLOW-3302] Small CSS fixes (#4140)
> > [Airflow-2766] Respect shared datetime across tabs
> > [AIRFLOW-2776] Compress tree view JSON
> > [AIRFLOW-2407] Use feature detection for reload() (#3298)
> > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> >
> >
> > *New features*:
> > [AIRFLOW-2874] Enables FAB's theme support (#3719)
> > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> >
> > *Doc-only Change*:
> > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> > [AIRFLOW-3018] Fix Minor issues in Documentation
> > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> > [AIRFLOW-XXX] Fix undocumented params in S3_hook
> > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> >
> > Regards,
> > *Kaxil Naik*
> >
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Deng Xiaodong <xd...@gmail.com>.
Hi Kaxil,

A potential bug found in 1.10.2rc3.


# Potential Bug:

Viewer Role can't access pages to which it has permissions

# How to Reproduce:

- Under RBAC UI, create a user with "Viewer" role. Then use this
account to log in.
- You will be able to access the main page. However, you will not be
able to access any page of a specific DAG, including Tree, Graph View,
Gantt, Code View, Landing Time, etc. Literally all the pages of a
specific DAG. However, in the Role specs, View role has permissions to
all these pages.

- After clicking, users are redirected to the main page directly,
without any explicit warning/error message like "Access Denied".

# Remarks:

- I have compared the default permissions which are granted to Viewer
role between 1.10.0 and 1.10.2rc3. They are all the same.
- In 1.10.0, Viewer role can access all these pages without any issue.
- Seems this issue only exists for Viewer role.


Please let me know if you can reproduce this issue.

Please consider this as my -1 (non-binding) as well.

Thanks!


XD


On Sat, Jan 19, 2019 at 22:06 Kaxil Naik <ka...@gmail.com> wrote:

> Hey all,
>
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (binding) +1.
>
> Airflow 1.10.2 RC3 is available at:
> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>
> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> with INSTALL instructions.
> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
>
> Public keys are available at:
> https://dist.apache.org/repos/dist/release/airflow/KEYS
>
> Only votes from PMC members are binding, but members of the community are
> encouraged to test the release and vote with "(non-binding)".
>
> Please note that the version number excludes the `rcX` string, so it's now
> simply 1.10.2. This will allow us to rename the artifact without modifying
> the artifact checksums when we actually release.
>
> Changes since 1.10.2rc2:
> *Bugs*:
> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
> UI (#4118)
> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> [AIRFLOW-2766] Respect shared datetime across tabs
> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> (#2450)
> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> (#4218)
> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
> does not crash (#3650)
> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>
> *Improvements*:
> [AIRFLOW-3302] Small CSS fixes (#4140)
> [Airflow-2766] Respect shared datetime across tabs
> [AIRFLOW-2776] Compress tree view JSON
> [AIRFLOW-2407] Use feature detection for reload() (#3298)
> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>
>
> *New features*:
> [AIRFLOW-2874] Enables FAB's theme support (#3719)
> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>
> *Doc-only Change*:
> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> [AIRFLOW-3018] Fix Minor issues in Documentation
> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> [AIRFLOW-XXX] Fix undocumented params in S3_hook
> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>
> Regards,
> *Kaxil Naik*
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Tao Feng <fe...@gmail.com>.
+1 given it is a time based release.


On Tue, Jan 22, 2019 at 7:00 AM Ash Berlin-Taylor <as...@apache.org> wrote:

> +1 (binding)
>
> - Checksums match
> - Signing good
> - version.py doesn't contain "rc"
> - UPDATING.md looks good
> - Tested celery executor on redis.
> - Pausing/unpausing dags on RBAC UI
> - Import errors from dags showing up in RBAC UI.
>
> I did notice something in the task instance logs that I want to look at,
> but not a blocker for release:
>
> > [2019-01-22 14:23:31,532] {{logging_mixin.py:95}} INFO - [2019-01-22
> 14:23:31,531] {{jobs.py:2592}} WARNING - State of this instance has been
> externally set to success. Taking the poison pill.
>
> I see something like that on some of tasks when things are a bit
> contended. It doesn't cause any problems (things are only run once etc.)
> but I'd like to get to the bottom of it and fix it.
>
> I agree on time-based releases, and have already targeted a few Jira
> tickets against 1.10.3 in preparation.
>
> I'm happy to run the release for that one aiming for a release at the end
> of Feb 2019.
>
>
> -ash
>
> > On 22 Jan 2019, at 08:56, Bolke de Bruin <bd...@gmail.com> wrote:
> >
> > Can I suggest that we get in the habit of time based releases, now that
> we don’t have to vote twice? In this context I suggest that not having
> documentation is not blocking for release, but that we should do a quick .3
> release
> >
> > Tao can you change your vote to +1?
> >
> > Verstuurd vanaf mijn iPad
> >
> >> Op 22 jan. 2019 om 00:10 heeft Felix Uellendall <
> felix.uellendall@gmx.de> het volgende geschreven:
> >>
> >> +1 (non-binding)
> >>
> >> I could not found any more blocker issues. I ran all example dags and
> some of our own dags via RBAC UI.
> >>
> >> - feluelle
> >>
> >>> Am 19/01/2019 um 17:35 schrieb Kaxil Naik:
> >>> Hey all,
> >>>
> >>> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> release,
> >>> which will last for 72 hours. Consider this my (binding) +1.
> >>>
> >>> Airflow 1.10.2 RC3 is available at:
> >>> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> >>>
> >>> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> >>> with INSTALL instructions.
> >>> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> release.
> >>>
> >>> Public keys are available at:
> >>> https://dist.apache.org/repos/dist/release/airflow/KEYS
> >>>
> >>> Only votes from PMC members are binding, but members of the community
> are
> >>> encouraged to test the release and vote with "(non-binding)".
> >>>
> >>> Please note that the version number excludes the `rcX` string, so it's
> now
> >>> simply 1.10.2. This will allow us to rename the artifact without
> modifying
> >>> the artifact checksums when we actually release.
> >>>
> >>> Changes since 1.10.2rc2:
> >>> *Bugs*:
> >>> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> >>> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> >>> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> >>> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified
> via
> >>> UI (#4118)
> >>> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> >>> [AIRFLOW-2766] Respect shared datetime across tabs
> >>> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> >>> (#2450)
> >>> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> >>> (#4218)
> >>> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> >>> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's
> heartbeat it
> >>> does not crash (#3650)
> >>> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> >>>
> >>> *Improvements*:
> >>> [AIRFLOW-3302] Small CSS fixes (#4140)
> >>> [Airflow-2766] Respect shared datetime across tabs
> >>> [AIRFLOW-2776] Compress tree view JSON
> >>> [AIRFLOW-2407] Use feature detection for reload() (#3298)
> >>> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> >>> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> >>> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> >>>
> >>>
> >>> *New features*:
> >>> [AIRFLOW-2874] Enables FAB's theme support (#3719)
> >>> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> >>>
> >>> *Doc-only Change*:
> >>> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> >>> [AIRFLOW-3018] Fix Minor issues in Documentation
> >>> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> >>> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> >>> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> >>> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> >>> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> >>> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> >>> [AIRFLOW-XXX] Fix undocumented params in S3_hook
> >>> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> >>> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> >>>
> >>> Regards,
> >>> *Kaxil Naik*
> >>>
>
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Ash Berlin-Taylor <as...@apache.org>.
+1 (binding)

- Checksums match
- Signing good
- version.py doesn't contain "rc"
- UPDATING.md looks good
- Tested celery executor on redis.
- Pausing/unpausing dags on RBAC UI
- Import errors from dags showing up in RBAC UI.

I did notice something in the task instance logs that I want to look at, but not a blocker for release:

> [2019-01-22 14:23:31,532] {{logging_mixin.py:95}} INFO - [2019-01-22 14:23:31,531] {{jobs.py:2592}} WARNING - State of this instance has been externally set to success. Taking the poison pill.

I see something like that on some of tasks when things are a bit contended. It doesn't cause any problems (things are only run once etc.) but I'd like to get to the bottom of it and fix it.

I agree on time-based releases, and have already targeted a few Jira tickets against 1.10.3 in preparation.

I'm happy to run the release for that one aiming for a release at the end of Feb 2019.


-ash

> On 22 Jan 2019, at 08:56, Bolke de Bruin <bd...@gmail.com> wrote:
> 
> Can I suggest that we get in the habit of time based releases, now that we don’t have to vote twice? In this context I suggest that not having documentation is not blocking for release, but that we should do a quick .3 release
> 
> Tao can you change your vote to +1?
> 
> Verstuurd vanaf mijn iPad
> 
>> Op 22 jan. 2019 om 00:10 heeft Felix Uellendall <fe...@gmx.de> het volgende geschreven:
>> 
>> +1 (non-binding)
>> 
>> I could not found any more blocker issues. I ran all example dags and some of our own dags via RBAC UI.
>> 
>> - feluelle
>> 
>>> Am 19/01/2019 um 17:35 schrieb Kaxil Naik:
>>> Hey all,
>>> 
>>> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
>>> which will last for 72 hours. Consider this my (binding) +1.
>>> 
>>> Airflow 1.10.2 RC3 is available at:
>>> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>>> 
>>> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
>>> with INSTALL instructions.
>>> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
>>> 
>>> Public keys are available at:
>>> https://dist.apache.org/repos/dist/release/airflow/KEYS
>>> 
>>> Only votes from PMC members are binding, but members of the community are
>>> encouraged to test the release and vote with "(non-binding)".
>>> 
>>> Please note that the version number excludes the `rcX` string, so it's now
>>> simply 1.10.2. This will allow us to rename the artifact without modifying
>>> the artifact checksums when we actually release.
>>> 
>>> Changes since 1.10.2rc2:
>>> *Bugs*:
>>> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
>>> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
>>> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
>>> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
>>> UI (#4118)
>>> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
>>> [AIRFLOW-2766] Respect shared datetime across tabs
>>> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
>>> (#2450)
>>> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
>>> (#4218)
>>> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
>>> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
>>> does not crash (#3650)
>>> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>>> 
>>> *Improvements*:
>>> [AIRFLOW-3302] Small CSS fixes (#4140)
>>> [Airflow-2766] Respect shared datetime across tabs
>>> [AIRFLOW-2776] Compress tree view JSON
>>> [AIRFLOW-2407] Use feature detection for reload() (#3298)
>>> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
>>> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
>>> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>>> 
>>> 
>>> *New features*:
>>> [AIRFLOW-2874] Enables FAB's theme support (#3719)
>>> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>>> 
>>> *Doc-only Change*:
>>> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>>> [AIRFLOW-3018] Fix Minor issues in Documentation
>>> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
>>> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
>>> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>>> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
>>> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
>>> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>>> [AIRFLOW-XXX] Fix undocumented params in S3_hook
>>> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
>>> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>>> 
>>> Regards,
>>> *Kaxil Naik*
>>>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Bolke de Bruin <bd...@gmail.com>.
Can I suggest that we get in the habit of time based releases, now that we don’t have to vote twice? In this context I suggest that not having documentation is not blocking for release, but that we should do a quick .3 release

Tao can you change your vote to +1?

Verstuurd vanaf mijn iPad

> Op 22 jan. 2019 om 00:10 heeft Felix Uellendall <fe...@gmx.de> het volgende geschreven:
> 
> +1 (non-binding)
> 
> I could not found any more blocker issues. I ran all example dags and some of our own dags via RBAC UI.
> 
> - feluelle
> 
>> Am 19/01/2019 um 17:35 schrieb Kaxil Naik:
>> Hey all,
>> 
>> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
>> which will last for 72 hours. Consider this my (binding) +1.
>> 
>> Airflow 1.10.2 RC3 is available at:
>> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>> 
>> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
>> with INSTALL instructions.
>> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
>> 
>> Public keys are available at:
>> https://dist.apache.org/repos/dist/release/airflow/KEYS
>> 
>> Only votes from PMC members are binding, but members of the community are
>> encouraged to test the release and vote with "(non-binding)".
>> 
>> Please note that the version number excludes the `rcX` string, so it's now
>> simply 1.10.2. This will allow us to rename the artifact without modifying
>> the artifact checksums when we actually release.
>> 
>> Changes since 1.10.2rc2:
>> *Bugs*:
>> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
>> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
>> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
>> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
>> UI (#4118)
>> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
>> [AIRFLOW-2766] Respect shared datetime across tabs
>> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
>> (#2450)
>> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
>> (#4218)
>> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
>> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
>> does not crash (#3650)
>> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>> 
>> *Improvements*:
>> [AIRFLOW-3302] Small CSS fixes (#4140)
>> [Airflow-2766] Respect shared datetime across tabs
>> [AIRFLOW-2776] Compress tree view JSON
>> [AIRFLOW-2407] Use feature detection for reload() (#3298)
>> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
>> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
>> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>> 
>> 
>> *New features*:
>> [AIRFLOW-2874] Enables FAB's theme support (#3719)
>> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>> 
>> *Doc-only Change*:
>> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>> [AIRFLOW-3018] Fix Minor issues in Documentation
>> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
>> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
>> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
>> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
>> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>> [AIRFLOW-XXX] Fix undocumented params in S3_hook
>> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
>> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>> 
>> Regards,
>> *Kaxil Naik*
>>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Felix Uellendall <fe...@gmx.de>.
+1 (non-binding)

I could not found any more blocker issues. I ran all example dags and 
some of our own dags via RBAC UI.

- feluelle

Am 19/01/2019 um 17:35 schrieb Kaxil Naik:
> Hey all,
>
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (binding) +1.
>
> Airflow 1.10.2 RC3 is available at:
> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>
> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> with INSTALL instructions.
> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
>
> Public keys are available at:
> https://dist.apache.org/repos/dist/release/airflow/KEYS
>
> Only votes from PMC members are binding, but members of the community are
> encouraged to test the release and vote with "(non-binding)".
>
> Please note that the version number excludes the `rcX` string, so it's now
> simply 1.10.2. This will allow us to rename the artifact without modifying
> the artifact checksums when we actually release.
>
> Changes since 1.10.2rc2:
> *Bugs*:
> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
> UI (#4118)
> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> [AIRFLOW-2766] Respect shared datetime across tabs
> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> (#2450)
> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> (#4218)
> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
> does not crash (#3650)
> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>
> *Improvements*:
> [AIRFLOW-3302] Small CSS fixes (#4140)
> [Airflow-2766] Respect shared datetime across tabs
> [AIRFLOW-2776] Compress tree view JSON
> [AIRFLOW-2407] Use feature detection for reload() (#3298)
> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>
>
> *New features*:
> [AIRFLOW-2874] Enables FAB's theme support (#3719)
> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>
> *Doc-only Change*:
> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> [AIRFLOW-3018] Fix Minor issues in Documentation
> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> [AIRFLOW-XXX] Fix undocumented params in S3_hook
> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>
> Regards,
> *Kaxil Naik*
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Tao Feng <fe...@gmail.com>.
+1 (binding)

I install the rc3 locally and create a new role and could view it in UI
without issues.

On Sat, Jan 19, 2019 at 8:36 AM Kaxil Naik <ka...@gmail.com> wrote:

> Hey all,
>
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (binding) +1.
>
> Airflow 1.10.2 RC3 is available at:
> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>
> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> with INSTALL instructions.
> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
>
> Public keys are available at:
> https://dist.apache.org/repos/dist/release/airflow/KEYS
>
> Only votes from PMC members are binding, but members of the community are
> encouraged to test the release and vote with "(non-binding)".
>
> Please note that the version number excludes the `rcX` string, so it's now
> simply 1.10.2. This will allow us to rename the artifact without modifying
> the artifact checksums when we actually release.
>
> Changes since 1.10.2rc2:
> *Bugs*:
> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
> UI (#4118)
> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> [AIRFLOW-2766] Respect shared datetime across tabs
> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> (#2450)
> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> (#4218)
> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
> does not crash (#3650)
> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>
> *Improvements*:
> [AIRFLOW-3302] Small CSS fixes (#4140)
> [Airflow-2766] Respect shared datetime across tabs
> [AIRFLOW-2776] Compress tree view JSON
> [AIRFLOW-2407] Use feature detection for reload() (#3298)
> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>
>
> *New features*:
> [AIRFLOW-2874] Enables FAB's theme support (#3719)
> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>
> *Doc-only Change*:
> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> [AIRFLOW-3018] Fix Minor issues in Documentation
> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> [AIRFLOW-XXX] Fix undocumented params in S3_hook
> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>
> Regards,
> *Kaxil Naik*
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Kaxil Naik <ka...@gmail.com>.
@seelman, sorry my bad - I didn't read that you build it from source. :-)
Yes, you would need to build it using nom if you build it from source.

Regards,
Kaxil

On Sun, Jan 20, 2019, 22:22 Kaxil Naik <kaxilnaik@gmail.com wrote:

> You won't need to build assets. When we release (create tar file), the
> assets are compiled using node and are already included. Hence, you would
> just need to do `pip install apache-airflow==1.10.2rc3`
>
> Regards,
> Kaxil
>
> On Sun, Jan 20, 2019, 21:53 Stefan Seelmann <mail@stefan-seelmann.de
> wrote:
>
>> +1 (non-binding)
>>
>> Deployed in our test env and run the test suite.
>>
>> The update from 1.10.0 to 1.10.2rc3 was a bit bumpy:
>> * DAG level access was only added in 1.10.2, not already in 1.10 as
>> described in `UPDATING.md`. We use functions from `www_rbac/security.py`
>> to create custom roles, but the file changed so this needed adaption.
>> * We install Airflow from source (to be able to cherry-pick from master
>> or apply patches). In 1.10.0 it was sufficient to do this with `pip
>> install`. Since 1.10.1 it's also requried to build the `www_rbac` assets
>> which requires node+npm. I'll submit a PR to update the `INSTALL` file.
>>
>> Kind Regards,
>> Stefan
>>
>> On 1/19/19 5:35 PM, Kaxil Naik wrote:
>> > Hey all,
>> >
>> > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
>> release,
>> > which will last for 72 hours. Consider this my (binding) +1.
>> >
>> > Airflow 1.10.2 RC3 is available at:
>> > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
>> >
>> > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
>> > with INSTALL instructions.
>> > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
>> release.
>> >
>> > Public keys are available at:
>> > https://dist.apache.org/repos/dist/release/airflow/KEYS
>> >
>> > Only votes from PMC members are binding, but members of the community
>> are
>> > encouraged to test the release and vote with "(non-binding)".
>> >
>> > Please note that the version number excludes the `rcX` string, so it's
>> now
>> > simply 1.10.2. This will allow us to rename the artifact without
>> modifying
>> > the artifact checksums when we actually release.
>> >
>> > Changes since 1.10.2rc2:
>> > *Bugs*:
>> > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
>> > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
>> > [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
>> > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified
>> via
>> > UI (#4118)
>> > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
>> > [AIRFLOW-2766] Respect shared datetime across tabs
>> > [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
>> > (#2450)
>> > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
>> > (#4218)
>> > [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
>> > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat
>> it
>> > does not crash (#3650)
>> > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
>> >
>> > *Improvements*:
>> > [AIRFLOW-3302] Small CSS fixes (#4140)
>> > [Airflow-2766] Respect shared datetime across tabs
>> > [AIRFLOW-2776] Compress tree view JSON
>> > [AIRFLOW-2407] Use feature detection for reload() (#3298)
>> > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
>> > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
>> > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
>> >
>> >
>> > *New features*:
>> > [AIRFLOW-2874] Enables FAB's theme support (#3719)
>> > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
>> >
>> > *Doc-only Change*:
>> > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
>> > [AIRFLOW-3018] Fix Minor issues in Documentation
>> > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
>> > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
>> > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
>> > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
>> > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
>> > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
>> > [AIRFLOW-XXX] Fix undocumented params in S3_hook
>> > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
>> > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
>> >
>> > Regards,
>> > *Kaxil Naik*
>> >
>>
>>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Kaxil Naik <ka...@gmail.com>.
You won't need to build assets. When we release (create tar file), the
assets are compiled using node and are already included. Hence, you would
just need to do `pip install apache-airflow==1.10.2rc3`

Regards,
Kaxil

On Sun, Jan 20, 2019, 21:53 Stefan Seelmann <mail@stefan-seelmann.de wrote:

> +1 (non-binding)
>
> Deployed in our test env and run the test suite.
>
> The update from 1.10.0 to 1.10.2rc3 was a bit bumpy:
> * DAG level access was only added in 1.10.2, not already in 1.10 as
> described in `UPDATING.md`. We use functions from `www_rbac/security.py`
> to create custom roles, but the file changed so this needed adaption.
> * We install Airflow from source (to be able to cherry-pick from master
> or apply patches). In 1.10.0 it was sufficient to do this with `pip
> install`. Since 1.10.1 it's also requried to build the `www_rbac` assets
> which requires node+npm. I'll submit a PR to update the `INSTALL` file.
>
> Kind Regards,
> Stefan
>
> On 1/19/19 5:35 PM, Kaxil Naik wrote:
> > Hey all,
> >
> > I have cut Airflow 1.10.2 RC3. This email is calling a vote on the
> release,
> > which will last for 72 hours. Consider this my (binding) +1.
> >
> > Airflow 1.10.2 RC3 is available at:
> > https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> >
> > *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> > with INSTALL instructions.
> > *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist"
> release.
> >
> > Public keys are available at:
> > https://dist.apache.org/repos/dist/release/airflow/KEYS
> >
> > Only votes from PMC members are binding, but members of the community are
> > encouraged to test the release and vote with "(non-binding)".
> >
> > Please note that the version number excludes the `rcX` string, so it's
> now
> > simply 1.10.2. This will allow us to rename the artifact without
> modifying
> > the artifact checksums when we actually release.
> >
> > Changes since 1.10.2rc2:
> > *Bugs*:
> > [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> > [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> > [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> > [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified
> via
> > UI (#4118)
> > [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> > [AIRFLOW-2766] Respect shared datetime across tabs
> > [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> > (#2450)
> > [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> > (#4218)
> > [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> > [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat
> it
> > does not crash (#3650)
> > [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> >
> > *Improvements*:
> > [AIRFLOW-3302] Small CSS fixes (#4140)
> > [Airflow-2766] Respect shared datetime across tabs
> > [AIRFLOW-2776] Compress tree view JSON
> > [AIRFLOW-2407] Use feature detection for reload() (#3298)
> > [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> > [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> > [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> >
> >
> > *New features*:
> > [AIRFLOW-2874] Enables FAB's theme support (#3719)
> > [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> >
> > *Doc-only Change*:
> > [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> > [AIRFLOW-3018] Fix Minor issues in Documentation
> > [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> > [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> > [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> > [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> > [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> > [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> > [AIRFLOW-XXX] Fix undocumented params in S3_hook
> > [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> > [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> >
> > Regards,
> > *Kaxil Naik*
> >
>
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Stefan Seelmann <ma...@stefan-seelmann.de>.
+1 (non-binding)

Deployed in our test env and run the test suite.

The update from 1.10.0 to 1.10.2rc3 was a bit bumpy:
* DAG level access was only added in 1.10.2, not already in 1.10 as
described in `UPDATING.md`. We use functions from `www_rbac/security.py`
to create custom roles, but the file changed so this needed adaption.
* We install Airflow from source (to be able to cherry-pick from master
or apply patches). In 1.10.0 it was sufficient to do this with `pip
install`. Since 1.10.1 it's also requried to build the `www_rbac` assets
which requires node+npm. I'll submit a PR to update the `INSTALL` file.

Kind Regards,
Stefan

On 1/19/19 5:35 PM, Kaxil Naik wrote:
> Hey all,
> 
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (binding) +1.
> 
> Airflow 1.10.2 RC3 is available at:
> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> 
> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> with INSTALL instructions.
> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
> 
> Public keys are available at:
> https://dist.apache.org/repos/dist/release/airflow/KEYS
> 
> Only votes from PMC members are binding, but members of the community are
> encouraged to test the release and vote with "(non-binding)".
> 
> Please note that the version number excludes the `rcX` string, so it's now
> simply 1.10.2. This will allow us to rename the artifact without modifying
> the artifact checksums when we actually release.
> 
> Changes since 1.10.2rc2:
> *Bugs*:
> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
> UI (#4118)
> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> [AIRFLOW-2766] Respect shared datetime across tabs
> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> (#2450)
> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> (#4218)
> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
> does not crash (#3650)
> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> 
> *Improvements*:
> [AIRFLOW-3302] Small CSS fixes (#4140)
> [Airflow-2766] Respect shared datetime across tabs
> [AIRFLOW-2776] Compress tree view JSON
> [AIRFLOW-2407] Use feature detection for reload() (#3298)
> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> 
> 
> *New features*:
> [AIRFLOW-2874] Enables FAB's theme support (#3719)
> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> 
> *Doc-only Change*:
> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> [AIRFLOW-3018] Fix Minor issues in Documentation
> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> [AIRFLOW-XXX] Fix undocumented params in S3_hook
> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> 
> Regards,
> *Kaxil Naik*
>

Re: [VOTE] Airflow 1.10.2rc3

Posted by Bolke de Bruin <bd...@gmail.com>.
+1, binding

Checked:
* KEYS
* Signatures
* Git Tag

Bolke


> On 19 Jan 2019, at 17:35, Kaxil Naik <ka...@gmail.com> wrote:
> 
> Hey all,
> 
> I have cut Airflow 1.10.2 RC3. This email is calling a vote on the release,
> which will last for 72 hours. Consider this my (binding) +1.
> 
> Airflow 1.10.2 RC3 is available at:
> https://dist.apache.org/repos/dist/dev/airflow/1.10.2rc3/
> 
> *apache-airflow-1.10.2rc3-source.tar.gz* is a source release that comes
> with INSTALL instructions.
> *apache-airflow-1.10.2rc3-bin.tar.gz* is the binary Python "sdist" release.
> 
> Public keys are available at:
> https://dist.apache.org/repos/dist/release/airflow/KEYS
> 
> Only votes from PMC members are binding, but members of the community are
> encouraged to test the release and vote with "(non-binding)".
> 
> Please note that the version number excludes the `rcX` string, so it's now
> simply 1.10.2. This will allow us to rename the artifact without modifying
> the artifact checksums when we actually release.
> 
> Changes since 1.10.2rc2:
> *Bugs*:
> [AIRFLOW-3732] Fix issue when trying to edit connection in RBAC UI
> [AIRFLOW-2866] Fix missing CSRF token head when using RBAC UI (#3804)
> [AIRFLOW-3259] Fix internal server error when displaying charts (#4114)
> [AIRFLOW-3271] Fix issue with persistence of RBAC Permissions modified via
> UI (#4118)
> [AIRFLOW-3141] Handle duration View for missing dag (#3984)
> [AIRFLOW-2766] Respect shared datetime across tabs
> [AIRFLOW-1413] Fix FTPSensor failing on error message with unexpected
> (#2450)
> [AIRFLOW-3378] KubernetesPodOperator does not delete on timeout failure
> (#4218)
> [AIRFLOW-3245] Fix list processing in resolve_template_files (#4086)
> [AIRFLOW-2703] Catch transient DB exceptions from scheduler's heartbeat it
> does not crash (#3650)
> [AIRFLOW-1298] Clear UPSTREAM_FAILED using the clean cli (#3886)
> 
> *Improvements*:
> [AIRFLOW-3302] Small CSS fixes (#4140)
> [Airflow-2766] Respect shared datetime across tabs
> [AIRFLOW-2776] Compress tree view JSON
> [AIRFLOW-2407] Use feature detection for reload() (#3298)
> [AIRFLOW-3452] Removed an unused/dangerous display-none (#4295)
> [AIRFLOW-3348] Update run statistics on dag refresh (#4197)
> [AIRFLOW-3125] Monitor Task Instances creation rates (#3966)
> 
> 
> *New features*:
> [AIRFLOW-2874] Enables FAB's theme support (#3719)
> [AIRFLOW-3336] Add new TriggerRule for 0 upstream failures (#4182)
> 
> *Doc-only Change*:
> [AIRFLOW-XXX] Fix BashOperator Docstring (#4052)
> [AIRFLOW-3018] Fix Minor issues in Documentation
> [AIRFLOW-XXX] Fix Minor issues with Azure Cosmos Operator (#4289)
> [AIRFLOW-3382] Fix incorrect docstring in DatastoreHook (#4222)
> [AIRFLOW-XXX] Fix copy&paste mistake (#4212)
> [AIRFLOW-3260] Correct misleading BigQuery error (#4098)
> [AIRFLOW-XXX] Fix Typo in SFTPOperator docstring (#4016)
> [AIRFLOW-XXX] Fixing the issue in Documentation (#3998)
> [AIRFLOW-XXX] Fix undocumented params in S3_hook
> [AIRFLOW-XXX] Fix SlackWebhookOperator execute method comment (#3963)
> [AIRFLOW-3070] Refine web UI authentication-related docs (#3863)
> 
> Regards,
> *Kaxil Naik*