You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/01/11 16:00:57 UTC

[GitHub] [bigtop] iwasakims commented on a change in pull request #832: BIGTOP-3601. Bump Kafka to 2.8.1.

iwasakims commented on a change in pull request #832:
URL: https://github.com/apache/bigtop/pull/832#discussion_r782293068



##########
File path: bigtop-packages/src/rpm/kafka/SPECS/kafka.spec
##########
@@ -66,6 +66,7 @@ Source2: install_%{kafka_name}.sh
 Source3: kafka-server.svc
 Source4: init.d.tmpl
 Source6: kafka.default
+#BIGTOP_PATCH_FILES

Review comment:
       We need the comments for rpm packaging to apply `patch*.diff` files. Bigtop replaces the `#BIGTOP_PATCH_FILES` in spec file with list of patches (and replaces `#BIGTOP_PATCH_COMMANDS` with command lines applying them. https://github.com/apache/bigtop/blob/master/packages.gradle#L590-L607
   
   While we have similar trick for deb packaging, we usually don't need modify sources of each package.
   https://github.com/apache/bigtop/blob/master/packages.gradle#L438-L447
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org