You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2015/12/09 20:20:07 UTC
Review Request 41146: test for region with multicast enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41146/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, and Jianxia Chen.
Repository: geode
Description
-------
test for region with multicast enabled
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java e7b155a
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 39b4986
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 1fc9f5b
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41146/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 41146: test for region with multicast enabled
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41146/#review109640
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On Dec. 9, 2015, 7:20 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41146/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 7:20 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> test for region with multicast enabled
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java e7b155a
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 39b4986
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 1fc9f5b
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41146/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 41146: test for region with multicast enabled
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41146/#review109649
-----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java (line 39)
<https://reviews.apache.org/r/41146/#comment169241>
remove todo
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java (line 47)
<https://reviews.apache.org/r/41146/#comment169240>
typo, Multicast
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java (line 61)
<https://reviews.apache.org/r/41146/#comment169242>
remove some of these empty lines
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java (line 116)
<https://reviews.apache.org/r/41146/#comment169243>
Typo, Multi instead of Muli
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java (line 119)
<https://reviews.apache.org/r/41146/#comment169244>
Why would we not have a check for reads and then a seperate one for writes and call them explicitly?
- Jason Huynh
On Dec. 9, 2015, 7:20 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41146/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 7:20 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jason Huynh, and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> test for region with multicast enabled
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DMStats.java e7b155a
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionStats.java 39b4986
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java 1fc9f5b
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/DistributedMulticastRegionDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41146/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>