You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gaborgsomogyi <gi...@git.apache.org> on 2018/06/01 12:53:09 UTC

[GitHub] spark pull request #21450: [SPARK-24319][SPARK SUBMIT] Fix spark-submit exec...

Github user gaborgsomogyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21450#discussion_r192385912
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java ---
    @@ -229,7 +238,7 @@
           args.add(join(",", pyFiles));
         }
     
    -    if (isExample) {
    +    if (isExample && requiresMainClass) {
    --- End diff --
    
    Originally I was hesitating to merge them and loose the 2 different meaning but it's better. Added a small comment.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org