You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/10 15:51:52 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #1021: Simplify record reader

alamb commented on a change in pull request #1021:
URL: https://github.com/apache/arrow-rs/pull/1021#discussion_r766786054



##########
File path: parquet/src/arrow/record_reader.rs
##########
@@ -75,9 +73,7 @@ impl<T: DataType> RecordReader<T> {
             column_desc: column_schema,
             num_records: 0,
             num_values: 0,
-            values_seen: 0,

Review comment:
       These fields look like they have been here since the initial implementation by @liurenjie1024 in https://github.com/apache/arrow/pull/4292 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org