You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/13 20:19:35 UTC

[GitHub] codecov-io edited a comment on issue #6838: Use chart plugins and remove code under visualizations

codecov-io edited a comment on issue #6838: Use chart plugins and remove code under visualizations
URL: https://github.com/apache/incubator-superset/pull/6838#issuecomment-461639591
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=h1) Report
   > Merging [#6838](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3f47c61dffc60503031e0dd8fd24415d6f1f1d6a?src=pr&el=desc) will **increase** coverage by `6.89%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6838/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6838      +/-   ##
   ==========================================
   + Coverage   56.22%   63.11%   +6.89%     
   ==========================================
     Files         527      423     -104     
     Lines       23529    20672    -2857     
     Branches     2782     2281     -501     
   ==========================================
   - Hits        13229    13048     -181     
   + Misses       9888     7487    -2401     
   + Partials      412      137     -275
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ts/src/visualizations/presets/LegacyChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL0xlZ2FjeUNoYXJ0UHJlc2V0Lmpz) | `0% <0%> (ø)` | :arrow_up: |
   | [...ssets/src/visualizations/presets/MapChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL01hcENoYXJ0UHJlc2V0Lmpz) | `0% <0%> (ø)` | :arrow_up: |
   | [...ts/src/visualizations/presets/CommonChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL0NvbW1vbkNoYXJ0UHJlc2V0Lmpz) | `0% <0%> (ø)` | :arrow_up: |
   | [...src/visualizations/presets/HierarchyChartPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL0hpZXJhcmNoeUNoYXJ0UHJlc2V0Lmpz) | `0% <0%> (ø)` | :arrow_up: |
   | [superset/assets/src/query/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9pbmRleC50cw==) | `0% <0%> (-100%)` | :arrow_down: |
   | [superset/assets/src/query/buildQueryObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9idWlsZFF1ZXJ5T2JqZWN0LnRz) | `0% <0%> (-100%)` | :arrow_down: |
   | [superset/assets/src/query/buildQueryContext.ts](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9idWlsZFF1ZXJ5Q29udGV4dC50cw==) | `0% <0%> (-100%)` | :arrow_down: |
   | [superset/assets/src/query/Metric.ts](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9NZXRyaWMudHM=) | `0% <0%> (-100%)` | :arrow_down: |
   | [superset/assets/src/query/FormData.ts](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9Gb3JtRGF0YS50cw==) | `0% <0%> (-100%)` | :arrow_down: |
   | [superset/assets/src/query/Column.ts](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9Db2x1bW4udHM=) | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/6838/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=footer). Last update [3f47c61...1946db0](https://codecov.io/gh/apache/incubator-superset/pull/6838?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org