You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:26:14 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4699: Add new registers in guest_os
GutoVeronezi opened a new pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699
### Description
`ACS` has some APIs to manage `guest_os` and `guest_os_hypervisor` mapping entries; however, it is impracticable to use it due to the way we have been working.
Most times we add data to these tables via `SQLs` with a hardcoded `id`. (See [schema-41200to41300.sql](https://github.com/apache/cloudstack/blob/0f3f2a09370a18301db28ec3d28efe746b6437c9/engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql)). Therefore, if an operator adds a new row to `guest_os` via the API, when he/she updates the version to any that insert a new row to `guest_os`, it might break the update due to duplicated id.
An `INSERT IGNORE` would avoid the breaking, but it would not insert the new row (if it contains different data/information/configuration); therefore, it does not seem like a good solution. Although it may not happen often, it could generate duplicated data (like display_name...).
This PR intends to add new data in `guest_os` and to suggest a new way to insert `guest_os` data via `SQL`, verifying if it already exists on the table (with `insert... select ... where not exists`).
Obs: we used a temporary table to avoid repeating the code.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
It has been tested locally on a test lab.
1. I generated the packages and updated my lab;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-881152435
@rhtyd @harikrishna-patnala please advise when you have the design doc or the PR submitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-874531147
I think this is okay, however, it may be better to start doing these changes via an internal Java API/manager/service. The logic would still be the same but it may be easier to use the API. Here's what I'm thinking:
1. Use same logic as in the SQL statement, to check if record exists in guest_os table and then for all hypervisor type/version mappings loop through the guest_os_hypervisor table
2. An internal API that is hypervisor-specific to check/validate the inputs** using Command-Answer patterns for a specific hypervisor type&version combination against, this can be done for both XenServer and Vmware but not KVM (KVM doesn't really care about the guest_os_hypervisor mapping, anything is acceptable).
The (1) is solved by this PR and maybe further improved/implemented via an internal Java Service/Mgr API. But (2) is the real problem, which is we add guest OS/hypervisor mappings manually which sometimes are wrong and only found in production. This can be solved if these mappings even though added manually are then cross-checked against some internal validation mechanism. For (1) a new Java API and for (2) an internal hypervisor-specific validation logic is something @harikrishna-patnala and I have discussed and would propose a design doc or a PR soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-836745026
@rhtyd as it can be a solution for issue #3609, could you take look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897177764
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#discussion_r584765469
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
##########
@@ -301,3 +301,43 @@ from
left join
`cloud`.`resource_count` secondary_storage_count ON domain.id = secondary_storage_count.domain_id
and secondary_storage_count.type = 'secondary_storage';
+
+-- PR#4699 Drop the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` if it already exist.
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING`;
+
+-- PR#4699 Create the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` to add guest_os and guest_os_hypervisor mapping.
+CREATE PROCEDURE `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` (
+ IN guest_os_category_id bigint(20) unsigned,
+ IN guest_os_display_name VARCHAR(255),
+ IN guest_os_hypervisor_hypervisor_type VARCHAR(32),
+ IN guest_os_hypervisor_hypervisor_version VARCHAR(32),
+ IN guest_os_hypervisor_guest_os_name VARCHAR(255)
+)
+BEGIN
+ INSERT INTO cloud.guest_os (uuid, category_id, display_name, created)
+ SELECT UUID(), guest_os_category_id, guest_os_display_name, now()
+ WHERE not exists( SELECT 1
+ FROM cloud.guest_os
+ WHERE cloud.guest_os.category_id = guest_os_category_id
+ AND cloud.guest_os.display_name = guest_os_display_name);
+
+ INSERT INTO cloud.guest_os_hypervisor (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created)
+ SELECT UUID(), guest_os_hypervisor_hypervisor_type, guest_os_hypervisor_hypervisor_version, guest_os_hypervisor_guest_os_name, guest_os.id, now()
+ FROM cloud.guest_os
+ WHERE guest_os.category_id = guest_os_category_id
+ AND guest_os.display_name = guest_os_display_name
+ AND NOT EXISTS (SELECT 1
+ FROM cloud.guest_os_hypervisor as hypervisor
+ WHERE hypervisor_type = guest_os_hypervisor_hypervisor_type
+ AND hypervisor_version = guest_os_hypervisor_hypervisor_version
+ AND hypervisor.guest_os_id = guest_os.id
+ AND hypervisor.guest_os_name = guest_os_hypervisor_guest_os_name);
+END;
+
Review comment:
@weizhouapache done.
I misunderstood it at first, but now i see.
I took a look into the file that reads and execute the SQL script and wondered why it was wrote that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896954817
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-890130499
@DaanHoogland, you're right, we lost the focus.
Getting back to the topic...
The SQL in this PR would not hide any other solution, as it would insert new data, like we did many times before, and I do agree with a better structure for future works. At first, the implementation was a "simple" insert, however, by suggestion (here https://github.com/apache/cloudstack/pull/4699#issuecomment-780855187), I created a stored procedure, which could be reutilized. If it makes sense, we could get back to the first implementation, as the stored procedure may not be necessary in the future, with a better structured management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-865052134
@harikrishna-patnala any update about @rhtyd's comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867530799
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-869190332
Hi @GutoVeronezi can you please resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-890118883
@GutoVeronezi @rhtyd , I think you are having a misunderstanding. The word messing might have a different connotation to you both, and mixing might be a good substitute.
Let's get back to the technical discussion. should sql only insertion of os-types be the way to go or is a better management structure needed?
Also, would the SQL in this PR, hinder such a more elaborate solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867530621
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892822402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-890130499
@DaanHoogland, you're right, we lose the focus.
Getting back to the topic...
The SQL in this PR would not hide any other solution, as it would insert new data, like we did many times before, and I do agree with a better structure for future works. At first, the implementation was a "simple" insert, however, by suggestion (here https://github.com/apache/cloudstack/pull/4699#issuecomment-780855187), I created a stored procedure, which could be reutilized. If it makes sense, we could get back to the first implementation, as the stored procedure may not be necessary in the future, with a better structured management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-889239821
@nvazquez @rhtyd
CC @GabrielBrascher
I agree with the UI integration and better ways to manage these data (also we already have APIs); However, these changes will not block any of your suggestions. Also, seems like the UI integration will be implemented after 4.16.
Therefore, I'm wondering why put it in `status:On hold`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896617061
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896616327
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-866954521
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-889626735
I've left remarks already what's missing, the PR doesn't fully satisfy all the requirements for the issue I had logged in 2019 https://github.com/apache/cloudstack/issues/3609 while it indeed implements the sql logic but for me that's not enough. If the PR author doesn't want to work to satisfy the requirements asked in the issue and in the review then I personally don't like us to include half baked solutions that add debt for others to fix in future. Furthermore I see @Spaceman1984 doing something about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892823199
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892822402
@GutoVeronezi @rhtyd thanks for clarifying the misunderstanding, I have removed the 'On-hold' label and we can move on with this PR. It is clear to me now that this PR won't fix issue #3609, and also this implementation may/will be refactored/deprecated for a Java-based solution in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-839442933
@rhtyd yes, I've already referred this PR in that document. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867364967
Sorry guys, missed conversations on this PR. This PR changes are good and we need this. All I'm saying is I've just referred this PR to the other improvements that we are planning internally.
So LGTM from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897157261
@nvazquez as we discussed offline, the environment where I ran the tests and the environment where the tests ran in the CI are different.
Mine uses:
```
mysql Ver 14.14 Distrib 5.7.35, for Linux (x86_64) using EditLine wrapper
```
Tests uses:
```
mysql Ver 15.1 Distrib 5.5.68-MariaDB, for Linux (x86_64) using readline 5.1
```
I did some tests with MariaDB and found the following situation:
MySQL (which I was using) doesn't requires a `from` clause with a dummy table, even if we are using a `where` clause [MySQL doc](https://dev.mysql.com/doc/refman/5.7/en/select.html). MariaDB (that the CI tests were using), although its [doc](https://mariadb.com/kb/en/dual/) says `FROM DUAL could be used...`, which would indicate that it is not mandatory, in reality requires a dummy table when we use a `where` clause.
Therefore, I added the `FROM DUAL` clause to allow it to run in MariaDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897161886
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896872521
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892823681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-781536719
> @GutoVeronezi
> it is better to create a mysql procedure which can be used for any hypervisor and guest os.
@weizhouapache I turned it into a mysql procedure, as you suggested.
Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-814911702
@weizhouapache @shwstppr is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-847036230
@GabrielBrascher @shwstppr @weizhouapache is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-895461184
@nvazquez could we try to run the tests again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-889949540
@Spaceman1984 please link to you PR here and discuss with @GutoVeronezi how the efforts can be combined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-880455234
cc @Spaceman1984 @sureshanaparti @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-830316022
@weizhouapache @shwstppr @GabrielBrascher is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-866924785
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897161338
Thanks for the quick fix @GutoVeronezi. Let's kick another round of tests
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-866923784
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-865642636
@harikrishna-patnala I'm sure @GutoVeronezi doesn't have your document. Can you share it or share the jist of it here?
Is it a conflict that would stop us from going on with either that or this? (cc @rhtyd )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-895590414
<b>Trillian Build Failed (tid-1564)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-836741715
@weizhouapache can you look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#discussion_r582976453
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
##########
@@ -301,3 +301,43 @@ from
left join
`cloud`.`resource_count` secondary_storage_count ON domain.id = secondary_storage_count.domain_id
and secondary_storage_count.type = 'secondary_storage';
+
+-- PR#4699 Drop the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` if it already exist.
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING`;
+
+-- PR#4699 Create the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` to add guest_os and guest_os_hypervisor mapping.
+CREATE PROCEDURE `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` (
+ IN guest_os_category_id bigint(20) unsigned,
+ IN guest_os_display_name VARCHAR(255),
+ IN guest_os_hypervisor_hypervisor_type VARCHAR(32),
+ IN guest_os_hypervisor_hypervisor_version VARCHAR(32),
+ IN guest_os_hypervisor_guest_os_name VARCHAR(255)
+)
+BEGIN
+ INSERT INTO cloud.guest_os (uuid, category_id, display_name, created)
+ SELECT UUID(), guest_os_category_id, guest_os_display_name, now()
+ WHERE not exists( SELECT 1
+ FROM cloud.guest_os
+ WHERE cloud.guest_os.category_id = guest_os_category_id
+ AND cloud.guest_os.display_name = guest_os_display_name);
+
+ INSERT INTO cloud.guest_os_hypervisor (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created)
+ SELECT UUID(), guest_os_hypervisor_hypervisor_type, guest_os_hypervisor_hypervisor_version, guest_os_hypervisor_guest_os_name, guest_os.id, now()
+ FROM cloud.guest_os
+ WHERE guest_os.category_id = guest_os_category_id
+ AND guest_os.display_name = guest_os_display_name
+ AND NOT EXISTS (SELECT 1
+ FROM cloud.guest_os_hypervisor as hypervisor
+ WHERE hypervisor_type = guest_os_hypervisor_hypervisor_type
+ AND hypervisor_version = guest_os_hypervisor_hypervisor_version
+ AND hypervisor.guest_os_id = guest_os.id
+ AND hypervisor.guest_os_name = guest_os_hypervisor_guest_os_name);
+END;
+
Review comment:
@GutoVeronezi
what I said is not clear.
I mean you need to change line 322 and 334 which have ";" at the end of line.
line 335 was ok (it is not ok now).
for line 322, you can move the ";" at the end of line, to be beginning of line 324.
for line 334, you can move the ";" to the position before "END;".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-865642636
@harikrishna-patnala I'm sure @GutoVeronezi doesn't have your document. Can you share it or share the jist of it here?
Is it a conflict that would stop us from going on with either that or this? (cc @rhtyd )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892822402
@GutoVeronezi @rhtyd thanks for clarifying the misunderstanding, I have removed the 'On-hold' label and we can move on with this PR. It is clear to me now that this PR won't fix issue #3609, and also this implementation may/will be refactored for a Java-based solution in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896988227
Hi @GutoVeronezi the failures are consistent, I have checked is related to an error on the procedure creation, can you please check?
````
2021-08-11 16:28:18,001 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) Error executing: CREATE PROCEDURE `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` ( IN guest_os_category_id bigint(20) unsigned, IN guest_os_display_name VARCHAR(255), IN guest_os_hypervisor_hypervisor_type VARCHAR(32), IN guest_os_hypervisor_hypervisor_version VARCHAR(32), IN guest_os_hypervisor_guest_os_name VARCHAR(255) ) BEGIN INSERT INTO cloud.guest_os (uuid, category_id, display_name, created) SELECT UUID(), guest_os_category_id, guest_os_display_name, now() WHERE not exists( SELECT 1 FROM cloud.guest_os WHERE cloud.guest_os.category_id = guest_os_category_id AND cloud.guest_os.display_name = guest_os_display_name) ; INSERT INTO cloud.guest_os_hypervisor (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created) SELECT UUID(), guest_os_hypervisor_hypervisor_type, guest_os_hype
rvisor_hypervisor_version, guest_os_hypervisor_guest_os_name, guest_os.id, now() FROM cloud.guest_os WHERE guest_os.category_id = guest_os_category_id AND guest_os.display_name = guest_os_display_name AND NOT EXISTS (SELECT 1 FROM cloud.guest_os_hypervisor as hypervisor WHERE hypervisor_type = guest_os_hypervisor_hypervisor_type AND hypervisor_version = guest_os_hypervisor_hypervisor_version AND hypervisor.guest_os_id = guest_os.id AND hypervisor.guest_os_name = guest_os_hypervisor_guest_os_name) ;END
2021-08-11 16:28:18,001 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE not exists( SELECT 1 FROM cloud.guest_os ' at line 1
2021-08-11 16:28:18,004 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Unable to execute upgrade script
java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE not exists( SELECT 1 FROM cloud.guest_os ' at line 1
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:209)
at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:295)
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:379)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:64)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:54)
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:178)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:54)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:155)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:940)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:591)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:144)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:121)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:244)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:249)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:232)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:116)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:78)
at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:57)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:61)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:51)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1068)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:572)
at org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:997)
at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:746)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1457)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1422)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:911)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:426)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start(Server.java:423)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.Server.doStart(Server.java:387)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:188)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:104)
2021-08-11 16:28:18,006 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Unable to upgrade the database
com.cloud.utils.exception.CloudRuntimeException: Unable to execute upgrade script
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:295)
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:379)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:64)
at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLifeCycle.start(CloudStackExtendedLifeCycle.java:54)
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:178)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:54)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:155)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:940)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:591)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContext(DefaultModuleDefinitionSet.java:144)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$2.with(DefaultModuleDefinitionSet.java:121)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:244)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:249)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule(DefaultModuleDefinitionSet.java:232)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:116)
at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load(DefaultModuleDefinitionSet.java:78)
at org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules(ModuleBasedContextFactory.java:37)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init(CloudStackSpringContext.java:70)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:57)
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:61)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:51)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1068)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:572)
at org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:997)
at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:746)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1457)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1422)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:911)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:426)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start(Server.java:423)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.Server.doStart(Server.java:387)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:188)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:104)
Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE not exists( SELECT 1 FROM cloud.guest_os ' at line 1
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:209)
... 52 more
2021-08-11 16:28:18,031 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 263 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:310-DatabaseUpgradeChecker.check:379-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-847890849
@harikrishna-patnala can you review this PR - is this good to go or needs to wait for your design proposal/changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-881265528
I'm looking into creating the suggested solution by @rhtyd and UI integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892841011
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867544007
<b>Trillian Build Failed (tid-1086)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892841354
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892840724
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896955499
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-895468966
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-780855187
@GutoVeronezi
it is better to create a mysql procedure which can be used for any hypervisor and guest os.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896903025
<b>Trillian Build Failed (tid-1603)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896977425
<b>Trillian Build Failed (tid-1605)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-889968166
@rhtyd I think you are messing things up. The main intention of this PR is to add data to `guest_os` in a safer manner, and not to solve issue #3609.
There are two isolated points here: (A) insert new data and (B) solve issue #3609.
B was never the main intention of this PR, leaving B as still pending, but A is solved, which is the main intention to me right now. About `the PR author doesn't want to work to satisfy the requirements asked in the issue`, yes, the author doesn't want to work to satisfy the issue requirements because it was never the goal.
This PR is isolated from the proposals yous guys have, and both of them can coexist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#discussion_r582661864
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
##########
@@ -301,3 +301,43 @@ from
left join
`cloud`.`resource_count` secondary_storage_count ON domain.id = secondary_storage_count.domain_id
and secondary_storage_count.type = 'secondary_storage';
+
+-- PR#4699 Drop the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` if it already exist.
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING`;
+
+-- PR#4699 Create the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` to add guest_os and guest_os_hypervisor mapping.
+CREATE PROCEDURE `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` (
+ IN guest_os_category_id bigint(20) unsigned,
+ IN guest_os_display_name VARCHAR(255),
+ IN guest_os_hypervisor_hypervisor_type VARCHAR(32),
+ IN guest_os_hypervisor_hypervisor_version VARCHAR(32),
+ IN guest_os_hypervisor_guest_os_name VARCHAR(255)
+)
+BEGIN
+ INSERT INTO cloud.guest_os (uuid, category_id, display_name, created)
+ SELECT UUID(), guest_os_category_id, guest_os_display_name, now()
+ WHERE not exists( SELECT 1
+ FROM cloud.guest_os
+ WHERE cloud.guest_os.category_id = guest_os_category_id
+ AND cloud.guest_os.display_name = guest_os_display_name);
+
+ INSERT INTO cloud.guest_os_hypervisor (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created)
+ SELECT UUID(), guest_os_hypervisor_hypervisor_type, guest_os_hypervisor_hypervisor_version, guest_os_hypervisor_guest_os_name, guest_os.id, now()
+ FROM cloud.guest_os
+ WHERE guest_os.category_id = guest_os_category_id
+ AND guest_os.display_name = guest_os_display_name
+ AND NOT EXISTS (SELECT 1
+ FROM cloud.guest_os_hypervisor as hypervisor
+ WHERE hypervisor_type = guest_os_hypervisor_hypervisor_type
+ AND hypervisor_version = guest_os_hypervisor_hypervisor_version
+ AND hypervisor.guest_os_id = guest_os.id
+ AND hypervisor.guest_os_name = guest_os_hypervisor_guest_os_name);
+END;
+
Review comment:
@GutoVeronezi
this procedure might work in mysql, but I think it will not in cloudstack upgrade.
";" should not be the last character of a line in a procedure in schema-XXX.sql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#discussion_r582654727
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
##########
@@ -301,3 +301,43 @@ from
left join
`cloud`.`resource_count` secondary_storage_count ON domain.id = secondary_storage_count.domain_id
and secondary_storage_count.type = 'secondary_storage';
+
+-- PR#4699 Drop the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` if it already exist.
+DROP PROCEDURE IF EXISTS `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING`;
+
+-- PR#4699 Create the procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` to add guest_os and guest_os_hypervisor mapping.
+CREATE PROCEDURE `cloud`.`ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` (
+ IN guest_os_category_id bigint(20) unsigned,
+ IN guest_os_display_name VARCHAR(255),
+ IN guest_os_hypervisor_hypervisor_type VARCHAR(32),
+ IN guest_os_hypervisor_hypervisor_version VARCHAR(32),
+ IN guest_os_hypervisor_guest_os_name VARCHAR(255)
+)
+BEGIN
+ INSERT INTO cloud.guest_os (uuid, category_id, display_name, created)
+ SELECT UUID(), guest_os_category_id, guest_os_display_name, now()
+ WHERE not exists( SELECT 1
+ FROM cloud.guest_os
+ WHERE cloud.guest_os.category_id = guest_os_category_id
+ AND cloud.guest_os.display_name = guest_os_display_name);
+
+ INSERT INTO cloud.guest_os_hypervisor (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created)
+ SELECT UUID(), guest_os_hypervisor_hypervisor_type, guest_os_hypervisor_hypervisor_version, guest_os_hypervisor_guest_os_name, guest_os.id, now()
+ FROM cloud.guest_os
+ WHERE guest_os.category_id = guest_os_category_id
+ AND guest_os.display_name = guest_os_display_name
+ AND NOT EXISTS (SELECT 1
+ FROM cloud.guest_os_hypervisor as hypervisor
+ WHERE hypervisor_type = guest_os_hypervisor_hypervisor_type
+ AND hypervisor_version = guest_os_hypervisor_hypervisor_version
+ AND hypervisor.guest_os_id = guest_os.id
+ AND hypervisor.guest_os_name = guest_os_hypervisor_guest_os_name);
+END;
+
+-- PR#4699 Call procedure `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING` to add new data to guest_os and guest_os_hypervisor.
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Ubuntu 20.04 LTS', 'KVM', 'default', 'Ubuntu 20.04 LTS');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'Ubuntu 21.04', 'KVM', 'default', 'Ubuntu 21.04');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'pfSense 2.4', 'KVM', 'default', 'pfSense 2.4');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'OpenBSD 6.7', 'KVM', 'default', 'OpenBSD 6.7');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'OpenBSD 6.8', 'KVM', 'default', 'OpenBSD 6.8');
+CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (1, 'AlmaLinux 8.3', 'KVM', 'default', 'AlmaLinux 8.3');
Review comment:
category_id used here for each entry is 1 while for Ubuntu releases we have 10. Not sure for others it should be 7 or 9. It is 9 for FreeBSD in current db
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896871464
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-865052134
@harikrishna-patnala any update about @rhtyd's comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-855906351
@harikrishna-patnala any update about @rhtyd's comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897620124
<b>Trillian test result (tid-1613)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4699-t1613-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 87 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 741.53 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 942.32 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 635.85 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 548.34 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 414.67 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867394559
<b>Trillian Build Failed (tid-1081)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897175414
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-890098933
@GutoVeronezi I'm not "messing things up", you pinged me on the issue #3609 saying "There is a PR (#4699) that I think would solve this situation", now you're saying it doesn't.
That's fine if you don't want to address the requested scope of changes, I had originally asked Hari on the issue to explore a solution which is now explored by Darrin in another PR.
However, as an independent reviewer I don't like the sql only solution covers just (A) as it's not an elegant and re-usable solution, people won't remember the introduced sql procedure. An internal Java based API would be elegant and reusable. I'm bit surprised with your reply and conduct, and this PR since your other PRs have been quite clean and elegant. That said I don't intend to block or "mess" with this PR as it doesn't concern the issue I had logged.
Please note I wasn't the one who added the on-hold label, I simply responded to your comment since you tagged me. It was 4.16 RM in their right towards 4.16 milestone to put any labels or triage any issues or PRs. Nicolas maybe my dayjob work colleague but we've no influence on each other in our community work and communication which is evident by the fact that we all work remotely in different timezones and we often disagree that spills over both public and private ACS lists. So there's no attempt to "mess" with anyone, just misunderstanding on your part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867380635
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-895468223
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892855554
<b>Trillian Build Failed (tid-1481)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-867380365
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892823681
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-838042680
cc @harikrishna-patnala I think you are working on a design doc on improving guest OS mapping support code-base wide, you may refer to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-874531147
I think this is okay, however, it may be better to start doing these changes via an internal Java API/manager/service. The logic would still be the same but it may be easier to use the API. Here's what I'm thinking:
1. Use same logic as in the SQL statement, to check if record exists in guest_os table and then for all hypervisor type/version mappings loop through the guest_os_hypervisor table
2. An internal API that is hypervisor-specific to check/validate the inputs** using Command-Answer patterns for a specific hypervisor type&version combination against, this can be done for both XenServer and Vmware but not KVM (KVM doesn't really care about the guest_os_hypervisor mapping, anything is acceptable).
The (1) is solved by this PR and maybe further improved/implemented via an internal Java Service/Mgr API. But (2) is the real problem, which is we add guest OS/hypervisor mappings manually which sometimes are wrong and only found in production. This can be solved if these mappings even though added manually are then cross-checked against some internal validation mechanism. For (1) a new Java API and for (2) an internal hypervisor-specific validation logic is something @harikrishna-patnala and I have discussed and would propose a design doc or a PR soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-869829459
> Hi @GutoVeronezi can you please resolve the conflicts
@sureshanaparti done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-869829459
> Hi @GutoVeronezi can you please resolve the conflicts
@sureshanaparti done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-896637694
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-897177298
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-889317218
@GutoVeronezi I agree this PR wouldn't block the suggestions but since @rhtyd and @harikrishna-patnala mentioned an improvement through a Java API I placed the label so we can decide the way forward and do not do double efforts for the same task. Personally nothing against the PR, please advise how to proceed on this @rhtyd @GabrielBrascher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #4699: Add new registers in guest_os
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #4699:
URL: https://github.com/apache/cloudstack/pull/4699#issuecomment-892822402
@GutoVeronezi @rhtyd thanks for clarifying the misunderstanding, I have removed the 'On-hold' label and we can move on with this PR. It is clear to me now that this PR won't fix issue #3609, and also this implementation may/will be refactored/deprecated for a Java-based solution in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org