You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Wanqi Lyu (Jira)" <ji...@apache.org> on 2020/04/16 19:28:00 UTC
[jira] [Comment Edited] (BEAM-8646) PR #9814 appears to cause
failures in fnapi_runner tests on Windows
[ https://issues.apache.org/jira/browse/BEAM-8646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085198#comment-17085198 ]
Wanqi Lyu edited comment on BEAM-8646 at 4/16/20, 7:27 PM:
-----------------------------------------------------------
[~robertwb] Hi Robert, should we for now add `darwin` in the special casing that was added in PR#10100?
something like this:
{code:java}
#TODO(BEAM-8646): Reconcile the behavior on Windows / MacOS platform.
if sys.platform in ('win32', 'darwin'):
return 'localhost'
{code}
?
was (Author: violalyu):
[~robertwb] Hi Robert, should we for now add `darwin` in the special casing that was added in PR#10100?
something like this:
```
# TODO(BEAM-8646): Reconcile the behavior on Windows / MacOS platform.
if sys.platform in ('win32', 'darwin'):
return 'localhost'
```
?
> PR #9814 appears to cause failures in fnapi_runner tests on Windows
> -------------------------------------------------------------------
>
> Key: BEAM-8646
> URL: https://issues.apache.org/jira/browse/BEAM-8646
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Wanqi Lyu
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> It appears that changes in
> https://github.com/apache/beam/commit/d6bcb03f586b5430c30f6ca4a1af9e42711e529c cause test failures in Beam test suite on Windows, for example:
> python setup.py nosetests --tests apache_beam/runners/portability/portable_runner_test.py:PortableRunnerTestWithExternalEnv.test_callbacks_with_exception
> does not finish on a Windows VM machine within at least 60 seconds but passes within a second if we change host_from_worker to return 'localhost' in [1].
> [~violalyu] , do you think you could take a look? Thanks!
> cc: [~chadrik] [~thw]
> [1] https://github.com/apache/beam/blob/808cb35018cd228a59b152234b655948da2455fa/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L1377.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)