You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/05/17 17:22:29 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #6374: Prepare for object_store 0.6
tustvold opened a new pull request, #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The next release of object_store contains a number of breaking changes, lets verify them before cutting the release
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] r4ntix commented on a diff in pull request #6374: Prepare for object_store 0.6 and arrow 41
Posted by "r4ntix (via GitHub)" <gi...@apache.org>.
r4ntix commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1215577966
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -36,10 +42,29 @@ pub fn get_s3_object_store_builder(
builder = builder
.with_access_key_id(access_key_id)
.with_secret_access_key(secret_access_key);
- }
- if let Some(session_token) = cmd.options.get("session_token") {
- builder = builder.with_token(session_token);
+ if let Some(session_token) = cmd.options.get("session_token") {
+ builder = builder.with_token(session_token);
+ }
+ } else {
+ let config = aws_config::from_env().load().await;
Review Comment:
> cc @r4ntix as I think you contributed some of the previous configuration code
@alamb Thanks for the heads up, I think this is a great improvement. Thanks @tustvold 👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #6374: Update to object_store 0.6 and arrow 41
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6374: Prepare for object_store 0.6
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1196852806
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -36,10 +42,29 @@ pub fn get_s3_object_store_builder(
builder = builder
.with_access_key_id(access_key_id)
.with_secret_access_key(secret_access_key);
- }
- if let Some(session_token) = cmd.options.get("session_token") {
- builder = builder.with_token(session_token);
+ if let Some(session_token) = cmd.options.get("session_token") {
+ builder = builder.with_token(session_token);
+ }
+ } else {
+ let config = aws_config::from_env().load().await;
Review Comment:
Unlike before, this now ensures that users get the full coherent configuration experience that they might expect from a CLI tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #6374: Prepare for object_store 0.6
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#issuecomment-1556737704
Waiting for https://github.com/apache/arrow-rs/pull/4251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6374: Prepare for object_store 0.6 and arrow 41
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1214751959
##########
datafusion-cli/src/object_storage.rs:
##########
@@ -36,10 +42,29 @@ pub fn get_s3_object_store_builder(
builder = builder
.with_access_key_id(access_key_id)
.with_secret_access_key(secret_access_key);
- }
- if let Some(session_token) = cmd.options.get("session_token") {
- builder = builder.with_token(session_token);
+ if let Some(session_token) = cmd.options.get("session_token") {
+ builder = builder.with_token(session_token);
+ }
+ } else {
+ let config = aws_config::from_env().load().await;
Review Comment:
cc @r4ntix as I think you contributed some of the previous configuration code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6374: Update to object_store 0.6 and arrow 41
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #6374:
URL: https://github.com/apache/arrow-datafusion/pull/6374#discussion_r1219509184
##########
datafusion-examples/examples/parquet_sql_multiple_files.rs:
##########
@@ -40,7 +40,7 @@ async fn main() -> Result<()> {
// for the query
ctx.register_listing_table(
"my_table",
- &format!("file://{testdata}"),
+ &format!("file://{testdata}/alltypes_plain.parquet"),
Review Comment:
This is a nice validation of https://github.com/apache/arrow-rs/issues/4230 being a valuable change. This test was broken, as the lack of a trailing `/` meant it wouldn't list the directory, and this meant it silently failed to list any files. Schema inference fails on the root directory (correctly) so I changed this to a single file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org