You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2023/07/24 22:49:25 UTC

[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #2150: TINKERPOP-2946 Detect ordering issues in Gherkin tests

Cole-Greer opened a new pull request, #2150:
URL: https://github.com/apache/tinkerpop/pull/2150

   This commit addresses part 1. of TINKERPOP-2946 by introducing TinkerShuffleGraph and running feature tests against an embedded instance of this graph.
   
   TinkerShuffleGraph is derived from TinkerGraph and intended for test purposes only. It's only differentiation from TinkerGraph is that it will returned shuffled results when getting any of the following:
   
   vertices from the graph,
   edges from the graph,
   vertices from a vertex,
   edges from a vertex,
   vertices from an edge,
   properties from a vertex,
   properties from an edge, and
   properties from a VertexProperty


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-2946 Detect ordering issues in Gherkin tests [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2150:
URL: https://github.com/apache/tinkerpop/pull/2150#issuecomment-1783551035

   I've updated the description with some recent changes to this. I think it is good to go now.
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tinkerpop] codecov-commenter commented on pull request #2150: TINKERPOP-2946 Detect ordering issues in Gherkin tests

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2150:
URL: https://github.com/apache/tinkerpop/pull/2150#issuecomment-1648739117

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2150](https://app.codecov.io/gh/apache/tinkerpop/pull/2150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cf83bc2) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/127bf02c84618aed5777d115dfc8780aed17e55d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (127bf02) will **decrease** coverage by `5.57%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2150      +/-   ##
   ============================================
   - Coverage     75.85%   70.29%   -5.57%     
   ============================================
     Files          1039       24    -1015     
     Lines         63433     3541   -59892     
     Branches       7028        0    -7028     
   ============================================
   - Hits          48120     2489   -45631     
   + Misses        12694      881   -11813     
   + Partials       2619      171    -2448     
   ```
   
   
   [see 1015 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2150/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-2946 Detect ordering issues in Gherkin tests [tinkerpop]

Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2150:
URL: https://github.com/apache/tinkerpop/pull/2150#issuecomment-1789792023

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-2946 Detect ordering issues in Gherkin tests [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2150:
URL: https://github.com/apache/tinkerpop/pull/2150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] TINKERPOP-2946 Detect ordering issues in Gherkin tests [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2150:
URL: https://github.com/apache/tinkerpop/pull/2150#issuecomment-1783571148

   VOTE+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org