You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/02 01:23:06 UTC
[GitHub] [singa] nudles opened a new pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
nudles opened a new pull request #786:
URL: https://github.com/apache/singa/pull/786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...08fd914](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.08% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...d9981fa](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-689934676
This pull request **fixes 3 alerts** when merging d9981fabc2fff7ea9312a2742c04a99cfd8d32eb into 2cdb881f5f84844caa728574ca0ae9f619382cb4 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-d45015f13e637fb53a3ea72422cbfec4fd630ded)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...5c0dcac](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...07460c8](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...07460c8](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...9820c6d](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...07460c8](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...5c0dcac](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
nudles commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-686878635
I think the issue is because libiomp5.dylib is not found.
so need to either install it or use dnnl with cpu_tbb instead of cpu_iomp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...07460c8](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685254284
This pull request **fixes 3 alerts** when merging 3ef3f79c2dba366e319423cde4560b5924643bbe into 178b107741081332fb51d908e87e7fa26b69779e - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-4bcab15b251b33356664b9ac39efae352d365bca)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-689923979
This pull request **fixes 3 alerts** when merging d80c6024714ae9135dababcb458ef834a09e4fdf into 2cdb881f5f84844caa728574ca0ae9f619382cb4 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-82e6fe4ab18ae736ad9405a4ec09671d7ac5503f)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin merged pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
dcslin merged pull request #786:
URL: https://github.com/apache/singa/pull/786
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...5c0dcac](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...5c0dcac](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...3ef3f79](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-687140995
- I tried `dnnl_mac_1.1.0_cpu_tbb`. Installed tbb by `brew install tbb`, But the problem persists, it could not load `libdnnl.1.dylib`
- I also tried to use `dnnl_mac_1.1.0_cpu_iomp`, and installed dependency by `brew install libomp`. After a few tweaks like ignoring security check on external library error from macos. Still could not load the `libdnnl.1.dylib`
- Using our dnnl conda package seems working fine, commands to reproduce:
- `conda install -c nusdbsystem dnnl`
- `export DNNL_ROOT=path/to/conda`
- compile singa and run test and looks ok
```
[09:19 pm] dcslin0:build sc$ ./bin/test_singa | head -n 10
Running main() from gtest_main.cc
[==========] Running 170 tests from 38 test cases.
[----------] Global test environment set-up.
[----------] 1 test from Accuracy
[ RUN ] Accuracy.Compute
[ OK ] Accuracy.Compute (0 ms)
[----------] 1 test from Accuracy (0 ms total)
[----------] 3 tests from Activation
[ RUN ] Activation.Setup
```
```
[09:17 pm] dcslin0:singa sc$ PYTHONPATH=build/python/ python3 -c "from singa import tensor"
[09:20 pm] dcslin0:singa sc$
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-686859573
it seems that a direct fix is to overwrite the linking `install_name_tool -change libdnnl.1.dylib path/to/libdnnl.1.dylib python/singa/_singa_wrap.so`.
But it report another error `libdnnl.1.1.dylib) not valid for use in process using Library Validation: library load disallowed by system policy`. Still checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685354041
This pull request **fixes 3 alerts** when merging 9820c6d136474bad240506375c91900c99accf8b into 178b107741081332fb51d908e87e7fa26b69779e - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-9efe5e3373e9ab992465387faf25952261a52cf8)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
==========================================
+ Coverage 65.08% 65.21% +0.12%
==========================================
Files 86 104 +18
Lines 4786 12413 +7627
==========================================
+ Hits 3115 8095 +4980
- Misses 1671 4318 +2647
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.08% <ø> (?)` | |
| #singa-python | `65.29% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [snapshot.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-c25hcHNob3QucHk=) | `0.00% <0.00%> (ø)` | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | `49.39% <0.00%> (ø)` | |
| [utils.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | `65.78% <0.00%> (ø)` | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [opt.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-b3B0LnB5) | `48.31% <0.00%> (ø)` | |
| [proto/io\_pb2.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-cHJvdG8vaW9fcGIyLnB5) | `0.00% <0.00%> (ø)` | |
| [model.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | `89.65% <0.00%> (ø)` | |
| [proto/core\_pb2.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-cHJvdG8vY29yZV9wYjIucHk=) | `0.00% <0.00%> (ø)` | |
| [device.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | `41.86% <0.00%> (ø)` | |
| [layer.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | `80.97% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...d9981fa](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...9820c6d](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...08fd914](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...3ef3f79](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...5c0dcac](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238711
This pull request **fixes 3 alerts** when merging 5c0dcac2cede4211c714e70d31e0701ee87170a1 into 178b107741081332fb51d908e87e7fa26b69779e - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-5b19892633b7527be5057078bf853067583264ce)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.08% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...d9981fa](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...d80c602](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...3ef3f79](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685423458
This pull request **fixes 3 alerts** when merging 08fd914766a40294c0648cb25ab1fc83cbb6b8d3 into 178b107741081332fb51d908e87e7fa26b69779e - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-bacdc357ad4433c3a234aaa637c96727d27c3362)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 86 86
Lines 4786 4786
=======================================
Hits 3115 3115
Misses 1671 1671
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...07460c8](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-686871515
```
[10:58 am] dcslin0:singa sc$ PYTHONPATH=build/python/ python3 -c "from singa import tensor"
Traceback (most recent call last):
File "/Users/sc/git/singa/build/python/singa/singa_wrap.py", line 14, in swig_import_helper
return importlib.import_module(mname)
File "/Users/sc/.pyenv/versions/3.6.6/lib/python3.6/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 658, in _load_unlocked
File "<frozen importlib._bootstrap>", line 571, in module_from_spec
File "<frozen importlib._bootstrap_external>", line 922, in create_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
ImportError: dlopen(/Users/sc/git/singa/build/python/singa/_singa_wrap.so, 2): Library not loaded: libdnnl.1.dylib
Referenced from: /Users/sc/git/singa/build/python/singa/_singa_wrap.so
Reason: image not found
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/Users/sc/git/singa/build/python/singa/__init__.py", line 18, in <module>
from . import singa_wrap
File "/Users/sc/git/singa/build/python/singa/singa_wrap.py", line 17, in <module>
_singa_wrap = swig_import_helper()
File "/Users/sc/git/singa/build/python/singa/singa_wrap.py", line 16, in swig_import_helper
return importlib.import_module('_singa_wrap')
File "/Users/sc/.pyenv/versions/3.6.6/lib/python3.6/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
ModuleNotFoundError: No module named '_singa_wrap'
```
I think it is because `/Users/sc/git/singa/build/python/singa/_singa_wrap.so` could not find `libdnnl.1.dylib`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685443203
This pull request **fixes 3 alerts** when merging 07460c8133b606f975edd963d4052bf9620796a0 into 178b107741081332fb51d908e87e7fa26b69779e - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-bf64c885095c8c9e5a692f8892183fc1cbc4bbd4)
**fixed alerts:**
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
nudles commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-686870409
why do you change _singa_wrap.so?
The test is CPP test. You should change libsinga.dylib.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685238267
# [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=h1) Report
> Merging [#786](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/178b107741081332fb51d908e87e7fa26b69779e?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #786 +/- ##
==========================================
+ Coverage 65.08% 65.21% +0.12%
==========================================
Files 86 104 +18
Lines 4786 12413 +7627
==========================================
+ Hits 3115 8095 +4980
- Misses 1671 4318 +2647
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.08% <ø> (?)` | |
| #singa-python | `65.29% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | `49.39% <0.00%> (ø)` | |
| [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | `66.55% <0.00%> (ø)` | |
| [snapshot.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-c25hcHNob3QucHk=) | `0.00% <0.00%> (ø)` | |
| [autograd.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | `89.99% <0.00%> (ø)` | |
| [proto/model\_pb2.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-cHJvdG8vbW9kZWxfcGIyLnB5) | `0.00% <0.00%> (ø)` | |
| [proto/core\_pb2.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-cHJvdG8vY29yZV9wYjIucHk=) | `0.00% <0.00%> (ø)` | |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | `75.19% <0.00%> (ø)` | |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | `0.00% <0.00%> (ø)` | |
| [data.py](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | `0.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/singa/pull/786/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=footer). Last update [178b107...d9981fa](https://codecov.io/gh/apache/singa/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #786: Fix a bug in github workflow (Native-MacOS) when using dnnl
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #786:
URL: https://github.com/apache/singa/pull/786#issuecomment-685229797
This pull request **introduces 9 alerts** and **fixes 16** when merging 71a9fd30e1af983b643b93f023c8cfd97751e321 into c5769f1cc8a53c1e849c97641d71221bd4fdb5d4 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-6f0573e6e608bc8d034969a386f2f46881b16ec5)
**new alerts:**
* 3 for Missing return statement
* 2 for Testing equality to None
* 1 for Duplication in regular expression character class
* 1 for Unused local variable
* 1 for Unused import
* 1 for Module is imported with 'import' and 'import from'
**fixed alerts:**
* 12 for Missing call to \_\_init\_\_ during object initialization
* 2 for Unreachable code
* 1 for Unnecessary pass
* 1 for Unused local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org