You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by prasanthj <gi...@git.apache.org> on 2018/06/02 02:28:10 UTC
[GitHub] orc pull request #276: ORC-373: Option to disable dictionary encoding
GitHub user prasanthj opened a pull request:
https://github.com/apache/orc/pull/276
ORC-373: Option to disable dictionary encoding
disables dictionary encoding at the time of string tree writer initialization.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prasanthj/orc master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #276
----
commit 90d83a11f1411df52712c267ea4949c4271c9828
Author: Prasanth Jayachandran <pr...@...>
Date: 2018-06-02T02:24:22Z
ORC-373: Option to disable dictionary encoding
----
---
[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding
Posted by damiencarol <gi...@git.apache.org>.
Github user damiencarol commented on the issue:
https://github.com/apache/orc/pull/276
@prasanthj no unit test?
---
[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding
Posted by prasanthj <gi...@git.apache.org>.
Github user prasanthj commented on the issue:
https://github.com/apache/orc/pull/276
@omalley could you please take a look?
---
[GitHub] orc pull request #276: ORC-373: Option to disable dictionary encoding
Posted by prasanthj <gi...@git.apache.org>.
Github user prasanthj closed the pull request at:
https://github.com/apache/orc/pull/276
---
[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding
Posted by prasanthj <gi...@git.apache.org>.
Github user prasanthj commented on the issue:
https://github.com/apache/orc/pull/276
@damiencarol added junit tests. my branches got messed up. So had to give another PR. #279
---
[GitHub] orc issue #276: ORC-373: Option to disable dictionary encoding
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/276
@prasanthj yeah, in general you should make a dev branch for the pull request (eg. prasanthj:orc-373). Then you can do a force-push to the branch to update the PR.
---