[GitHub] [hive] klcopp commented on a change in pull request #3102: HIVE-25977: Addendum

[GitBox <gi...@apache.org>]

klcopp commented on a change in pull request #3102:
URL: https://github.com/apache/hive/pull/3102#discussion_r832388105



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java
##########
@@ -401,7 +401,7 @@ private void addFile(Table t, Partition p, long minTxn, long maxTxn, int numReco
     switch (type) {
       case BASE: filename = AcidUtils.BASE_PREFIX + maxTxn + (visibilityId > 0 ? AcidUtils.VISIBILITY_PREFIX + visibilityId : ""); break;
       case LENGTH_FILE: // Fall through to delta
-      case DELTA: filename = makeDeltaDirName(minTxn, maxTxn); break;
+      case DELTA: filename = AcidUtils.addVisibilitySuffix(makeDeltaDirName(minTxn, maxTxn),visibilityId); break;

Review comment:
       This still isn't 100% true-to-life, since only compacted deltas have a visibility suffix, FWIW. Maybe could add a COMPACTED_DELTA type?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org