You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/10/03 05:37:32 UTC
[jira] Created: (WHIRR-109) Unit tests fail if there is no private
key found at ~/.ssh/id_rsa
Unit tests fail if there is no private key found at ~/.ssh/id_rsa
------------------------------------------------------------------
Key: WHIRR-109
URL: https://issues.apache.org/jira/browse/WHIRR-109
Project: Whirr
Issue Type: Bug
Reporter: Tom White
Fix For: 0.2.0
We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WHIRR-109) Unit tests fail if there is no private
key found at ~/.ssh/id_rsa
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White resolved WHIRR-109.
-----------------------------
Resolution: Fixed
I've just committed this. Thanks Adrian!
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch, WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-109) Unit tests fail if there is no
private key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917296#action_12917296 ]
Adrian Cole commented on WHIRR-109:
-----------------------------------
this requires generating a key and exporting it to PEM format. I'll take this.
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-109) Unit tests fail if there is no private
key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-109:
------------------------------
Issue Type: Improvement (was: Bug)
this isn't really a bug
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch, WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-109) Unit tests fail if there is no
private key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917310#action_12917310 ]
Adrian Cole commented on WHIRR-109:
-----------------------------------
patch available
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WHIRR-109) Unit tests fail if there is no private
key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole reassigned WHIRR-109:
---------------------------------
Assignee: Adrian Cole
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (WHIRR-109) Unit tests fail if there is no
private key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WHIRR-109 started by Adrian Cole.
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-109) Unit tests fail if there is no
private key found at ~/.ssh/id_rsa
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917365#action_12917365 ]
Tom White commented on WHIRR-109:
---------------------------------
Thanks for the patch - overall it looks good.
* KeyPair is only needed for tests so it could be in the test tree (we probably shouldn't expose it as a part of the public API).
* Instead of the System.err.println, a log statement would be better (see WHIRR-106).
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-109) Unit tests fail if there is no private
key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-109:
------------------------------
Attachment: WHIRR-109.patch
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-109) Unit tests fail if there is no private
key found at ~/.ssh/id_rsa
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cole updated WHIRR-109:
------------------------------
Attachment: WHIRR-109.patch
I originally hesitated to put KeyPair into the test archive as maven wasn't setup to inherit test dependencies. That said, I see you're point. I've changed the maven setup to allow test classes to be used in downstream modules, allowing KeyPair to be used in Cassandra, ZooKeeper, etc.
As for logging, I forgot to remove the system.err.println statements. Thanks for pointing that out.
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch, WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.