[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #53: [WIP] add protobuf schema evoluation

[GitBox <gi...@apache.org>]

MatrixHB commented on PR #53:
URL: https://github.com/apache/rocketmq-schema-registry/pull/53#issuecomment-1233039561

   @complone Hello, thank you very much for contributing this PR, but before you further optimize, I need to confirm whether you have any misunderstanding about the compatibility validation of protobuf? 
   The so-called compatibility validation here focuses on compatibility, that is, comparing the updated protobuf schema with the previous version of protobuf schema, whether its changes will make the production and consumption of messages incompatible.
   
   However, judging from the code you submitted, it seems to focus on the verification of fields, field value range, regular matching, etc. IMO, the schema registry does not intend to cover the logic of this part, which is more business oriented.
   
   If it's because I don't understand your original intention, we can continue to discuss it. Thank you very much. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org