[jira] [Commented] (CB-13316) Update documentation regarding browser quirks

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-13316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178241#comment-16178241 ] 

ASF GitHub Bot commented on CB-13316:
-------------------------------------

GitHub user andreszs opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/287

    CB-13316: (browser) Updated readme browser quirks

    Updated the Browser Quirks according to [CB-13316](https://issues.apache.org/jira/browse/CB-13316)
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    - [x] Browser
    
    ### What does this PR do?
    - [x] Updates README.md
    
    ### What testing has been done on this change?
    - [x] Tested with cordova-simulate on Chrome with CLI 6.5.0
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andreszs/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #287
    
----
commit 1b98692547651004c39f62074dc1dcea54919e70
Author: Andrés <10...@users.noreply.github.com>
Date:   2017-09-24T14:50:58Z

    Update README.md
    
    Updated the Browser Quirks according to https://issues.apache.org/jira/browse/CB-13316

----


> Update documentation regarding browser quirks
> ---------------------------------------------
>
>                 Key: CB-13316
>                 URL: https://issues.apache.org/jira/browse/CB-13316
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-plugin-camera
>    Affects Versions: Master, 2.4.1
>         Environment: CLI 6.5.0@browser 4.1.0
> Using [cordova-simulate|https://github.com/Microsoft/cordova-simulate] in Chrome
>            Reporter: Andres Zsogon
>              Labels: browser, readme
>
> According to the README, the only *Browser Quirk* is:
> {quote}Can only return photos as Base64-encoded image.{quote}
> However this is not the case from my testing. Instead, I get this result:
> {noformat}
> blob:http://localhost:8000/259e6e9e-bb2f-47d0-939d-51461bd7d47c
> {noformat}
> Also, the image is not resized, it's returned in its natural size.
> This is the {{options}} object used:
> {code:javascript}
> var options = {
>   quality: 100,
>   destinationType: Camera.DestinationType.FILE_URI,
>   sourceType: Camera.PictureSourceType.SAVEDPHOTOALBUM,
>   encodingType: Camera.EncodingType.JPEG,
>   mediaType: Camera.MediaType.PICTURE,
>   allowEdit: true,
>   correctOrientation: true,
>   targetHeight: 240,
>   targetWidth: 240
> }
> {code}
> Using {{Camera.DestinationType.DATA_URI}} does return a base64 encoded image but it *does not resize it* either, it returns in its original size.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org