[GitHub] [druid] rohangarg commented on a change in pull request #12127: Use ListFilteredVirtualColumn for left/fact table expression in join condition

[GitBox <gi...@apache.org>]

rohangarg commented on a change in pull request #12127:
URL: https://github.com/apache/druid/pull/12127#discussion_r781922668



##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java
##########
@@ -161,7 +161,9 @@ public static DruidQuery fromPartialQuery(
   )
   {
     final RelDataType outputRowType = partialQuery.leafRel().getRowType();
-    final VirtualColumnRegistry virtualColumnRegistry = VirtualColumnRegistry.create(sourceRowSignature);
+    final VirtualColumnRegistry virtualColumnRegistry = plannerContext.getVirtualColumnRegistry() == null
+                                                        ? VirtualColumnRegistry.create(sourceRowSignature)
+                                                        : plannerContext.getVirtualColumnRegistry();

Review comment:
       As discussed offline, the new changes are now safe wrt the usage of registry between druid queries

##########
File path: processing/src/main/java/org/apache/druid/query/JoinDataSource.java
##########
@@ -221,6 +222,16 @@ public boolean isConcrete()
     return false;
   }
 
+  public Set<String> getVirtualColumnCandidates()

Review comment:
       Yes, added it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org