You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/01/13 11:38:26 UTC

[GitHub] [incubator-eventmesh] Roc-00 opened a new pull request #712: Fix trace bug

Roc-00 opened a new pull request #712:
URL: https://github.com/apache/incubator-eventmesh/pull/712


   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
   
     - Fill out the template below to describe the changes contributed by the pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes ISSUE #<XXX>`.)
   -->
   
   
   
   ### Motivation
   
   When spanExporter is set to Zipkin, if Zipkin is not running, an error will be reported when running the example module
   ![3b3a065695a0cd1ae0231d54580e5a5](https://user-images.githubusercontent.com/84842773/149323103-03386762-ab3a-48c6-8fa1-b2a8fae992c4.jpg)
   
   
   ### Modifications
   
   Set log as the default spanExporter.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] Roc-00 commented on pull request #712: Fix trace bug

Posted by GitBox <gi...@apache.org>.
Roc-00 commented on pull request #712:
URL: https://github.com/apache/incubator-eventmesh/pull/712#issuecomment-1012110379


   > @Roc-00 Good Job, follow the [EventMesh contribution guide](https://github.com/apache/incubator-eventmesh/blob/master/CONTRIBUTING.md), you should open an issue first.
   
   got it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 merged pull request #712: [ISSUE #713] Fix trace bug

Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #712:
URL: https://github.com/apache/incubator-eventmesh/pull/712


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #712: Fix trace bug

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #712:
URL: https://github.com/apache/incubator-eventmesh/pull/712#issuecomment-1012100256


   @Roc-00 Good Job, follow the [EventMesh contribution guide](https://github.com/apache/incubator-eventmesh/blob/master/CONTRIBUTING.md), you should open an issue first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org