You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/23 11:40:12 UTC
[GitHub] [incubator-druid] leventov commented on a change in pull request
#7138: 'core' ORC extension
leventov commented on a change in pull request #7138: 'core' ORC extension
URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r286900651
##########
File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java
##########
@@ -0,0 +1,239 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.data.input.orc;
+
+import it.unimi.dsi.fastutil.objects.Object2IntMap;
+import it.unimi.dsi.fastutil.objects.Object2IntOpenHashMap;
+import org.apache.druid.java.util.common.DateTimes;
+import org.apache.druid.java.util.common.StringUtils;
+import org.apache.hadoop.hive.serde2.io.DateWritable;
+import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
+import org.apache.hadoop.io.BooleanWritable;
+import org.apache.hadoop.io.ByteWritable;
+import org.apache.hadoop.io.BytesWritable;
+import org.apache.hadoop.io.DoubleWritable;
+import org.apache.hadoop.io.FloatWritable;
+import org.apache.hadoop.io.IntWritable;
+import org.apache.hadoop.io.LongWritable;
+import org.apache.hadoop.io.ShortWritable;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.io.WritableComparable;
+import org.apache.orc.TypeDescription;
+import org.apache.orc.mapred.OrcList;
+import org.apache.orc.mapred.OrcMap;
+import org.apache.orc.mapred.OrcStruct;
+import org.apache.orc.mapred.OrcTimestamp;
+
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class OrcStructConverter
+{
+ @Nonnull
+ private static List<Object> convertList(TypeDescription fieldDescription, OrcList orcList, boolean binaryAsString)
+ {
+ // if primitive list, convert primitives
+ TypeDescription listType = fieldDescription.getChildren().get(0);
+ if (listType.getCategory().isPrimitive()) {
+ return (List<Object>) orcList.stream()
+ .map(li -> convertPrimitive(listType, (WritableComparable) li, binaryAsString))
+ .collect(Collectors.toList());
+ }
+ return new ArrayList<Object>(orcList);
+ }
+
+ private static Map<Object, Object> convertMap(
+ TypeDescription fieldDescription,
+ OrcMap<? extends WritableComparable, ? extends WritableComparable> map,
+ boolean binaryAsString
+ )
+ {
+ Map<Object, Object> converted = new HashMap<>();
+ TypeDescription keyDescription = fieldDescription.getChildren().get(0);
+ TypeDescription valueDescription = fieldDescription.getChildren().get(1);
+ for (WritableComparable key : map.navigableKeySet()) {
+ Object newKey = convertPrimitive(keyDescription, key, binaryAsString);
+ if (valueDescription.getCategory().isPrimitive()) {
+ converted.put(newKey, convertPrimitive(valueDescription, map.get(key), binaryAsString));
+ } else {
+ converted.put(newKey, map.get(key));
+ }
+ }
+ return converted;
+ }
+
+ private static Object convertPrimitive(TypeDescription fieldDescription, WritableComparable field, boolean binaryAsString)
+ {
+ /*
+ ORC TYPE WRITABLE TYPE
+ binary org.apache.hadoop.io.BytesWritable
+ bigint org.apache.hadoop.io.LongWritable
+ boolean org.apache.hadoop.io.BooleanWritable
+ char org.apache.hadoop.io.Text
+ date org.apache.hadoop.hive.serde2.io.DateWritable
+ decimal org.apache.hadoop.hive.serde2.io.HiveDecimalWritable
+ double org.apache.hadoop.io.DoubleWritable
+ float org.apache.hadoop.io.FloatWritable
+ int org.apache.hadoop.io.IntWritable
+ smallint org.apache.hadoop.io.ShortWritable
+ string org.apache.hadoop.io.Text
+ timestamp org.apache.orc.mapred.OrcTimestamp
+ tinyint org.apache.hadoop.io.ByteWritable
+ varchar org.apache.hadoop.io.Text
+ */
+ switch (fieldDescription.getCategory()) {
+ case STRING:
+ case CHAR:
+ case VARCHAR:
+ return ((Text) field).toString();
+ case BOOLEAN:
+ return ((BooleanWritable) field).get();
+ case BYTE:
+ return ((ByteWritable) field).get();
+ case SHORT:
+ return ((ShortWritable) field).get();
+ case INT:
+ return ((IntWritable) field).get();
+ case LONG:
+ return ((LongWritable) field).get();
+ case FLOAT:
+ return ((FloatWritable) field).get();
+ case DOUBLE:
+ return ((DoubleWritable) field).get();
+ case DECIMAL:
+ return ((HiveDecimalWritable) field).getHiveDecimal().doubleValue();
+ case TIMESTAMP:
+ return ((OrcTimestamp) field).getTime();
+ case DATE:
+ return DateTimes.utc(((DateWritable) field).get().getTime());
+ case BINARY:
+ byte[] bytes = ((BytesWritable) field).getBytes();
+ if (binaryAsString) {
+ return StringUtils.fromUtf8(bytes);
+ } else {
+ return bytes;
+ }
+ default:
+ return null;
+ }
+ }
+
+ private boolean binaryAsString;
+ private Object2IntMap<String> fieldIndexCache;
+
+ OrcStructConverter(boolean binaryAsString)
+ {
+ this.binaryAsString = binaryAsString;
+ }
+
+ /**
+ * Convert a orc struct field of the "root" {@link OrcStruct} that represents the "row". This method has a cache of
+ * field names to field index that is ONLY valid for this {@link OrcStruct}, and should not be used for
+ * nested {@link OrcStruct} fields of the row. Looks up field index by field name, and delegates to
+ * {@link OrcStructConverter#convertField(OrcStruct, int)}.
+ */
+ @Nullable
+ Object convertRootField(OrcStruct struct, String fieldName)
+ {
+ // this cache is only valid for the root level, to skip the indexOf on fieldNames to get the fieldIndex.
+ TypeDescription schema = struct.getSchema();
+ final List<String> fields = schema.getFieldNames();
+ if (fieldIndexCache == null) {
+ fieldIndexCache = new Object2IntOpenHashMap<>(fields.size());
+ for (int i = 0; i < fields.size(); i++) {
+ fieldIndexCache.put(fields.get(i), i);
+ }
+ }
+ WritableComparable wc = struct.getFieldValue(fieldName);
Review comment:
Variable is not used. I assume that calling `struct.getFieldValue()` doesn't have desirable side effects. I'll delete this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org