You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/20 14:29:28 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request #7866: Optimize PostgreSQL g4 grammar, remove underline.
dongzl opened a new pull request #7866:
URL: https://github.com/apache/shardingsphere/pull/7866
For #7856 .
Changes proposed in this pull request:
- Optimize PostgreSQL g4 grammar, remove underline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #7866: Optimize PostgreSQL g4 grammar, remove underline.
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #7866:
URL: https://github.com/apache/shardingsphere/pull/7866#discussion_r509089375
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -1326,20 +1369,16 @@ dataTypeLength
: LP_ NUMBER_ (COMMA_ NUMBER_)? RP_
;
-characterSet_
- : (CHARACTER | CHAR) SET EQ_? ignoredIdentifier_
- ;
-
-collateClause_
- : COLLATE EQ_? (STRING_ | ignoredIdentifier_)
Review comment:
@jingshanglu , This file already has a rule, called `collateClause`. If rename `collateClause_` to `collateClause` directly, it will cause conflict.
I compare `collateClause_` and `collateClause`, merge them into one `collateClause`.
Please check it for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #7866: Optimize PostgreSQL g4 grammar, remove underline.
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #7866:
URL: https://github.com/apache/shardingsphere/pull/7866#discussion_r509071750
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4
##########
@@ -1326,20 +1369,16 @@ dataTypeLength
: LP_ NUMBER_ (COMMA_ NUMBER_)? RP_
;
-characterSet_
- : (CHARACTER | CHAR) SET EQ_? ignoredIdentifier_
- ;
-
-collateClause_
- : COLLATE EQ_? (STRING_ | ignoredIdentifier_)
Review comment:
@dongzl Why delete this rule？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu merged pull request #7866: Optimize PostgreSQL g4 grammar, remove underline.
Posted by GitBox <gi...@apache.org>.
jingshanglu merged pull request #7866:
URL: https://github.com/apache/shardingsphere/pull/7866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org