You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Sean Cooper <se...@gmail.com> on 2011/10/17 16:30:29 UTC
Review Request: RAVE-71 - Added widget ratings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/
-----------------------------------------------------------
Review request for rave.
Summary
-------
Added widget ratings to the portal
This addresses bug RAVE-71.
https://issues.apache.org/jira/browse/RAVE-71
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1185152
trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1185152
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1185152
trunk/rave-portal-resources/src/main/resources/messages.properties 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
Diff: https://reviews.apache.org/r/2402/diff
Testing
-------
Thanks,
Sean
Re: Review Request: RAVE-71 - Added widget ratings
Posted by Jasha Joachimsthal <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/#review2787
-----------------------------------------------------------
Ship it!
Applied your patch with some changes. Iterating over a List of WidgetRatings per Widget can get very expensive if thousands of users rate a widget so I created a new repository + service that get the WidgetRating for a specific widget/user combination.
I saw that the deleteWidgetRating is not in use yet and it's not visible what the rating of a widget is.
- Jasha
On 2011-10-18 16:57:40, Sean Cooper wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2402/
> -----------------------------------------------------------
>
> (Updated 2011-10-18 16:57:40)
>
>
> Review request for rave.
>
>
> Summary
> -------
>
> Added widget ratings to the portal
>
>
> This addresses bug RAVE-71.
> https://issues.apache.org/jira/browse/RAVE-71
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1185152
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java PRE-CREATION
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1185152
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1185152
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1185152
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1185152
> trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1185152
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java PRE-CREATION
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1185152
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java 1185152
> trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1185152
> trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1185152
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1185152
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1185152
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1185152
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1185152
> trunk/rave-portal-resources/src/main/resources/messages.properties 1185152
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp 1185152
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1185152
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
> trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
>
> Diff: https://reviews.apache.org/r/2402/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sean
>
>
Re: Review Request: RAVE-71 - Added widget ratings
Posted by Sean Cooper <se...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2402/
-----------------------------------------------------------
(Updated 2011-10-18 16:57:40.314623)
Review request for rave.
Changes
-------
Javascript update... IE changes the states of the button and radio values prior to firing the JQuery 'change' event so logic has been updated to assume the user had the opposing rating to the newly selected rating and subtracts one from the opposing rating total (still verifying that it is at least '0')
Summary
-------
Added widget ratings to the portal
This addresses bug RAVE-71.
https://issues.apache.org/jira/browse/RAVE-71
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Widget.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/WidgetRating.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/util/WidgetStatistics.java PRE-CREATION
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/WidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/WidgetService.java 1185152
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultWidgetService.java 1185152
trunk/rave-components/rave-core/src/main/resources/META-INF/persistence.xml 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetRatingTest.java PRE-CREATION
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/model/WidgetTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/repository/JpaWidgetRepositoryTest.java 1185152
trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/service/WidgetServiceTest.java 1185152
trunk/rave-components/rave-core/src/test/resources/test_data.sql 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/api/rest/WidgetApi.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/WidgetStoreController.java 1185152
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/api/rest/WidgetApiTest.java 1185152
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/WidgetStoreControllerTest.java 1185152
trunk/rave-portal-resources/src/main/resources/messages.properties 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/store.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/widget.jsp 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1185152
trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1185152
Diff: https://reviews.apache.org/r/2402/diff
Testing
-------
Thanks,
Sean