You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/11/15 20:35:25 UTC
[kudu-CR] docs: add docs for maintenance mode
Hello Adar Dembo, Priyanka Chheda,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14718
to review the following change.
Change subject: docs: add docs for maintenance mode
......................................................................
docs: add docs for maintenance mode
A staged version can be found here:
https://github.com/andrwng/kudu/blob/docs_maintenance_mode/docs/administration.adoc#minimizing_cluster_disruption_during_temporary_single_ts_downtime
Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
---
M docs/administration.adoc
1 file changed, 34 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14718/1
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
[kudu-CR] docs: add docs for maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Priyanka Chheda,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14718
to look at the new patch set (#2).
Change subject: docs: add docs for maintenance mode
......................................................................
docs: add docs for maintenance mode
A staged version can be found here:
https://github.com/andrwng/kudu/blob/docs_maintenance_mode/docs/administration.adoc#minimizing_cluster_disruption_during_temporary_single_ts_downtime
Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14718/2
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
[kudu-CR] docs: add docs for maintenance mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
Patch Set 2: Code-Review+1
(8 comments)
A few nits.
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1468
PS2, Line 1468: maintenance
So, is it 'maintenance' or 'maintenance mode', or 'maintenance state'?
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1469
PS2, Line 1469: will not be
nit: are not
I think that using the present tense simplifies this sentence.
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1472
PS2, Line 1472: a
its
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1473
PS2, Line 1473: will be
is
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1485
PS2, Line 1485: will show up
nit: is shown
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1486
PS2, Line 1486: ksck
kudu cluster ksck
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1486
PS2, Line 1486: leader
drop
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1487
PS2, Line 1487: the following can be run
nit: run the following
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 02:23:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs for maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Priyanka Chheda,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14718
to look at the new patch set (#3).
Change subject: docs: add docs for maintenance mode
......................................................................
docs: add docs for maintenance mode
A staged version can be found here:
https://github.com/andrwng/kudu/blob/docs_maintenance_mode/docs/administration.adoc#minimizing_cluster_disruption_during_temporary_single_ts_downtime
Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14718/3
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
[kudu-CR] docs: add docs for maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14718/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/14718/1/docs/administration.adoc@1517
PS1, Line 1517: NOTE: On Kudu versions prior to 1.8, the `--force` flag must be provided in the above
> In the rendered doc, it looks like this could apply to both MM and non-MM a
Done
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 00:58:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs for maintenance mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 01:02:48 +0000
Gerrit-HasComments: No
[kudu-CR] docs: add docs for maintenance mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14718/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/14718/1/docs/administration.adoc@1517
PS1, Line 1517: NOTE: On Kudu versions prior to 1.8, the `--force` flag must be provided in the above
In the rendered doc, it looks like this could apply to both MM and non-MM approaches.
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 00:49:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: add docs for maintenance mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 03:02:53 +0000
Gerrit-HasComments: No
[kudu-CR] docs: add docs for maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
docs: add docs for maintenance mode
A staged version can be found here:
https://github.com/andrwng/kudu/blob/docs_maintenance_mode/docs/administration.adoc#minimizing_cluster_disruption_during_temporary_single_ts_downtime
Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Reviewed-on: http://gerrit.cloudera.org:8080/14718
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 8 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
[kudu-CR] docs: add docs for maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14718 )
Change subject: docs: add docs for maintenance mode
......................................................................
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1468
PS2, Line 1468: maintenance
> So, is it 'maintenance' or 'maintenance mode', or 'maintenance state'?
To be consistent with the tooling enum, "maintenance mode" is correct enough.
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1469
PS2, Line 1469: will not be
> nit: are not
Done
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1472
PS2, Line 1472: a
> its
Done
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1473
PS2, Line 1473: will be
> is
Done
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1485
PS2, Line 1485: will show up
> nit: is shown
Done
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1486
PS2, Line 1486: leader
> drop
Done
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1486
PS2, Line 1486: ksck
> kudu cluster ksck
Done
http://gerrit.cloudera.org:8080/#/c/14718/2/docs/administration.adoc@1487
PS2, Line 1487: the following can be run
> nit: run the following
Done
--
To view, visit http://gerrit.cloudera.org:8080/14718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b9eddc1d4d4a4e4cb149058fc6d6f438e47f1f
Gerrit-Change-Number: 14718
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pc...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 02:31:59 +0000
Gerrit-HasComments: Yes