You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "jongyoul (via GitHub)" <gi...@apache.org> on 2026/06/06 01:46:17 UTC
[PR] Bump build to Ruby 3.3.5 and update Dependabot dependencies [zeppelin-site]
jongyoul opened a new pull request, #59:
URL: https://github.com/apache/zeppelin-site/pull/59
## Summary
Upgrade the Docker build image to **Ruby 3.3.5** and apply the pending Dependabot dependency bumps in a single change.
Ruby must move off `3.0.6` because `nokogiri 1.19.3` requires Ruby `>= 3.2` and `activesupport 7.2.3.1` (already pinned in the lockfile) requires Ruby `>= 3.1`. The current `ruby:3.0.6` image therefore can no longer build the site, so the dependency bumps and the Ruby upgrade have to land together.
## Changes
**Root site** (`Gemfile`, `Gemfile.lock`, `Dockerfile`)
- Docker image `ruby:3.0.6` → `ruby:3.3.5`
- nokogiri `1.15.4` → `1.19.3`
- faraday `2.14.1` → `2.14.2`
- addressable `2.8.5` → `2.9.0`
**docs/0.12.0** (already-published static output — lockfile only, HTML untouched)
- nokogiri `1.15.4` → `1.19.3`
- addressable `2.8.7` → `2.9.0`
- rexml `3.3.8` → `3.4.4`
**helium GitHub Action** (`package-lock.json`, `lockfileVersion: 2` preserved)
- follow-redirects `1.15.6` → `1.16.0`
- ajv `6.12.6` → `6.15.0`
- underscore `1.13.7` → `1.13.8`
## Verification
All builds run inside Docker:
- `bundle install` + `jekyll build` succeed on Ruby 3.3.5
- `npm ci` succeeds for the helium action
## Closes
Closes #57, #53, #50, #54, #51, #33, #52, #49, #47
> #58 is intentionally left out and will be merged later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump build to Ruby 3.3.5 and update Dependabot dependencies [zeppelin-site]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #59:
URL: https://github.com/apache/zeppelin-site/pull/59#discussion_r3366321847
##########
docs/0.12.0/Gemfile:
##########
@@ -17,7 +17,7 @@ source 'https://rubygems.org'
gem 'github-pages'
gem 'redcarpet'
gem 'jekyll-twitter-plugin'
-gem 'nokogiri', '1.15.4'
+gem 'nokogiri', '1.19.3'
gem 'mini_portile2', '2.8.4'
Review Comment:
The PR description says `docs/0.12.0` should be “lockfile only”, but this change updates `docs/0.12.0/Gemfile` as well (pins `nokogiri` to 1.19.3). Either update the PR description to reflect that the Gemfile is intentionally changed, or revert this Gemfile change (and the corresponding lockfile bump) if the intent is truly lockfile-only for already-published docs.
##########
Dockerfile:
##########
@@ -1,5 +1,5 @@
# Use the latest official Ruby runtime as a parent image
-FROM ruby:3.0.6
+FROM ruby:3.3.5
Review Comment:
`Gemfile.lock` was generated with Bundler 4.0.13, but the Docker image installs an unpinned Bundler (`gem install bundler`). This makes the Docker build non-reproducible and can fail if a future Bundler release is incompatible or if the installed Bundler version is < 4 (which would refuse this lockfile). Pin the Bundler version used in the image to the lockfile’s `BUNDLED WITH` version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade build to Ruby 3.3.5, consolidate Dependabot bumps, and remove vendored docs Gemfiles [zeppelin-site]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul closed pull request #59: Upgrade build to Ruby 3.3.5, consolidate Dependabot bumps, and remove vendored docs Gemfiles
URL: https://github.com/apache/zeppelin-site/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org