[GitHub] [maven-surefire] papegaaij commented on a change in pull request #389: [SUREFIRE-1935] Upgrade to JUnit Platform 1.8, start Launcher via LauncherSession

[GitBox <gi...@apache.org>]

papegaaij commented on a change in pull request #389:
URL: https://github.com/apache/maven-surefire/pull/389#discussion_r788098364



##########
File path: surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
##########
@@ -231,6 +225,21 @@ private void execute( TestsToRun testsToRun, RunListenerAdapter adapter )
                 } );
         }
     }
+    
+    private void closeLauncher()
+    {
+        if ( launcher instanceof AutoCloseable )
+        {
+            try
+            {
+                ( (AutoCloseable) launcher ).close();
+            }
+            catch ( Exception e )
+            {
+                throw new SurefireReflectionException( e );

Review comment:
       `SurefireReflectionException` only has one constructor, the one taking a `Throwable cause`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org