[GitHub] [kibble] turbaszek commented on a change in pull request #89: Kibble cli init

[GitBox <gi...@apache.org>]

turbaszek commented on a change in pull request #89:
URL: https://github.com/apache/kibble/pull/89#discussion_r513230672



##########
File path: kibble/__main__.py
##########
@@ -14,11 +14,24 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+import click
+from version import kibble_version

Review comment:
       Also please use absolute import `from kibble.version import kibble_version`:
   ```
   ➜ kibble version
   Traceback (most recent call last):
     File "/Users/turbaszek/.pyenv/versions/kibble/bin/kibble", line 33, in <module>
       sys.exit(load_entry_point('apache-kibble', 'console_scripts', 'kibble')())
     File "/Users/turbaszek/.pyenv/versions/kibble/bin/kibble", line 25, in importlib_load_entry_point
       return next(matches).load()
     File "/Users/turbaszek/.pyenv/versions/3.8.0/lib/python3.8/importlib/metadata.py", line 75, in load
       module = import_module(match.group('module'))
     File "/Users/turbaszek/.pyenv/versions/3.8.0/lib/python3.8/importlib/__init__.py", line 127, in import_module
       return _bootstrap._gcd_import(name[level:], package, level)
     File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
     File "<frozen importlib._bootstrap>", line 991, in _find_and_load
     File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
     File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
     File "<frozen importlib._bootstrap_external>", line 783, in exec_module
     File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
     File "/Users/turbaszek/code/kibble/kibble/__main__.py", line 18, in <module>
       from version import kibble_version
   ModuleNotFoundError: No module named 'version'
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org