You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/26 07:41:19 UTC
[GitHub] [skywalking-python] YueLangsugar opened a new pull request, #209: The context of obtaining span is modified, which will affect the remo…
YueLangsugar opened a new pull request, #209:
URL: https://github.com/apache/skywalking-python/pull/209
…val of span in tornado request link
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a CHANGELOG entry for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
- [ ] Rebuild the `Plugins.md` documentation by running `tools/doc/plugin_doc_gen.py`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] YueLangsugar closed pull request #209: Fix multiple requests for the same traceId in Tornado
Posted by GitBox <gi...@apache.org>.
YueLangsugar closed pull request #209: Fix multiple requests for the same traceId in Tornado
URL: https://github.com/apache/skywalking-python/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] YueLangsugar commented on pull request #209: Fix multiple requests for the same traceId in Tornado
Posted by GitBox <gi...@apache.org>.
YueLangsugar commented on PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#issuecomment-1139225575
> Please also update the `CHANGELOG.md` to reflect your fix intentions.
I've updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] YueLangsugar commented on pull request #209: Fix multiple requests for the same traceId in Tornado
Posted by GitBox <gi...@apache.org>.
YueLangsugar commented on PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#issuecomment-1139225199
> Please update your pull request title and text body, it's not readable.
ok, It's modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #209: The context of obtaining span is modified, which will affect the remo…
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#issuecomment-1138786548
Please update your pull request title and text body, it's not readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #209: The context of obtaining span is modified, which will affect the remo…
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#issuecomment-1138799463
Please also update the `CHANGELOG.md` to reflect your fix intentions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] YueLangsugar commented on pull request #209: Fix multiple requests for the same traceId in Tornado
Posted by GitBox <gi...@apache.org>.
YueLangsugar commented on PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#issuecomment-1139233729
> This patch doesn't make sense, it fixes (maybe) issues in tornado but breaks many other things, @YueLangsugar did you read the reply from @Superskyyy in [apache/skywalking#9133](https://github.com/apache/skywalking/discussions/9133#discussioncomment-2823798)?
I've read it, but I don't think it helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #209: Fix multiple requests for the same traceId in Tornado
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#issuecomment-1139236646
> > This patch doesn't make sense, it fixes (maybe) issues in tornado but breaks many other things, @YueLangsugar did you read the reply from @Superskyyy in [apache/skywalking#9133](https://github.com/apache/skywalking/discussions/9133#discussioncomment-2823798)?
>
> I've read it, but I don't think it helps.
Please, let's discuss and have a consensus first in https://github.com/apache/skywalking/discussions/9133 , I don't think you can modify something but "you don't know why". You face issues in Tornado plugin but you are modifying the agent core, this doesn't make sense to me, and it may bring side effects that you are unaware of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on a diff in pull request #209: Fix multiple requests for the same traceId in Tornado
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #209:
URL: https://github.com/apache/skywalking-python/pull/209#discussion_r883227553
##########
CHANGELOG.md:
##########
@@ -10,6 +10,7 @@
- Drop support for flask 1.x due to dependency issue in Jinja2 and EOL (#195)
- Fixes:
+ - Fix the problem of multiple requests for the same traceId in Tornado framework (#9133)
Review Comment:
```suggestion
- Fix the problem of multiple requests for the same traceId in Tornado framework (#209)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org