You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by takezoe <gi...@git.apache.org> on 2017/02/14 17:00:46 UTC
[GitHub] incubator-predictionio pull request #347: Unit is not Unit value
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/347
Unit is not Unit value
`Unit` is not Unit value. `()` is an only value of Unit type in Scala.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio unit-value
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #347
----
commit d7e2ea053986fa86f2db613167171f7198c3df9b
Author: Naoki Takezoe <ta...@gmail.com>
Date: 2017-02-14T16:56:47Z
Unit is not Unit value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #347: Unit is not Unit value
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/347
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #347: Unit is not Unit value
Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/347#discussion_r101088786
--- Diff: core/src/main/scala/org/apache/predictionio/controller/Engine.scala ---
@@ -222,7 +222,7 @@ class Engine[TD, EI, PD, Q, P, A](
val models = algorithms.zip(persistedModels).map { case (algo, m) =>
m match {
- case Unit => algo.trainBase(sc, pd)
+ case () => algo.trainBase(sc, pd)
--- End diff --
In particular, maybe this case clause doesn't match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #347: Unit is not Unit value
Posted by marevol <gi...@git.apache.org>.
Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/347
@dszeto Could you check and merge this pull request?
He is my co-worker and Scala expert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #347: Unit is not Unit value
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/347
Thanks for your reminder @marevol . I was planning to do so after fixing integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---