You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/08 11:35:01 UTC

[GitHub] [iceberg] pPanda-beta commented on issue #2301: Lock remains forever if HiveTableOperations gets killed (direct process shutdown - no signals) after lock is acquired 

pPanda-beta commented on issue #2301:
URL: https://github.com/apache/iceberg/issues/2301#issuecomment-792695001


   @pvary @marton-bod 
   Thanks for the suggestion. 
   I've gone through their implementation.  
   
   This does cleanup via: 
   1. https://github.com/apache/hive/blob/8190d2be7b7165effa62bd21b7d60ef81fb0e4af/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidHouseKeeperService.java#L60
   
   2. https://github.com/apache/hive/blob/8190d2be7b7165effa62bd21b7d60ef81fb0e4af/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L4403
   
   and 
   
   3. https://github.com/apache/hive/blob/8190d2be7b7165effa62bd21b7d60ef81fb0e4af/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L3633-L3636
   
   
   But I believe ALL OF THIS WONT WORK: 
   **cause iceberg does not create transactions before creating the locks**.
   https://github.com/apache/iceberg/blob/a7901992c252bb28d10686ef24c1de788c90d663/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L322-L329
   
   This is more like a transaction less lock 😭 . So the lifecycle needs to be maintained via iceberg only.
   
   Also  I would insist approaches which are heavily involving hive metastore features only, acid has mostly came from a hive feature. In modern days no one even installs hive. People mostly use spark/presto on top of HMS.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org