[GitHub] [incubator-iotdb] SolomonAnn commented on a change in pull request #430: [IOTDB-193]Create schema automatically

[GitBox <gi...@apache.org>]

SolomonAnn commented on a change in pull request #430: [IOTDB-193]Create schema automatically
URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r334953104
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/utils/DeviceIdCache.java
 ##########
 @@ -0,0 +1,53 @@
+package org.apache.iotdb.db.utils;
+
+import org.apache.iotdb.db.exception.PathErrorException;
+import org.apache.iotdb.db.exception.StorageGroupException;
+import org.apache.iotdb.tsfile.exception.cache.CacheException;
+
+import java.util.List;
+import java.util.concurrent.CopyOnWriteArrayList;
+
+public abstract class DeviceIdCache {
 
 Review comment:
   I'm confused that whether I should use `mNodeCache `directly because its key is just `deviceId`. However, if I choose to use `mNodeCache`, I will have trouble with handling exceptions since I need `PathErrorException `and `StorageGroupException` to distinguish two different cases while `mNodeCache` throws `CacheException` in any case. Do you have any suggestions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services