You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/03/20 06:42:52 UTC

[GitHub] [incubator-paimon] TyrantLucifer opened a new pull request, #658: [PIP][Connector][Spark] Extract SparkInputPartitionReader from paimon spark connector

TyrantLucifer opened a new pull request, #658:
URL: https://github.com/apache/incubator-paimon/pull/658

   Extract SparkInputPartitionReader from paimon spark connector
   
   ### Purpose
   
   Optimize code structure
   
   ### Tests
   
   *(List UT and IT cases to verify this change)*
   
   ### API and Format 
   
   *(Does this change affect API or storage format)*
   
   ### Documentation
   
   *(Does this change introduce a new feature)*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] TyrantLucifer commented on pull request #658: [spark] Extract SparkInputPartitionReader from paimon spark connector

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #658:
URL: https://github.com/apache/incubator-paimon/pull/658#issuecomment-1477322243

   > > 2. t
   > 
   > Thanks for your reply and explanation. I will merge this. But this is not a bad mark for an anonymous internal class, and we would not recommend not using anonymous internal classes. I think in most moments it's just a matter of personal preference.
   
   Thank you for your good advice. I will avoid this problem in the future and try to contribute other useful codes.:wink:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on pull request #658: [spark] Extract SparkInputPartitionReader from paimon spark connector

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #658:
URL: https://github.com/apache/incubator-paimon/pull/658#issuecomment-1477316419

   > 2\. t
   
   Thanks for your reply and explanation. I will merge this. But this is not a bad mark for an anonymous internal class, and we would not recommend not using anonymous internal classes.
   I think in most moments it's just a matter of personal preference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] TyrantLucifer commented on pull request #658: [spark] Extract SparkInputPartitionReader from paimon spark connector

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #658:
URL: https://github.com/apache/incubator-paimon/pull/658#issuecomment-1477200654

   > Hi @TyrantLucifer , thanks for your contribution, can you explain the disadvantages of anonymous internal classes?
   
   Thank you for your reply. There are two benefits to converting an internal anonymous class to a regular entity class:
   
   1. Improved code readability and maintainability: Using an explicit entity class with a well-defined name and a clear purpose makes it easier for other developers to understand the code's purpose and functionality. This can also make it easier to maintain the code over time.
   
   2. Enhanced code reusability: By separating the anonymous class into a separate entity class, the class can be reused in other parts of the codebase, potentially reducing code duplication and improving overall code quality.
   
   Of course, from a performance perspective, there is no difference between the two approaches.
   
   What do you think about it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on pull request #658: [spark] Extract SparkInputPartitionReader from paimon spark connector

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #658:
URL: https://github.com/apache/incubator-paimon/pull/658#issuecomment-1477183936

   Hi @TyrantLucifer , thanks for your contribution, can you explain the disadvantages of anonymous internal classes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi merged pull request #658: [spark] Extract SparkInputPartitionReader from paimon spark connector

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #658:
URL: https://github.com/apache/incubator-paimon/pull/658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org