You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/06 01:55:09 UTC
[GitHub] [apisix] moonming opened a new pull request #2003: rocks: use tag instead of branch.
moonming opened a new pull request #2003:
URL: https://github.com/apache/apisix/pull/2003
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
fix https://github.com/apache/apisix/pull/1872/, which not using the right way to install from luarocks.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2003: rocks: use tag instead of branch.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2003:
URL: https://github.com/apache/apisix/pull/2003#issuecomment-669644606
> Apache APISIX was an incubator project until version 1.4.1, we don't have to change the historical version Thanks, Ming Wen Twitter: _WenMing nic-chen <no...@github.com> 于2020年8月6日周四 上午10:18写道：
> […](#)
> ***@***.**** commented on this pull request. ------------------------------ In rockspec/apisix-0.9-0.rockspec <[#2003 (comment)](https://github.com/apache/apisix/pull/2003#discussion_r466105866)>: > @@ -24,7 +24,7 @@ source = { } description = { - summary = "Apache APISIX is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.", + summary = "Apache APISIX(incubating) is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.", we could remove incubating now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <[#2003 (review)](https://github.com/apache/apisix/pull/2003#pullrequestreview-462141944)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJZBK65VKNF7ALNXKQGQILR7IHHXANCNFSM4PWC5F6Q> .
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #2003: rocks: use tag instead of branch.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #2003:
URL: https://github.com/apache/apisix/pull/2003#discussion_r466105866
##########
File path: rockspec/apisix-0.9-0.rockspec
##########
@@ -24,7 +24,7 @@ source = {
}
description = {
- summary = "Apache APISIX is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.",
+ summary = "Apache APISIX(incubating) is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.",
Review comment:
we could remove incubating now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2003: rocks: use tag instead of branch.
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2003:
URL: https://github.com/apache/apisix/pull/2003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2003: rocks: use tag instead of branch.
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2003:
URL: https://github.com/apache/apisix/pull/2003#issuecomment-669643679
Apache APISIX was an incubator project until version 1.4.1, we don't have
to change the historical version
Thanks,
Ming Wen
Twitter: _WenMing
nic-chen <no...@github.com> 于2020年8月6日周四 上午10:18写道：
> *@nic-chen* commented on this pull request.
> ------------------------------
>
> In rockspec/apisix-0.9-0.rockspec
> <https://github.com/apache/apisix/pull/2003#discussion_r466105866>:
>
> > @@ -24,7 +24,7 @@ source = {
> }
>
> description = {
> - summary = "Apache APISIX is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.",
> + summary = "Apache APISIX(incubating) is a cloud-native microservices API gateway, delivering the ultimate performance, security, open source and scalable platform for all your APIs and microservices.",
>
> we could remove incubating now.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/apisix/pull/2003#pullrequestreview-462141944>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK65VKNF7ALNXKQGQILR7IHHXANCNFSM4PWC5F6Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org