You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/06/01 22:07:00 UTC

[jira] [Commented] (AIRFLOW-2504) Airflow UI Auditing - log username show extra filter

    [ https://issues.apache.org/jira/browse/AIRFLOW-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498632#comment-16498632 ] 

ASF subversion and git services commented on AIRFLOW-2504:
----------------------------------------------------------

Commit 86d096004282e6367cb7f4158652f0784b498d0e in incubator-airflow's branch refs/heads/master from [~youngyjd]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=86d0960 ]

[AIRFLOW-2504] Log username correctly and add extra to search columns

Closes #3438 from youngyjd/log-username-old-ui


> Airflow UI Auditing - log username show extra filter
> ----------------------------------------------------
>
>                 Key: AIRFLOW-2504
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2504
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Junda Yang
>            Assignee: Junda Yang
>            Priority: Minor
>
> 1. There is a bug in the [action_logging|https://github.com/apache/incubator-airflow/blob/1f0a717b65e0ea7e0127708b084baff0697f0946/airflow/www/utils.py#L249] of old UI. The *username* attribute is always in *current_user* but it is *None*. We should call *current_user.user.username* to get the username. See example usage of [current_user.user.username|https://github.com/apache/incubator-airflow/blob/1f0a717b65e0ea7e0127708b084baff0697f0946/airflow/www/views.py#L1929]
> 2. We also need to add a column filter on *extra* so we can search for request content, like who send what kind of write request from Airflow UI, as the action_logging is [logging all request parameters|https://github.com/apache/incubator-airflow/blob/1f0a717b65e0ea7e0127708b084baff0697f0946/airflow/www/utils.py#L258] in extra field.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)